Re: Cleanup 4/4: make install-strip in cross-compilation environments

2001-02-25 Thread Tom Tromey
> "adl" == Alexandre Duret-Lutz <[EMAIL PROTECTED]> writes: Tom> I think relying on a subdir `make' invocation expanding Tom> `INSTALL_PROGRAM' correctly is not too likely to work. adl> I still don't and would really like to get more feedback on this. adl> The only workaround I can think o

Re: Cleanup 3/4: make install-strip in cross-compilation environments

2001-02-25 Thread Tom Tromey
> "adl" == Alexandre Duret-Lutz <[EMAIL PROTECTED]> writes: adl> 2001-02-25 Alexandre Duret-Lutz <[EMAIL PROTECTED]> adl>* header-vars.am (INSTALL_STRIP_FLAG): Remove (obsolete). I checked this in. Tom

Re: Cleanup 2/4: make install-strip in cross-compilation environments

2001-02-25 Thread Tom Tromey
> "adl" == Alexandre Duret-Lutz <[EMAIL PROTECTED]> writes: adl> I don't care about depend.m4, this adds only the missing changes adl> from m4/missing.m4. Note that this also fix a bug in adl> AC_MISSING_INSTALL_SH which was using ${ac_auxdir} instead of adl> ${ac_aux_dir}. Why is this nee

Re: Cleanup 1/4: make install-strip in cross-compilation environments

2001-02-25 Thread Tom Tromey
> "adl" == Alexandre Duret-Lutz <[EMAIL PROTECTED]> writes: adl> 2001-02-25 Alexandre Duret-Lutz <[EMAIL PROTECTED]> adl>* ChangeLog (2001-01-28): Remove entries for chunks not applied. I'll check this in. You don't actually need a ChangeLog entry for ChangeLog updates. BTW I discover

Re: Testsuite fails

2001-02-25 Thread Tom Tromey
> "adl" == Alexandre Duret-Lutz <[EMAIL PROTECTED]> writes: Akim> Your explanation is very correct. AC_CHECK_TOOL only needs Akim> host_alias, hence there was no reason to require AC_CANONICAL_*. adl> Has anyone a plan to change this in Automake? Eventually when we move to traces this will

Re: 77-merge-transforms.patch

2001-02-25 Thread Tom Tromey
> "Akim" == Akim Demaille <[EMAIL PROTECTED]> writes: Akim> * automake.in (&transform_cond): Merge into... Akim> (&transform): this. Akim> Adjust all uses. Ok. Tom

Re: 76-magicless-distdirs.patch

2001-02-25 Thread Tom Tromey
> "Akim" == Akim Demaille <[EMAIL PROTECTED]> writes: Akim> * automake.in (&handle_dist): Use &transform instead of dedicated Akim> magic for DISTDIRS. Akim> But be sure to always do it. Akim> * distdir.am: Adjust. This is ok, but... Akim> - grep ($dist_dirs{'$(distdir)/' . $_} = 1,

Re: 75-use-basename.patch

2001-02-25 Thread Tom Tromey
> "Akim" == Akim Demaille <[EMAIL PROTECTED]> writes: Akim> * automake.in: Use File::Basename. Akim> (&dirname, &basename): Remove. Ok. Tom

Re: 74-me.patch

2001-02-25 Thread Tom Tromey
> "Akim" == Akim Demaille <[EMAIL PROTECTED]> writes: Akim> * automake.in ($me): New. Akim> Use it. Akim> (&usage): Display your full name. I use simply `automake' on purpose. Akim> +(my $me = $0) =~ s,.*[\\/],,; However, given that you strip the directory this is ok. What I hate are

Re: 73-texi-dead-options.patch

2001-02-25 Thread Tom Tromey
> "Akim" == Akim Demaille <[EMAIL PROTECTED]> writes: Akim> * automake.texi (Invoking Automake): Remove dead options. Ok. Thanks! Tom

Re: 72-scan-texinfo.patch

2001-02-25 Thread Tom Tromey
> "Akim" == Akim Demaille <[EMAIL PROTECTED]> writes: Akim> * automake.in (&scan_texinfo_file): Also compute the list of files Akim> to clean. Akim> Handle local errors. Akim> (&handle_texinfo): Use it. This is ok. Akim> +my @clean_suffixes = ('aux', 'dvi', 'log', 'ps', 'toc', A

Re: 71-getopt.patch

2001-02-25 Thread Tom Tromey
> "Akim" == Akim Demaille <[EMAIL PROTECTED]> writes: Akim> Add support for `-f', `-V', `-A', `-h'. Akim> + -h, --help print this help, then exit Akim> + -V, --version print version number, then exit I don't see any point in having short forms here. Akim> - --

Re: 65-install-am.patch

2001-02-25 Thread Tom Tromey
>> I think we should have a clean separation between internal and >> external variables here. So how about renaming this as >> `_am_installdirs' or something like that? I have a slight preference >> for lower case internal macro names. Akim> What is the status the patch with _am_installdirs ins

Re: Question marks in Makefile.in

2001-02-25 Thread Tom Tromey
> "Akim" == akim <[EMAIL PROTECTED]> writes: Akim> I will look at this tomorrow and fix it. Without looking at the Akim> code, I think I must have been somewhat too systematic Iin Akim> inserting ?EXEC?, I don't think info page should depend on exec Akim> vs. data. Tom? I'm not sure of my

Re: 52-factored-install.patch

2001-02-25 Thread Tom Tromey
> "Akim" == akim <[EMAIL PROTECTED]> writes: Akim> My bad, I forgot to remove `dir' from the _DATA var. Oops, I missed that too. Akim> mybindir = $(bindir)/my Akim> mybin_DATA = doto User defined variables are handled by name. I agree that this case is handled correctly with the current c

Re: 52-factored-install.patch

2001-02-25 Thread Tom Tromey
> "Akim" == Akim Demaille <[EMAIL PROTECTED]> writes: Akim> .am:19: invalid variable `mysysconfdir_DATA' This should read `Makefile.am:19:...'. Do you know why it broke? Tom

Re: Question marks in Makefile.in

2001-02-25 Thread akim
On Sun, Feb 25, 2001 at 04:31:43PM -0500, Pavel Roskin wrote: > Hello, Akim! > > The version 1.272 of the top-level Makefile.in that you submitted today to > the Automake CVS contains the following lines: > > ?EXEC?insexec-data-am: install-info-am > ?!EXEC?install-data-am: install-info-am > > I

Re: 64-simplify-handle-gettext.patch

2001-02-25 Thread Tom Tromey
> "Akim" == Akim Demaille <[EMAIL PROTECTED]> writes: Tom> Instead they have to use &variable_value or &variable_value_as_list. Akim> &am_line_error ('SUBDIRS', Akim> "AM_GNU_GETTEXT used but \`po' not in SUBDIRS") Akim> if &variable_value ('SUBDIRS') !~ /\bpo\b/; I

Re: 52-factored-install.patch

2001-02-25 Thread akim
On Sun, Feb 25, 2001 at 06:00:29PM -0700, Tom Tromey wrote: > > Akim> mysbindir = $(sbin)/my > Akim> mysbindir_DATA = data > > Akim> .am:11: invalid variable `mysbindir_DATA' > > This is a new failure, since this feature has worked for a long time. My bad, I forgot to remove `dir' from the _DA

Re: 52-factored-install.patch

2001-02-25 Thread Tom Tromey
> "Akim" == Akim Demaille <[EMAIL PROTECTED]> writes: Akim> I think I have this right too, since not all the *.am file Akim> depend on ?EXEC?. See SCRIPTS and PROGRAMS below. The point is that it is the directory name and not the primary that determines which install-* target to use. For i

77-merge-transforms.patch

2001-02-25 Thread Akim Demaille
Index: ChangeLog from Akim Demaille <[EMAIL PROTECTED]> * automake.in (&transform_cond): Merge into... (&transform): this. Adjust all uses. Index: automake.in --- automake.in Sun, 25 Feb 2001 22:16:53 +0100 akim (am/f/39_automake.i 1.83 755) +++ automake

76-magicless-distdirs.patch

2001-02-25 Thread Akim Demaille
Index: ChangeLog from Akim Demaille <[EMAIL PROTECTED]> * automake.in (&handle_dist): Use &transform instead of dedicated magic for DISTDIRS. But be sure to always do it. * distdir.am: Adjust. Index: automake.in --- automake.in Sun, 25 Feb 2001 2

75-use-basename.patch

2001-02-25 Thread Akim Demaille
Index: ChangeLog from Akim Demaille <[EMAIL PROTECTED]> * automake.in: Use File::Basename. (&dirname, &basename): Remove. Index: automake.in --- automake.in Sun, 25 Feb 2001 14:54:59 +0100 akim (am/f/39_automake.i 1.81 755) +++ automake.in Sun, 25 Feb 2001 22:05

74-me.patch

2001-02-25 Thread Akim Demaille
Index: ChangeLog from Akim Demaille <[EMAIL PROTECTED]> * automake.in ($me): New. Use it. (&usage): Display your full name. Index: automake.in --- automake.in Sun, 25 Feb 2001 14:19:25 +0100 akim (am/f/39_automake.i 1.80 755) +++ automake.in Sun, 25 Feb

Question marks in Makefile.in

2001-02-25 Thread Pavel Roskin
Hello, Akim! The version 1.272 of the top-level Makefile.in that you submitted today to the Automake CVS contains the following lines: ?EXEC?insexec-data-am: install-info-am ?!EXEC?install-data-am: install-info-am I believe those question marks are supposed to be processed by Automake. They sho

Re: 52-factored-install.patch

2001-02-25 Thread Akim Demaille
Tom Tromey <[EMAIL PROTECTED]> writes: > > "Akim" == Akim Demaille <[EMAIL PROTECTED]> writes: > > Akim> . &transform_cond ('BASE' => $strip_subdir, > Akim> 'EXEC' => $X =~ /exec/) > > This is still wrong. > > U

`make dist' with srcdir != builddir

2001-02-25 Thread Alexandre Duret-Lutz
Some weeks ago Bruno Haible reported (in private mail) that running `make dist' with srcdir != builddir could produce distributions which are not up-to-date, especially if you have generated files like bison parsers: $builddir/parser.c would be updated whenever $srcdir/parser.y is changed but the

Re: 65-install-am.patch

2001-02-25 Thread Akim Demaille
Tom Tromey <[EMAIL PROTECTED]> writes: > I think we should have a clean separation between internal and > external variables here. So how about renaming this as > `_am_installdirs' or something like that? I have a slight preference > for lower case internal macro names. What is the status the

Re: 64-simplify-handle-gettext.patch

2001-02-25 Thread Akim Demaille
Tom Tromey <[EMAIL PROTECTED]> writes: > > "Akim" == Akim Demaille <[EMAIL PROTECTED]> writes: > > Akim> +&am_line_error ('SUBDIRS', > Akim> + "AM_GNU_GETTEXT used but \`po' not in SUBDIRS") > Akim> + if $contents{'SUBDIRS'} !~ /\bpo\b/; > Akim> +&am_line_error

Re: 52-factored-install.patch

2001-02-25 Thread Tom Tromey
> "Akim" == Akim Demaille <[EMAIL PROTECTED]> writes: Akim> . &transform_cond ('BASE' => $strip_subdir, Akim>'EXEC' => $X =~ /exec/) This is still wrong. User-defined directory names follow the `exec'-name test. autoconf/au

Re: 59-var-vs-target.patch

2001-02-25 Thread Akim Demaille
Akim Demaille <[EMAIL PROTECTED]> writes: > Akim Demaille <[EMAIL PROTECTED]> writes: > > > * tests/vartar.test, tests/ctarget1.test: New. > > I forgot to chmod +x those two files, I'm sorry :( False alarm, I had not applied the patch. Sorry...

Re: 59-var-vs-target.patch

2001-02-25 Thread Akim Demaille
Akim Demaille <[EMAIL PROTECTED]> writes: > * tests/vartar.test, tests/ctarget1.test: New. I forgot to chmod +x those two files, I'm sorry :(

Re: 62-found-dead-found.patch

2001-02-25 Thread Akim Demaille
Tom Tromey <[EMAIL PROTECTED]> writes: > > "Akim" == Akim Demaille <[EMAIL PROTECTED]> writes: > > Akim> * automake.in (&handle_man_pages): $found is dead. > > Ok. > > Which patch renders it dead? It was 56-mying-changes.patch @@ -2507,7 +2506,7 @@ sub handle_man_pages }

Re: 52-factored-install.patch

2001-02-25 Thread Akim Demaille
Tom Tromey <[EMAIL PROTECTED]> writes: > One example of how the new code can fail is a system-dependent header > file install: > > inclexecdir = $(exec_prefix)/include ## Just an example! > inclexec_HEADERS = my-config.h > > With the new code the header will be installed by `install-d

Re: Testsuite fails

2001-02-25 Thread Alexandre Duret-Lutz
>>> "Akim" == Akim Demaille <[EMAIL PROTECTED]> writes: Akim> Pavel Roskin <[EMAIL PROTECTED]> writes: >> Hello, Tom! >> >> > Pavel> AC_CHECK_TOOL([STRIP],[strip]) >> > >> > Yes, I wasn't thinking. I've removed this. >> > >> > Ideally we'd have some way to tell autoconf, "if this packag

Re: Cleanup 2/4: make install-strip in cross-compilation environments

2001-02-25 Thread Alexandre Duret-Lutz
> >>> "Tom" == Tom Tromey <[EMAIL PROTECTED]> writes: > >> "adl" == Alexandre Duret-Lutz <[EMAIL PROTECTED]> writes: > adl> 2001-01-28 Alexandre Duret-Lutz <[EMAIL PROTECTED]> > adl> * m4/strip.m4: New file. > adl> * m4/Makefile.am (m4data_DATA): Add strip.m4. > adl> * m4/init.m4: Call

Re: Cleanup 4/4: make install-strip in cross-compilation environments

2001-02-25 Thread Alexandre Duret-Lutz
[...] Tom> I think relying on a subdir `make' invocation expanding Tom> `INSTALL_PROGRAM' correctly is not too likely to work. adl> I don't know. I still don't and would really like to get more feedback on this. The only workaround I can think off is to select the install program at run t

Re: Cleanup 3/4: make install-strip in cross-compilation environments

2001-02-25 Thread Alexandre Duret-Lutz
> >>> "Tom" == Tom Tromey <[EMAIL PROTECTED]> writes: > > adl> * automake.in (handle_merge_targets): In the install-strip rule, > adl> set INSTALL_PROGRAM to INSTALL_STRIP_PROGRAM, and INSTALL_PROGRAM_ENV > adl> to INSTALL_STRIP_PROGRAM_ENV; don't use INSTALL_STRIP_FLAG. > adl> * progs.am (i

Re: Cleanup 1/4: make install-strip in cross-compilation environments

2001-02-25 Thread Alexandre Duret-Lutz
> >>> "Tom" == Tom Tromey <[EMAIL PROTECTED]> writes: > >> "adl" == Alexandre Duret-Lutz <[EMAIL PROTECTED]> writes: > adl> 2001-01-28 Alexandre Duret-Lutz <[EMAIL PROTECTED]> > adl> * m4/strip.m4: New file. > adl> * m4/Makefile.am (m4data_DATA): Add strip.m4. > adl> * m4/init.m4: Call

73-texi-dead-options.patch

2001-02-25 Thread Akim Demaille
Index: ChangeLog from Akim Demaille <[EMAIL PROTECTED]> * automake.texi (Invoking Automake): Remove dead options. Index: automake.texi --- automake.texi Sun, 25 Feb 2001 13:21:52 +0100 akim (am/f/34_automake.t 1.6 644) +++ automake.texi Sun, 25 Feb 2001 14:29:52 +0100 a

72-scan-texinfo.patch

2001-02-25 Thread Akim Demaille
Index: ChangeLog from Akim Demaille <[EMAIL PROTECTED]> * automake.in (&scan_texinfo_file): Also compute the list of files to clean. Handle local errors. (&handle_texinfo): Use it. Index: Makefile.in --- Makefile.in Sat, 24 Feb 2001 17:12:49 +010

71-getopt.patch

2001-02-25 Thread Akim Demaille
Index: ChangeLog from Akim Demaille <[EMAIL PROTECTED]> * automake.in: Don't pass arguments to... (&parse_arguments): Work on @ARGV. Use Getopt. Add support for `-f', `-V', `-A', `-h'. (&version): New. (&usage): Update. Index: aut

Re: 65-install-am.patch

2001-02-25 Thread akim
On Sat, Feb 24, 2001 at 09:08:37PM -0700, Tom Tromey wrote: > > "Akim" == Akim Demaille <[EMAIL PROTECTED]> writes: > > Parts of this patch I like, but parts I don't like so much. > > Akim> (&file_contents): Be able to grow Automake macros with `+='. > > This is a nice idea, but it