Re: yaccvpath.test

2001-02-26 Thread Tom Tromey
> "Pavel" == Pavel Roskin <[EMAIL PROTECTED]> writes: Pavel> I don't quite understand whether your test is supposed to work Pavel> or not. It's failing for me (besides the typo in Pavel> tests/Makefile.am that I've just fixed). Alexandre claims it fails. I've updated it a bit. Now it works

dist-all

2001-02-26 Thread Tom Tromey
Akim -- I think one of your patches probably broke `make dist-all'. Right now it ends up depending on each dist target that is used. However each such target ends by removing the dist directory. The point of having dist-all is that it is more efficient to simply create the dist directory once, d

Re: `make dist' with srcdir != builddir

2001-02-26 Thread Tom Tromey
> "adl" == Alexandre Duret-Lutz <[EMAIL PROTECTED]> writes: adl> This can be easily fixed by changing the distdir code to look for adl> files in the builddir first and failling back to look in the adl> srcdir if needed. But maybe this is not the right fix; maybe adl> bison should not output

yaccvpath.test

2001-02-26 Thread Pavel Roskin
Hello, Alexandre! I don't quite understand whether your test is supposed to work or not. It's failing for me (besides the typo in tests/Makefile.am that I've just fixed). I believe there is a convention in Automake that whenever a knowingly failing test is committed, it is added to XFAIL_TESTS,

Re: 71-getopt.patch

2001-02-26 Thread Tom Tromey
Akim> - --amdir=DIR directory storing config files Akim> + -A, --amdir=DIR directory storing config files >> I definitely don't want a short form for this. >> This option shouldn't really be used by users. Akim> I use it all the time when hacking Autoconf and Automake :) You a

Re: 78-fix-percent.patch

2001-02-26 Thread Tom Tromey
> "Akim" == Akim Demaille <[EMAIL PROTECTED]> writes: Akim> * mans.am: s/INSTALL_MAN/INSTALL-MAN/. Akim> * automake.in (&handle_clean): Don't escape what's given to Akim> &transform. Ok. Tom

Re: s/@/%/g

2001-02-26 Thread Tom Tromey
> "Akim" == Akim Demaille <[EMAIL PROTECTED]> writes: Akim> * automake.in (&add_depend2): Transform AMDEP. Akim> (&handle_clean): Transform MCFILES and MFILES. Akim> (&file_contents): Transform MAINTAINER_MODE. Akim> (&transform): Use `%', not `@'. Akim> Adjust all the *.am files. A

Re: Question marks in Makefile.in

2001-02-26 Thread Tom Tromey
Akim> I tend to think it is the same for mans.am. I think you're right. Man pages have to be handled specially. Nobody has ever complained about this not working right either. Tom

Re: Question marks in Makefile.in

2001-02-26 Thread Tom Tromey
> "Akim" == Akim Demaille <[EMAIL PROTECTED]> writes: Akim> * texinfos.am: No ?EXEC? hook as currently installing TEXINFOS is Akim> necessarily in infodir. Ok. Akim> -?EXEC??INSTALL-INFO?insexec-data-am: install-info-am Akim> -?!EXEC??INSTALL-INFO?install-data-am: install-in

Re: Question marks in Makefile.in

2001-02-26 Thread Tom Tromey
> "Akim" == Akim Demaille <[EMAIL PROTECTED]> writes: >> * A user-defined directory is valid for any primary Akim> My understanding of texinfos.am is that this is not supported Akim> for _TEXINFOS. Yet? Should it? True, it isn't. I don't think we need to support it. Nobody has ever comp

78-fix-percent.patch

2001-02-26 Thread Akim Demaille
I checked the effect of the % percent change on the fileutils, and it revealed one bug. Another one was made visible. Index: ChangeLog from Akim Demaille <[EMAIL PROTECTED]> * mans.am: s/INSTALL_MAN/INSTALL-MAN/. * automake.in (&handle_clean): Don't escape what's given to

Re: s/@/%/g

2001-02-26 Thread Akim Demaille
All 273 tests passed :)

Re: 52-factored-install.patch

2001-02-26 Thread Akim Demaille
I should have emphasized that there are no diffs for Automake's Makefile.ins. The test suite is now at libobj*.test, no errors so far.

Re: 52-factored-install.patch

2001-02-26 Thread Akim Demaille
Tom Tromey <[EMAIL PROTECTED]> writes: > Me, too, but: > > * Automake is really slow > * We already have tons of other global constants > > Please change it back. No problem!

s/@/%/g

2001-02-26 Thread Akim Demaille
Well, this one was tricky... I ran the test suite, caught a few mistakes, and it's running again. Given the time it takes to run it, I think I will soon leave, and check the results tonight. _if_ the test suite passes everything, is it OK to install? Beware, it's frightening... Index: Change

Re: 52-factored-install.patch

2001-02-26 Thread Tom Tromey
> "Akim" == Akim Demaille <[EMAIL PROTECTED]> writes: >> How smart is Perl? >> I used to have this as a global so that it wasn't reevaluated each >> time through the loop. It never changes -- it is a constant >> structure. Akim> I privileged readability and modularity over efficiency. Me,

Re: 52-factored-install.patch

2001-02-26 Thread Akim Demaille
Tom Tromey <[EMAIL PROTECTED]> writes: > Akim> + # Directories installed during 'install-exec' phase. > Akim> + my %exec_dir_p = > Akim> + ( > Akim> [ ... ] > > How smart is Perl? > I used to have this as a global so that it wasn't reevaluated each > time through

Re: 52-factored-install.patch

2001-02-26 Thread Tom Tromey
> "Akim" == Akim Demaille <[EMAIL PROTECTED]> writes: Akim> * automake.in (&am_install_var): Recognize whether predefined Akim> directories are `data' or `exec'. Akim> * libs.am, ltlib.am, progs.am, python.am, scripts.am: Install Akim> ?EXEC?. You checked this in already, which is fi

Re: 52-factored-install.patch

2001-02-26 Thread Akim Demaille
Given that this time I think I understood, that the bug was really bad for users, I went ahead and applied it. Tom, feel free to strengthen instdata2! Here is what I committed. #! /bin/sh # Test that installing under $exec_prefix is handled by install-exec. # Testing with headers for instance.

Re: 52-factored-install.patch

2001-02-26 Thread Akim Demaille
I think I finally have it. I apologize for all the iterations I needed :( Index: ChangeLog from Akim Demaille <[EMAIL PROTECTED]> * automake.in (&am_install_var): Recognize whether predefined directories are `data' or `exec'. * libs.am, ltlib.am, progs.am, python.am, s

Re: Question marks in Makefile.in

2001-02-26 Thread Akim Demaille
Akim Demaille <[EMAIL PROTECTED]> writes: > > infodir is hardcoded, no means to have others. > > > > So at least currently this one does not need the ?EXEC? hook. If > > there is a bug, it needs much more work. I tend to think it is the same for mans.am. I don't fix it.

Re: Question marks in Makefile.in

2001-02-26 Thread Akim Demaille
Akim Demaille <[EMAIL PROTECTED]> writes: FYI: > infodir is hardcoded, no means to have others. > > So at least currently this one does not need the ?EXEC? hook. If > there is a bug, it needs much more work. Index: ChangeLog from Akim Demaille <[EMAIL PROTECTED]> * texinfos.am: No ?

Re: Question marks in Makefile.in

2001-02-26 Thread Akim Demaille
Tom Tromey <[EMAIL PROTECTED]> writes: > For a given primary we try to detect which directories are valid. > > * A user-defined directory is valid for any primary My understanding of texinfos.am is that this is not supported for _TEXINFOS. Yet? Should it? ?EXEC??INSTALL-INFO?install-exec-am:

Re: Question marks in Makefile.in

2001-02-26 Thread Akim Demaille
Tom Tromey <[EMAIL PROTECTED]> writes: > * A user-defined directory is valid for any primary But obeys the m/exec/ rule. Which means my assumption that programs.am etc. did not need the ?EXEC? hooks was wrong. OK, thanks! > * The valid standard directories are chosen on a per-primary basis. >

Re: 52-factored-install.patch

2001-02-26 Thread Tom Tromey
> "Akim" == Akim Demaille <[EMAIL PROTECTED]> writes: Akim> So it is my (today's :) understanding that I did wrong to have Akim> some primaries independent from the dir name, right? Right. The primaries are irrelevant at this stage. Akim> But both CVS and 1.4 refuse sbin_DATA :( Sorry, ba

Re: 74-me.patch

2001-02-26 Thread Tom Tromey
> "Akim" == Akim Demaille <[EMAIL PROTECTED]> writes: Akim> * automake.in ($me): New. Akim> Use it. Akim> (&usage): Display your full name. >> I use simply `automake' on purpose. Akim> So I won't apply this part. I made that change because it's Akim> consistent which most tools: Sorry, th

Re: Question marks in Makefile.in

2001-02-26 Thread Lars J. Aas
On Mon, Feb 26, 2001 at 04:25:31PM +0100, Akim Demaille wrote: : My suggestion is therefore that this should become : : ?AMDEP?@AMDEP@%FPFX%DEPMODE = @%FPFX%DEPMODE@ How about changing the ?VAR?/?!VAR? syntax to %VAR?%/%!VAR?% at the same time? Lars J

Re: Question marks in Makefile.in

2001-02-26 Thread Akim Demaille
Pavel Roskin <[EMAIL PROTECTED]> writes: > > Nonetheless, given that we can never be sure to what extend the test > > suite exercise Automake, I would include it anyway: better have > > automake dying than make. Just imagine > > > > ?SOME-CONDITION-RARELY-TRUE? %SOME-PARAM-WE-FORGOT%. > > Ok

Re: Question marks in Makefile.in

2001-02-26 Thread Pavel Roskin
> Nonetheless, given that we can never be sure to what extend the test > suite exercise Automake, I would include it anyway: better have > automake dying than make. Just imagine > > ?SOME-CONDITION-RARELY-TRUE? %SOME-PARAM-WE-FORGOT%. Ok Regards, Pavel Roskin

Re: Question marks in Makefile.in

2001-02-26 Thread Akim Demaille
Pavel Roskin <[EMAIL PROTECTED]> writes: > I mean, this check is _probably_ not necessary on a user system, since the > users will use well tested versions of Automake. But I don't have a strong > opinion. A fast and simple check should not be a big deal. > > Developers of Automake, however, sho

Re: Question marks in Makefile.in

2001-02-26 Thread Pavel Roskin
Hello, Akim! > > Maybe it's not necessary to check the output since the user is highly > > unlikely to use ?FOO? in Makefile.am. I understand it's an internal > > mechanism for Automake, not exposed to users. > > > > However, an optional check would be appropriate. It could be turned on in > > th

Re: Question marks in Makefile.in

2001-02-26 Thread Akim Demaille
Pavel Roskin <[EMAIL PROTECTED]> writes: > Hello, Akim! > > > > ?EXEC?insexec-data-am: install-info-am > > > ?!EXEC?install-data-am: install-info-am > > By the way, it will be nice to have a test that actually fails in absense > of insexec-data-am or install-data-am. Err, insexec does not exis

Re: Question marks in Makefile.in

2001-02-26 Thread Pavel Roskin
Hello, Akim! > > ?EXEC?insexec-data-am: install-info-am > > ?!EXEC?install-data-am: install-info-am By the way, it will be nice to have a test that actually fails in absense of insexec-data-am or install-data-am. > Still, this bug can be easily detected by automake. But @FOO@ bugs Maybe it's

Re: Current problems

2001-02-26 Thread Akim Demaille
Akim Demaille <[EMAIL PROTECTED]> writes: > Is there anything special about foreach loops? man perlsyn Foreach Loops The `foreach' loop iterates over a normal list value and sets the variable VAR to be each element of the list in turn. If the variable is preceded w

Re: Current problems

2001-02-26 Thread Akim Demaille
Akim Demaille <[EMAIL PROTECTED]> writes: > 2. error messages >for some reason I did not track down, am outputs only the suffix >(.am), instead of the name of the bad file (Makefile.am). Tracked down, and I have a fix, but given that I don't understand why it behaves this way, I'd like s

FYI: install.am is not in Makefile.am

2001-02-26 Thread Pavel Roskin
Hello! The top-level Makefile.am on CVS Automake doesn't know anything about install.am. _ --- ChangeLog +++ ChangeLog @@ -1,3 +1,7 @@ +2001-02-26 Pavel Roskin <[EMAIL PROTECTED]> + + * Makefile.am: Add install.am. + 2001-02-26 Akim Demaille <[EMAIL PROTECTED]>

Re: Cleanup 4/4: make install-strip in cross-compilation environments

2001-02-26 Thread Alexandre Duret-Lutz
I just thought about another minor detail Calling `CDPATH=: && cd $_am_dirpart && pwd`/install-sh disallows the use of install.sh. -- Alexandre Duret-Lutz

Re: Testsuite fails

2001-02-26 Thread Alexandre Duret-Lutz
>>> "Tom" == Tom Tromey <[EMAIL PROTECTED]> writes: >> "adl" == Alexandre Duret-Lutz <[EMAIL PROTECTED]> writes: [...] adl> Otherwise, as install-strip is concerned, another idea is to: adl> 1) not call AM_PROG_INSTALL_STRIP from AM_INIT_AUTOMAKE adl> 2) revert all `commenting' that has

Re: Cleanup 4/4: make install-strip in cross-compilation environments

2001-02-26 Thread Alexandre Duret-Lutz
>>> "Tom" == Tom Tromey <[EMAIL PROTECTED]> writes: >> "adl" == Alexandre Duret-Lutz <[EMAIL PROTECTED]> writes: Tom> I think relying on a subdir `make' invocation expanding Tom> `INSTALL_PROGRAM' correctly is not too likely to work. adl> I still don't and would really like to get more

Re: Cleanup 2/4: make install-strip in cross-compilation environments

2001-02-26 Thread Alexandre Duret-Lutz
>>> "Tom" == Tom Tromey <[EMAIL PROTECTED]> writes: >> "adl" == Alexandre Duret-Lutz <[EMAIL PROTECTED]> writes: adl> I don't care about depend.m4, this adds only the missing changes adl> from m4/missing.m4. Note that this also fix a bug in adl> AC_MISSING_INSTALL_SH which was using ${ac

Re: Current problems

2001-02-26 Thread Akim Demaille
Akim Demaille <[EMAIL PROTECTED]> writes: > 4. handle_factored_dependencies >is outputting in an order which is not the one I want. >I have not understood why, nor why it suddenly changed. In >particular .PHONY is no longer last as it should. Solved. From perldelta (I'm running 5.6

Current problems

2001-02-26 Thread Akim Demaille
1. instdata2.test I think this time I understood what must be done, but given that there are impossible combinations between primaries and dirs, I'd like someone to fix the test itself, then I'll know exactly what is to be done. 2. error messages for some reason I did not track do

Re: 76-magicless-distdirs.patch

2001-02-26 Thread Akim Demaille
Tom Tromey <[EMAIL PROTECTED]> writes: > > "Akim" == Akim Demaille <[EMAIL PROTECTED]> writes: > > Akim> * automake.in (&handle_dist): Use &transform instead of dedicated > Akim> magic for DISTDIRS. > Akim> But be sure to always do it. > Akim> * distdir.am: Ad

Re: 72-scan-texinfo.patch

2001-02-26 Thread Akim Demaille
Tom Tromey <[EMAIL PROTECTED]> writes: > Akim> +my @clean_suffixes = ('aux', 'dvi', 'log', 'ps', 'toc', > Akim> + # grep new.*index texinfo.tex > Akim> + 'cp', 'fn', 'ky', 'vr', 'tp', 'pg'); > > Why is this list so much shorter than the old lis

Re: 67-bigger-handle-factored-dependencies.patch

2001-02-26 Thread Akim Demaille
Tom Tromey <[EMAIL PROTECTED]> writes: > What is the `dist-all' target used for? I see it is collected in > %dependencies. It makes all the flavors of dists. Mon Sep 23 00:04:48 1996 Tom Tromey <[EMAIL PROTECTED]> * automake.in (initialize_global_constants): Define %dist, di

Re: 52-factored-install.patch

2001-02-26 Thread Akim Demaille
Tom Tromey <[EMAIL PROTECTED]> writes: > > "Akim" == akim <[EMAIL PROTECTED]> writes: > > Akim> My bad, I forgot to remove `dir' from the _DATA var. > > Oops, I missed that too. > > Akim> mybindir = $(bindir)/my > Akim> mybin_DATA = doto > > User defined variables are handled by name. >

Re: 74-me.patch

2001-02-26 Thread Akim Demaille
Tom Tromey <[EMAIL PROTECTED]> writes: > > "Akim" == Akim Demaille <[EMAIL PROTECTED]> writes: > > Akim> * automake.in ($me): New. > Akim> Use it. > Akim> (&usage): Display your full name. > > I use simply `automake' on purpose. So I won't apply this part. I made t

Re: 71-getopt.patch

2001-02-26 Thread Akim Demaille
Tom Tromey <[EMAIL PROTECTED]> writes: > > "Akim" == Akim Demaille <[EMAIL PROTECTED]> writes: > > Akim> Add support for `-f', `-V', `-A', `-h'. > > Akim> + -h, --help print this help, then exit > Akim> + -V, --version print version number, then exit > > I do