Re: DIST_COMMON broke

2001-05-13 Thread Tom Tromey
> "Derek" == Derek R Price <[EMAIL PROTECTED]> writes: >> Yeah, I still have a few of your patches sitting in my mailbox. Derek> Well, when you get around to it, this one should take the place Derek> of my last depcomp patch. I fixed tests/depcomp, tidied the Derek> ChangeLog based on the s

Re: DIST_COMMON broke

2001-02-07 Thread Derek R. Price
Tom Tromey wrote: > > "Derek" == Derek R Price <[EMAIL PROTECTED]> writes: > > Derek> Also, looking at this area of the code reminds me that I sent > Derek> a, unfortunately largish, patch in something over a month ago > Derek> that hasn't been reviewed to my knowledge. The patch was > Derek

Re: DIST_COMMON broke

2001-02-07 Thread Derek R. Price
Tom Tromey wrote: > > "Derek" == Derek R Price <[EMAIL PROTECTED]> writes: > > Derek> Also, looking at this area of the code reminds me that I sent > Derek> a, unfortunately largish, patch in something over a month ago > Derek> that hasn't been reviewed to my knowledge. The patch was > Derek

Re: DIST_COMMON broke

2001-02-07 Thread Derek R. Price
"Derek R. Price" wrote: > Tom Tromey wrote: > > > Derek> Checked in? Fixes? I'm not pulling any changes... > > > > I can't explain that. I've seen the commit message and everything. > > > > You aren't using the subversions automake are you? > > That is a mirror that doesn't update. > > Yeah, I

Re: DIST_COMMON broke

2001-02-07 Thread Tom Tromey
>> You aren't using the subversions automake are you? >> That is a mirror that doesn't update. Derek> Yeah, I am. Where is the other one? All the info is available via the home page. http://sources.redhat.com/automake/ Tom

Re: DIST_COMMON broke

2001-02-07 Thread Derek R. Price
Tom Tromey wrote: > Derek> Checked in? Fixes? I'm not pulling any changes... > > I can't explain that. I've seen the commit message and everything. > > You aren't using the subversions automake are you? > That is a mirror that doesn't update. Yeah, I am. Where is the other one? Derek -- De

Re: DIST_COMMON broke

2001-02-07 Thread Tom Tromey
> "Derek" == Derek R Price <[EMAIL PROTECTED]> writes: Derek> Also, looking at this area of the code reminds me that I sent Derek> a, unfortunately largish, patch in something over a month ago Derek> that hasn't been reviewed to my knowledge. The patch was Derek> intended to fix a misplaced

Re: DIST_COMMON broke

2001-02-07 Thread Tom Tromey
Derek> Checked in? Fixes? I'm not pulling any changes... I can't explain that. I've seen the commit message and everything. You aren't using the subversions automake are you? That is a mirror that doesn't update. Tom

Re: DIST_COMMON broke

2001-02-07 Thread Derek R. Price
Tom Tromey wrote: > > "Pavel" == Pavel Roskin <[EMAIL PROTECTED]> writes: > > >> I'm checking this in. > > Pavel> I'm sorry, but the bug seems to be yours. The new test fails > Pavel> after automake.in changes from revision 1.848 to 1.849. > > Oh, I know it is mine.. > > Pavel> In fact it say

Re: DIST_COMMON broke

2001-02-07 Thread Derek R. Price
Tom Tromey wrote: > Anyway I wrote a test for the weird case and checked it in. > > I also checked in a fix for both the recent bugs in that area. I'm > afraid I'm not entirely sure why my fix fixes distcommon.test :-(. Checked in? Fixes? I'm not pulling any changes... Derek -- Derek Price

Re: DIST_COMMON broke

2001-02-07 Thread Tom Tromey
>> This area still requires more work. I think I know another case where >> it can fail: suppose you do `AC_OUTPUT(subdir/foo)' where there is no >> Makefile.am in subdir? Then I think no rule to rebuild subdir/foo >> will be generated. Pavel> I would not call it a "failure" - if Automake doesn

Re: DIST_COMMON broke

2001-02-07 Thread Pavel Roskin
> This area still requires more work. I think I know another case where > it can fail: suppose you do `AC_OUTPUT(subdir/foo)' where there is no > Makefile.am in subdir? Then I think no rule to rebuild subdir/foo > will be generated. I would not call it a "failure" - if Automake doesn't control

Re: DIST_COMMON broke

2001-02-07 Thread Tom Tromey
> "Pavel" == Pavel Roskin <[EMAIL PROTECTED]> writes: >> I'm checking this in. Pavel> I'm sorry, but the bug seems to be yours. The new test fails Pavel> after automake.in changes from revision 1.848 to 1.849. Oh, I know it is mine.. Pavel> In fact it says directly: "Don't push @inputs ont

Re: DIST_COMMON broke

2001-02-07 Thread Pavel Roskin
Hello, Tom! > Derek> I've attached a slightly more succinct test for the original > Derek> problem I pointed out (distcommon.test). It's nice as a > Derek> perquisite at least, as it doesn't require autoconf or make... > Derek> I'm not quite sure I understand the second problem you pointed > Der

Re: DIST_COMMON broke

2001-02-07 Thread Tom Tromey
> "Derek" == Derek R Price <[EMAIL PROTECTED]> writes: Derek> I've attached a slightly more succinct test for the original Derek> problem I pointed out (distcommon.test). It's nice as a Derek> perquisite at least, as it doesn't require autoconf or make... Derek> I'm not quite sure I understa

Re: DIST_COMMON broke

2001-02-07 Thread Derek R. Price
Pavel Roskin wrote: > The new test fails exactly how it should. I'm going to apply it unless you > come with something better. Well, you should have seen my slightly more succinct version by now. I'd say check them both in, as there is some logic that says it'd be nice to be able to notice the

Re: DIST_COMMON broke

2001-02-07 Thread Derek R. Price
Pavel Roskin wrote: > Hello, Derek! > > > > > Looks like someone broke the 'make dist' target in the last few days. > > I also noticed that. > > > > > Specifically, input files from AC_OUTPUT are no longer being added to > > > > DIST_COMMON... > > Exactly the same problem. > > > > Here's the patc

Re: DIST_COMMON broke

2001-02-07 Thread Pavel Roskin
Hello, Derek! > How about this test (distdir2.test): Oops, posted to early. Some sanity checks were missing. > It fails even earlier when it creates an empty archive on "make dist". > This seems to be another bug. Never mind. I just forgot to remove "missing". The new test fails exactly how i

Re: DIST_COMMON broke

2001-02-07 Thread Pavel Roskin
Hello, Derek! > > > Looks like someone broke the 'make dist' target in the last few days. I also noticed that. > > > Specifically, input files from AC_OUTPUT are no longer being added to > > > DIST_COMMON... Exactly the same problem. > > Here's the patch. > > This doesn't appear to be the cor

Re: DIST_COMMON broke

2001-02-07 Thread Derek R. Price
"Derek R. Price" wrote: > "Derek R. Price" wrote: > > > Looks like someone broke the 'make dist' target in the last few days. > > Specifically, input files from AC_OUTPUT are no longer being added to > > DIST_COMMON... > > Here's the patch. This doesn't appear to be the correct fix. I'll write

Re: DIST_COMMON broke

2001-02-07 Thread Derek R. Price
"Derek R. Price" wrote: > Looks like someone broke the 'make dist' target in the last few days. > Specifically, input files from AC_OUTPUT are no longer being added to > DIST_COMMON... Here's the patch. Derek -- Derek Price CVS Solutions Architect ( http://CVSHome.org ) ma