Re: PATCH: patsubst support

2001-02-23 Thread Tom Tromey
"Tom" == Tom Tromey [EMAIL PROTECTED] writes: Following up my own post... Tom if FOO Tom var = a b c Tom else Tom var = d e f Tom endif Tom derived = $(var:%=%.c) Tom Will this work correctly? In this situation we have to give Tom `derived' the same conditions as

Re: PATCH: patsubst support

2001-02-23 Thread Derek R. Price
Tom Tromey wrote: if FOO var = a b endif derived = $(var:%=%.c) if BAR var = c d endif Isn't the order irrelevant here since derived won't be evaluated until it's used? Um, the gmake manual calls this "expanded when read, except for the shell commands in

Re: PATCH: patsubst support

2001-02-23 Thread Tom Tromey
"Derek" == Derek R Price [EMAIL PROTECTED] writes: if FOO var = a b endif derived = $(var:%=%.c) if BAR var = c d endif Derek Isn't the order irrelevant here since derived won't be Derek evaluated until it's used? No, because we're talking about having automake itself expand the

Re: PATCH: patsubst support

2001-02-22 Thread Tom Tromey
"Kevin" == Kevin Ryde [EMAIL PROTECTED] writes: Kevin It'd be nice to be able to embed little fragments of perl to do Kevin things like that, for the "static" case that is. But perhaps Kevin that idea has come up before. I've long resisted letting the user extend Makefile.am with Perl code. I

Re: PATCH: patsubst support

2001-02-22 Thread Tom Tromey
"Akim" == Akim Demaille [EMAIL PROTECTED] writes: Akim Yep, by default Automake must not let the users do nonportable Akim things. I'm sorry about that, but I believe it's a strong Akim requirement. I'm finally following up to this -- it was buried in my overly large automake mailbox.

Re: PATCH: patsubst support

2001-02-22 Thread Tom Tromey
"Pavel" == Pavel Roskin [EMAIL PROTECTED] writes: -($from = $2) =~ s/(\W)/\\$1/g; +($from = $2) =~ s/(\W)/$1/g; Pavel I don't understrand this. This change will affect the Pavel traditional rules as well. It should probably be a separate Pavel patch if it fixes a

Re: PATCH: patsubst support

2001-02-19 Thread Pavel Roskin
Hello, Alex! Here is a new version of the patsubst patch against cvs HEAD. Thanks! Were are getting closer. + * automake.in (expand_contents): add new function to perform + the patsubst expansion + (value_to_list): add support for patsubst style variable + substitution. +

Re: PATCH: patsubst support

2001-02-19 Thread Alex Hornby
Pavel Roskin writes: - ($from = $2) =~ s/(\W)/\\$1/g; + ($from = $2) =~ s/(\W)/$1/g; I don't understrand this. This change will affect the traditional rules as well. It should probably be a separate patch if it fixes a separate issue. You may even need a test

Re: PATCH: patsubst support

2001-02-18 Thread Alex Hornby
Here is a new version of the patsubst patch against cvs HEAD. It is now smaller due to the removal of a superflous option, and has my instead of local etc. Also the conditional test is improved. After applying the patch remember to make the .test files executable. That has caught me out on

Re: PATCH: patsubst support

2001-02-14 Thread Pavel Roskin
Hello, Alex! Sorry for another delay. Your patch is very important, but unfortunately I'm have been very busy recently. Here is an updated patsubst patch against CVS automake. Any patsubst style variables are now staticly expanded by automake, thus avoiding make portability problems. We now

Re: PATCH: patsubst support

2001-01-24 Thread Akim Demaille
"Pavel" == Pavel Roskin [EMAIL PROTECTED] writes: Pavel Hello! Trying to catch up with the mailing lists :-) Pavel I'm surprised that this patch has not been applied since Pavel October. I believe it's very valuable. I even considered doing Pavel it myself. We ended stuck with a portability

Re: PATCH: patsubst support

2001-01-23 Thread Pavel Roskin
Hello! Trying to catch up with the mailing lists :-) I'm surprised that this patch has not been applied since October. I believe it's very valuable. I even considered doing it myself. b) default static expansion to off, avoids surprising anyone depending on dynamic expansion by make,

Re: PATCH: patsubst support

2000-10-29 Thread Kevin Ryde
Alex Hornby [EMAIL PROTECTED] writes: # Makefile.am fragment FOO = foo bar BAR = ${FOO:%=%.c} ... What do people think? It'd be nice to be able to embed little fragments of perl to do things like that, for the "static" case that is. But perhaps that idea has come up before. Or

Re: PATCH: patsubst support

2000-10-28 Thread Alex Hornby
Alexandre Oliva writes: On Oct 27, 2000, Akim Demaille [EMAIL PROTECTED] wrote: Yep, by default Automake must not let the users do nonportable things. I tend to agree. But I wouldn't say `must not', I'd say `should not'. What is the policy regarding changes to non-portable

Re: PATCH: patsubst support

2000-10-27 Thread Alexandre Oliva
On Oct 27, 2000, Akim Demaille [EMAIL PROTECTED] wrote: Yep, by default Automake must not let the users do nonportable things. I tend to agree. But I wouldn't say `must not', I'd say `should not'. -- Alexandre Oliva Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/ Red Hat GCC

Re: PATCH: patsubst support

2000-10-25 Thread Akim Demaille
| Akim, Hi Alex, Glad to see your progresses! | Here is a patch to add patsubst support to value_to_list. I've | included a new test case "patsubst.test" as well. That's great news! Thanks a lot! But I'm going to be a pain, especially because I'm not the official maintainer of Automake,

Re: PATCH: patsubst support

2000-10-25 Thread Alex Hornby
Akim, Okay, here is patsubst patch v2. New since last time: * ChangeLog entry formatting * NEWS entry * Documentation (first texinfo usage, please beware!) The _PROGRAMS based example in the documentation needs a patsubst supporting make (e.g. GNU and Solaris work). This is because the

Re: PATCH: patsubst support

2000-10-25 Thread Akim Demaille
"Alex" == Alex Hornby [EMAIL PROTECTED] writes: Alex Akim, Alex Okay, here is patsubst patch v2. Thanks! Alex The _PROGRAMS based example in the documentation needs a Alex patsubst supporting make (e.g. GNU and Solaris work). This is Alex because the program target writes prog_SOURCES to the

Re: PATCH: patsubst support

2000-10-25 Thread Alex Hornby
Akim Demaille writes: Sorry, I'm confused, and the documentation snippet didn't really enlighten me :( Hi Akim, The reasoning was fairly tortured :) To document the patsubst internal change I had to invent a contrived example so that the user could see the expansion. That example