Re: revision control info in generated files

2010-04-28 Thread Jef Driesen
On 12/04/2010 15:58, Peter Johansson wrote: Jef Driesen wrote: On 12/04/10 14:59, Peter Johansson wrote: Also, I would try avoid distributing `version.h', but not sure how to do that from top of my head. Why would you not distribute it? Well, it's a matter of taste, but I see no real reason

Re: revision control info in generated files

2010-04-13 Thread Peter Johansson
Seems like something went wrong with my previous post so here is another attempt. Jef Driesen wrote: On 13/04/10 11:33, Steffen Dettmer wrote: I think including the generated source in the tarball is wrong and can break things. First thing that will break is that you will have one version.h in

Re: revision control info in generated files

2010-04-13 Thread Peter Johansson

Re: revision control info in generated files

2010-04-13 Thread Jef Driesen
On 13/04/10 11:33, Steffen Dettmer wrote: I think including the generated source in the tarball is wrong and can break things. First thing that will break is that you will have one version.h in srcdir (from the tarball) and optionally a second one in builddir (from config.status/make). (config.h

Re: revision control info in generated files

2010-04-13 Thread Steffen Dettmer
On Mon, Apr 12, 2010 at 4:16 PM, Jef Driesen wrote: > > On 12/04/10 15:58, Peter Johansson wrote: > > > > Jef Driesen wrote: > > > > > > On 12/04/10 14:59, Peter Johansson wrote: > > > > > > > > Also, I would try avoid distributing `version.h', but not > > > > sure how to do that from top of my he

Re: revision control info in generated files

2010-04-12 Thread Jef Driesen
On 12/04/10 15:58, Peter Johansson wrote: Jef Driesen wrote: On 12/04/10 14:59, Peter Johansson wrote: Also, I would try avoid distributing `version.h', but not sure how to do that from top of my head. Why would you not distribute it? Well, it's a matter of taste, but I see no real reason t

Re: revision control info in generated files

2010-04-12 Thread Peter Johansson
Jef Driesen wrote: On 12/04/10 14:59, Peter Johansson wrote: Also, I would try avoid distributing `version.h', but not sure how to do that from top of my head. Why would you not distribute it? Well, it's a matter of taste, but I see no real reason to include it in the tarball. I think it's

Re: revision control info in generated files

2010-04-12 Thread Jef Driesen
On 12/04/10 14:59, Peter Johansson wrote: Jef Driesen wrote: mylib_la_SOURCES += version.c mylib_HEADERS += version.h BUILT_SOURCES = version.h EXTRA_DIST += $(srcdir)/version CLEANFILES += version-t Took me a while to figure out the escaping of the @ symbol. It seems to work fine, except that

Re: revision control info in generated files

2010-04-12 Thread Jef Driesen
On 12/04/10 14:39, Jef Driesen wrote: On 02/04/10 14:37, Peter Johansson wrote: On 4/2/10 7:04 AM, Jef Driesen wrote: I also have a corresponding version.c file that has the same info, but for use at runtime: #include "version.h const int mylib_version_major = MYLIB_VERSION_MAJOR; const int my

Re: revision control info in generated files

2010-04-12 Thread Peter Johansson
Jef Driesen wrote: mylib_la_SOURCES += version.c mylib_HEADERS += version.h BUILT_SOURCES = version.h EXTRA_DIST += $(srcdir)/version CLEANFILES += version-t Took me a while to figure out the escaping of the @ symbol. It seems to work fine, except that I would like to add "$(srcdir)/version.h.

Re: revision control info in generated files

2010-04-12 Thread Jef Driesen
On 02/04/10 14:37, Peter Johansson wrote: On 4/2/10 7:04 AM, Jef Driesen wrote: The problem I'm trying to solve is that I already have a version.h that is generated from a version.h.in template that contains: #define MYLIB_VERSION_MAJOR @MYLIB_VERSION_MAJOR@ #define MYLIB_VERSION_MINOR @MYLIB_

Re: revision control info in generated files

2010-04-02 Thread Peter Johansson
On 4/2/10 7:04 AM, Jef Driesen wrote: The problem I'm trying to solve is that I already have a version.h that is generated from a version.h.in template that contains: #define MYLIB_VERSION_MAJOR @MYLIB_VERSION_MAJOR@ #define MYLIB_VERSION_MINOR @MYLIB_VERSION_MINOR@ #define MYLIB_VERSION_MICR

Re: revision control info in generated files

2010-04-02 Thread Jef Driesen
On 02/04/10 11:58, Ralf Wildenhues wrote: * Jef Driesen wrote on Fri, Apr 02, 2010 at 11:45:20AM CEST: On 01/04/10 20:31, Ralf Wildenhues wrote: * Jef Driesen wrote on Thu, Apr 01, 2010 at 02:34:29PM CEST: Since the .git-version file is a generated file, I would think it belongs in the build d

Re: revision control info in generated files

2010-04-02 Thread Ralf Wildenhues
* Jef Driesen wrote on Fri, Apr 02, 2010 at 11:45:20AM CEST: > On 01/04/10 20:31, Ralf Wildenhues wrote: > >* Jef Driesen wrote on Thu, Apr 01, 2010 at 02:34:29PM CEST: > >>Since the .git-version file is a generated file, I would think it > >>belongs in the build directory, where all other generate

Re: revision control info in generated files

2010-04-02 Thread Jef Driesen
On 01/04/10 20:31, Ralf Wildenhues wrote: * Jef Driesen wrote on Thu, Apr 01, 2010 at 02:34:29PM CEST: On 31/03/10 22:45, Ralf Wildenhues wrote: * Jef Driesen wrote on Wed, Mar 31, 2010 at 02:49:48PM CEST: Shouldn't the .git-version file be created inside the build directory, rather than the s

Re: revision control info in generated files

2010-04-01 Thread Ralf Wildenhues
* Jef Driesen wrote on Thu, Apr 01, 2010 at 02:34:29PM CEST: > On 31/03/10 22:45, Ralf Wildenhues wrote: > >* Jef Driesen wrote on Wed, Mar 31, 2010 at 02:49:48PM CEST: > >>Shouldn't the .git-version file be created inside the build directory, > >>rather than the source directory? > > > >No. I wan

Re: revision control info in generated files

2010-04-01 Thread Jef Driesen
On 31/03/10 22:45, Ralf Wildenhues wrote: * Jef Driesen wrote on Wed, Mar 31, 2010 at 02:49:48PM CEST: Sure. I use both git and subversion, and this are the commands I would use to retrieve the revision info: git rev-parse --quiet --verify HEAD svnversion The svnversion command is a little tri

Re: revision control info in generated files

2010-03-31 Thread Ralf Wildenhues
* Jef Driesen wrote on Wed, Mar 31, 2010 at 02:49:48PM CEST: > On 30/03/10 20:57, Ralf Wildenhues wrote: > >There is a point to using FORCE over .PHONY: were you to mark > >$(srcdir)/.git-version as phony, then the compilation of version.c would > >always be emitted by 'make', even if the .git-vers

Re: revision control info in generated files

2010-03-31 Thread Jef Driesen
On 30/03/10 20:57, Ralf Wildenhues wrote: * Jef Driesen wrote on Wed, Mar 17, 2010 at 01:23:09PM CET: On 16/03/2010 14:22, Peter Johansson wrote: Which method to use depends on where you want the MY_REVISION_VERSION to propagate. Do you need it in any Makefiles, e.g., or do you only need it com

revision control info in generated files (was: Public header files)

2010-03-30 Thread Ralf Wildenhues
* Jef Driesen wrote on Wed, Mar 17, 2010 at 01:23:09PM CET: > On 16/03/2010 14:22, Peter Johansson wrote: > >Which method to use depends on where you want the MY_REVISION_VERSION to > >propagate. Do you need it in any Makefiles, e.g., or do you only need it > >compiled into your program. > > I onl