> "Richard" == Richard Boulton <[EMAIL PROTECTED]> writes:
Richard>2001-06-06 Richard Boulton <[EMAIL PROTECTED]>
Richard>
Richard>* (conditionals_true_when): Pass first parameters by reference,
Richard>avoiding bug which put all parameters in @CONDS instead of @WHENS.
Richa
Richard --
I got notification today that your copyright assignment has come in.
So I hope to look at this patch pretty soon.
If I haven't replied about it in the next week or so, please feel free
to remind me.
Thanks,
Tom
On Thu, Jun 14, 2001 at 05:49:35PM -0500, Raja R Harinath wrote:
> So, I think it's cleaner to do:
>
> 1. conditions_true_when(\@@) -- takes a list of conditions and one
> or more "whens", and returns true when all conditions are true
> for all whens.
>
> 2. redundant_condition($@)
> "Richard" == Richard Boulton <[EMAIL PROTECTED]> writes:
Richard> i) variable_conditions_reduce() currently checks conditions
Richard> for redundancy against only those conditions which it has
Richard> already checked, rather than against all the conditions it
Richard> hasn't yet discarded.
Richard Boulton <[EMAIL PROTECTED]> writes:
[snip]
> (ii) is fixed by redefining the behaviour of conditionals_true_when() such
> that it returns TRUE if all the @CONDS are true for a condition in @WHENS.
> The behaviour when WHENS is empty is also altered to be more logical (this
> is where the F
On Thu, Jun 14, 2001 at 03:17:38PM -0500, Raja R Harinath wrote:
> Isn't it cleaner to use
>
> sub conditions_true_when(\@@)
> {
> my ($condsref, @whens) = @_;
>
[snip]
>
> >- if ! conditionals_true_when ((@parent_conds), ($vcond));
> >+ if ! conditionals_true_when ([@parent_
Richard Boulton <[EMAIL PROTECTED]> writes:
> On Wed, Jun 13, 2001 at 11:44:52AM +0300, Kalle Olavi Niemitalo wrote:
>> This bug is also causing the @TRUE@ conditions reported by
>> Richard Boulton in "Bug with conditionals. [PATCH]".
>
> You're right, this does seem to be the main cause of the p
On Wed, Jun 13, 2001 at 11:44:52AM +0300, Kalle Olavi Niemitalo wrote:
> This bug is also causing the @TRUE@ conditions reported by
> Richard Boulton in "Bug with conditionals. [PATCH]".
You're right, this does seem to be the main cause of the problem I
reported.
I tried fixing the problem (by p
