Re: automake/488: "make check" may seem to succeed when there are failed tests in multiple tools

2006-04-19 Thread Alexandre Duret-Lutz
>>> "RW" == Ralf Wildenhues <[EMAIL PROTECTED]> writes: [...] RW> OK to apply this patch to fix this in the spirit of Paul's suggestion, RW> and amend the dejagnu4.test to expose the failure? Yes please ! Thanks. -- Alexandre Duret-Lutz Shared books are happy books. http://www.bookcross

Re: mkdir -p -- minor cleanup

2006-04-19 Thread Alexandre Duret-Lutz
>>> "PE" == Paul Eggert <[EMAIL PROTECTED]> writes: PE> Here's a proposed Automake patch to implement this. I noticed that PE> install-sh handles neither -- nor unknown options, so I added support PE> for that as well. Thanks, please install! -- Alexandre Duret-Lutz Shared books are happy b

Re: mkdir -p -- minor cleanup

2006-04-19 Thread Paul Eggert
Stepan Kasal <[EMAIL PROTECTED]> writes: > I think it is more practical to have $(mkdir_p) set to 'mkdir -p --'. Yes, that is a possibility. > And you can often write > $(mkdir_p) $(directory_list) > without knowing exactly the names of the directories. It's natural to > forget that the d

Re: automake/490: make check XFAIL shell code may fail on Solaris due to extraneous tabs

2006-04-19 Thread Ralf Wildenhues
Hi Alexandre, * Alexandre Duret-Lutz wrote on Wed, Apr 19, 2006 at 07:11:53AM CEST: > >>> "RW" == Ralf Wildenhues <[EMAIL PROTECTED]> writes: > > RW> Suggested patch below. OK to apply? > > Go ahead! Thanks for fixing this. Applied. Thanks for the review. > RW> --- lib/am/check.am 14

Re: automake/488: "make check" may seem to succeed when there are failed tests in multiple tools

2006-04-19 Thread Ralf Wildenhues
Hi Paul, * Paul Lunau wrote on Wed, Apr 12, 2006 at 09:54:16PM CEST: > > If you use dejagnu for testing and have multiple tools (i.e. multiple > entries in the DEJATOOL variable) then the success/failure of "make > check" is only dependent on the success/failure of the tests on the > final tool.

Re: mkdir -p -- minor cleanup

2006-04-19 Thread Stepan Kasal
Hello, On Wed, Apr 19, 2006 at 01:02:30AM -0700, Paul Eggert wrote: > [...], but now that > $(mkdir_p) is intended to mean 'mkdir -p' I think it's more consistent > for the expansion to not include the '--'. I think it is more practical to have $(mkdir_p) set to 'mkdir -p --'. And you can often

mkdir -p -- minor cleanup

2006-04-19 Thread Paul Eggert
In reviewing Bruno Haible's proposed patch to move $(mkdir_p) from Automake to Autoconf I noticed an inconsistency in how $(mkdir_p) is set. Normally it is set to 'mkdir -p --', but it might be set to '$(install_sh) -d' or to '