Hi Stefano,
* Stefano Lattarini wrote on Sun, Apr 25, 2010 at 11:53:43PM CEST:
> Here I (re)propose a series of patches to improve and extend the tests
> on Automake's silent-mode.
Thanks.
> This series is an extension/improvement over my previous patch
> series "[PATCH 0/5] Modularize testing o
Hello Christina,
* Christina Gratorp wrote on Fri, Jun 04, 2010 at 08:58:53AM CEST:
> I have a suggestion that would make a difference when visiting your
> otherwise eminent website:
> http://sources.redhat.com/automake/automake.html#Introduction. The sentence
> "The developer expresses the recipe
I guess it was about time I added this.
Cheers,
Ralf
* AUTHORS: Update.
diff --git a/AUTHORS b/AUTHORS
index f1cd414..e63f8b7 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -15,3 +15,7 @@ Alexandre Oliva
Alexandre Duret-Lutz
Major overhaul of everything.
Maintenance since 2002.
+
+Ralf Wildenh
Hi Stefano,
* Stefano Lattarini wrote on Tue, Apr 27, 2010 at 02:33:14PM CEST:
> Here is another simple patch which ought to make the use of the
> `errexit' shell flag in the testsuite more consistent. This one affects
> a larger number of files, but since the changes are all similar and all
>
* Stefano Lattarini wrote on Tue, Apr 27, 2010 at 12:40:44PM CEST:
> Here is another simple patch which ought to make the use of the
> `errexit' shell flag in the testsuite more consistent.
> Enable `errexit' shell flag in all tests cxx*.test.
>
> * tests/cxx.test: Add call to `set -e'. Related
Hi Stefano,
* Stefano Lattarini wrote on Thu, May 06, 2010 at 01:45:10PM CEST:
> Enable the `errexit' shell flag in another bunch of test scripts.
>
> No relevant semantic change should be introduced by the patch, except
> for the test `discover.test', which has been made slighty stricter
> w.r
* Stefano Lattarini wrote on Sat, May 08, 2010 at 02:29:13AM CEST:
> * tests/link_c_cxx.test: Enable `errexit shell flag, and related
> changes. Also, do not create useless source files.
> * tests/link_dist.test: Likewise.
> * tests/link_f90_only.test: Likewise.
> * tests/link_f_only.test: Likewis
Hi Stefano,
* Stefano Lattarini wrote on Thu, Jun 03, 2010 at 02:07:19PM CEST:
> What about the attached new try? It just complicates the generated
> tests a little bit, but this is a more than fair tradeoff IMO.
That looks like a better idea to me. However, 'return' from a script
sourced with
This patch picks up a couple more obvious message fixes.
Committing to master.
Cheers,
Ralf
More minor message fixes.
* aclocal.in (scan_file): Fix recommended info command line.
* automake.in (handle_lib_objects): No need to prepend function
name to prog_error message.
(
* Stefano Lattarini wrote on Thu, May 06, 2010 at 01:45:10PM CEST:
> No relevant semantic change should be introduced by the patch, except
> for the test `discover.test', which has been made slighty stricter
> w.r.t. the exit status of Automake (a non-zero exit status is
> expected) and the grep
At Sunday 06 June 2010, Ralf Wildenhues
wrote:
> Hi Stefano,
>
> * Stefano Lattarini wrote on Thu, Jun 03, 2010 at 02:07:19PM CEST:
> > What about the attached new try? It just complicates the
> > generated tests a little bit, but this is a more than fair
> > tradeoff IMO.
>
> That looks like
At Sunday 06 June 2010, Ralf Wildenhues
wrote:
> Hi Stefano,
>
> > The involved test scripts and the modifications done to them are
> > simple enough that no portability problem involving the `errexit'
> > flag should have been introduced.
>
> Not quite right in this case. OpenBSD sh fails ext
At Sunday 06 June 2010, Ralf Wildenhues
wrote:
> Hi Stefano,
>
> * Stefano Lattarini wrote on Thu, Jun 03, 2010 at 02:07:19PM CEST:
> > What about the attached new try? It just complicates the
> > generated tests a little bit, but this is a more than fair
> > tradeoff IMO.
>
> That looks like
* Stefano Lattarini wrote on Sun, Jun 06, 2010 at 07:13:48PM CEST:
> At Sunday 06 June 2010, Ralf Wildenhues wrote:
> > * Stefano Lattarini wrote on Thu, Jun 03, 2010 at 02:07:19PM CEST:
> > > What about the attached new try? It just complicates the
> > > generated tests a little bit, but this is
At Sunday 06 June 2010, Ralf Wildenhues
wrote:
>
> Thanks, and sorry for not having rerun the complete testsuite
> before pushing the original patch.
Well, I should say "sorry" for not having tested the patch thoroughly.
Thanks for your quick response.
Stefano
I'm merging a handful of trivial patches increasing coverage of the
Automake perl code, to master.
Cheers,
Ralf
Coverage for aclocal diagnosing underquoted macros.
* tests/acloca23.test: New test.
* tests/Makefile.am: Update.
diff --git a/tests/Makefile.am b/tests/Makefile.am
in
Here we go again.
The last version of the patch is still wrong, at it doesn't handle
correctly the situation where $(srcdir) is different at developer's
'make dist' time and at user's 'make check' time.
A similar problem has been spotted by Ralf Wildenhues in a previous
patch of mine (that should
Damn, the last patch contained a stupid typo, probably introduced by
myself in the amending process, god knows how.
Sorry for the noise.
Stefano
From b1a3ed602e7e2b35a11ff9f480a07ad704040347 Mon Sep 17 00:00:00 2001
From: Stefano Lattarini
Date: Sun, 6 Jun 2010 18:38:27 +0200
Subject: [PATCH
* tests/ammissing.test: Fail if $ACLOCAL succeds unexpectedly.
Enable `errexit' shell flag.
-*-*-*-
No portability problems should be introduced w.r.t. the errexit shell
flag: there are no compound commands, and the only potentially
problematic construct is:
$ACLOCAL 2>stderr && { cat stderr
* Stefano Lattarini wrote on Sun, Jun 06, 2010 at 07:50:57PM CEST:
> At Sunday 06 June 2010, Ralf Wildenhues wrote:
> >
> > Thanks, and sorry for not having rerun the complete testsuite
> > before pushing the original patch.
> Well, I should say "sorry" for not having tested the patch thoroughly.
At Sunday 06 June 2010, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Sun, Jun 06, 2010 at 07:50:57PM CEST:
> > At Sunday 06 June 2010, Ralf Wildenhues wrote:
> > > Thanks, and sorry for not having rerun the complete testsuite
> > > before pushing the original patch.
> >
> > Well, I shoul
21 matches
Mail list logo
