[PATCH] Modernize, improve and/or extend tests `colon*.test.

2010-06-12 Thread Stefano Lattarini
Another patch tweaking scripts in the testsuite. Regards, Stefano -*-*-*- Modernize, improve and/or extend tests `colon*.test. * tests/colon.test: Rely on the `configure.in' stub created by `./defs', rather than writing one from scratch. Do not create a useless dummy file. * tests/colon4.t

[PATCH] New tests on obsoleted usages of automake/autoconf macros.

2010-06-12 Thread Stefano Lattarini
New tests on obsoleted usages of automake/autoconf macros (as AC_INIT, AM_INIT_AUTOMAKE and AC_OUTPUT). * tests/backcompat.test: New test script. * tests/backcompat2.test: Likewise. * tests/backcompat3.test: Likewise. * tests/backcompat4.test: Likewise. * tests/backcompat5.test: Likewise. * tests/

Re: [PATCHES] Minor cleanup and/or cosmetic patches for the testsuite.

2010-06-12 Thread Stefano Lattarini
At Saturday 12 June 2010, Stefano Lattarini wrote: > At Saturday 12 June 2010, Ralf Wildenhues wrote: > > patch 4 is not, because it will do the wrong thing with, say, > > AUTOUPDATE='autoupdate --verbose'. > > You're righ :-( > > substutite it with one adding a proper comment about why the `set

Re: [PATCHES] Minor cleanup and/or cosmetic patches for the testsuite.

2010-06-12 Thread Stefano Lattarini
At Saturday 12 June 2010, Ralf Wildenhues wrote: > Hi Stefano, > > * Stefano Lattarini wrote on Sat, Jun 12, 2010 at 07:16:02PM CEST: > > Here I present four simple patches that were originally part of > > my patch series on the refactoring of 'tests/defs'. But they are > > mostly indipendent fro

Re: [PATCHES] Minor cleanup and/or cosmetic patches for the testsuite.

2010-06-12 Thread Ralf Wildenhues
Hi Stefano, * Stefano Lattarini wrote on Sat, Jun 12, 2010 at 07:16:02PM CEST: > Here I present four simple patches that were originally part of my > patch series on the refactoring of 'tests/defs'. But they are mostly > indipendent from that series, which (by the way) is already growing > way

[PATCHES] Minor cleanup and/or cosmetic patches for the testsuite.

2010-06-12 Thread Stefano Lattarini
Here I present four simple patches that were originally part of my patch series on the refactoring of 'tests/defs'. But they are mostly indipendent from that series, which (by the way) is already growing way too long. So I though it convenient and appropriate to seperated them, and post them

Re: [PATCH] Modernize, improve and/or fix various test scripts (again)

2010-06-12 Thread Ralf Wildenhues
Hi Stefano, * Stefano Lattarini wrote on Thu, Jun 10, 2010 at 12:43:41AM CEST: > Again, this might seem huge, but most changes are trivial and/or > similar one to the others. > And having all these tweakings packed in a big lump should make their > reviewing easier IMHO (at least, it shouldn't mak

Re: [PATCH] Modernize, improve and/or fix tests `pluseq*.test.

2010-06-12 Thread Stefano Lattarini
At Saturday 12 June 2010, Ralf Wildenhues wrote: > Good for maint, with below squashed in. > > diff --git a/tests/pluseq5.test b/tests/pluseq5.test > index 405b1fa..4e03d37 100755 > --- a/tests/pluseq5.test > +++ b/tests/pluseq5.test > @@ -1,5 +1,6 @@ > #! /bin/sh > -# Copyright (C) 1999, 2001, 2

the branch a patch is for (was: [PATCH] Testsuite: ensure verbose printing of captured stderr.)

2010-06-12 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sat, Jun 12, 2010 at 01:36:01PM CEST: > At Saturday 12 June 2010, Ralf Wildenhues wrote: > > This is ok for maint, except that cscope.test does not exist on > > maint. I folded the patch below into it, committed on maint, and > > commited a separate patch for cscope.tes

Re: [PATCH] Modernize, improve and/or fix tests `pluseq*.test.

2010-06-12 Thread Ralf Wildenhues
Hi Stefano, * Stefano Lattarini wrote on Fri, Jun 11, 2010 at 05:35:58PM CEST: > Modernize, improve and/or fix tests `pluseq*.test. > > * tests/pluseq5.test: Append to configure.in using cat with an > here-doc, not using echo. > * tests/pluseq10.test: Make sure that the captured output of > `make

Re: [PATCH] Testsuite: ensure verbose printing of captured stderr.

2010-06-12 Thread Stefano Lattarini
At Saturday 12 June 2010, Ralf Wildenhues wrote: > This is ok for maint, except that cscope.test does not exist on > maint. I folded the patch below into it, committed on maint, and > commited a separate patch for cscope.test in your name to > dr-cscope, and merged that into master again. Hello Ral

Re: [PATCH] Testsuite: ensure verbose printing of captured stderr.

2010-06-12 Thread Ralf Wildenhues
Hi Stefano, * Stefano Lattarini wrote on Fri, Jun 11, 2010 at 09:22:40PM CEST: > * tests/acloca18.test: Print captured stderr before either failing > or grepping it. Be sure to send captured stderr to stderr, not to > stdout. > * tests/ansi3b.test: Likewise. > * tests/cond39.test: Likewise. > * t

Re: [PATCH] Enable `errexit' shell flag in various tests (again).

2010-06-12 Thread Stefano Lattarini
At Saturday 12 June 2010, Ralf Wildenhues wrote: > This patch is good for maint, thanks. > > > -cat > configure.in << 'END' > > -AC_INIT > > -AM_INIT_AUTOMAKE(nonesuch, nonesuch) > > +set -e > > + > > +cat > configure.in < > +AC_INIT([$me], [1.0]) > > +AM_INIT_AUTOMAKE > > Just be sure that we ke

Re: [PATCH] Enable `errexit' shell flag in various tests (again).

2010-06-12 Thread Ralf Wildenhues
Hi Stefano, * Stefano Lattarini wrote on Fri, Jun 11, 2010 at 05:30:57PM CEST: > Enable `errexit' shell flag in various tests. > > * tests/backsl.test: Enable the `errexit' shell flag, and > related changes. > * tests/backsl2.test: Likewise. > * tests/block.test: Likewise. > * tests/canon2.test:

Re: [PATCH] Extend tests/README (trailing `:' in test scripts)

2010-06-12 Thread Stefano Lattarini
At Saturday 12 June 2010, Ralf Wildenhues wrote: > Hi Stefano, > > * Stefano Lattarini wrote on Fri, Jun 11, 2010 at 12:42:24PM CEST: > > OK to apply this patch to tests/README? I think the original one > > has fallen off your radar (in fact I posted it in quite an > > inappropriate place, see be

pushing patches (was: [PATCH] Extend tests/README (trailing `:' in test scripts))

2010-06-12 Thread Ralf Wildenhues
Hi Stefano, * Stefano Lattarini wrote on Fri, Jun 11, 2010 at 12:42:24PM CEST: > OK to apply this patch to tests/README? [...] Speaking of "OK to apply", would you prefer pushing approved patches yourself? If yes, please apply as project member on

Re: [PATCH] Extend tests/README (trailing `:' in test scripts)

2010-06-12 Thread Ralf Wildenhues
Hi Stefano, * Stefano Lattarini wrote on Fri, Jun 11, 2010 at 12:42:24PM CEST: > OK to apply this patch to tests/README? I think the original one has > fallen off your radar (in fact I posted it in quite an inappropriate > place, see below). It has indeed fallen off my radar, unlike some others.