* Stefano Lattarini wrote on Thu, Jul 22, 2010 at 01:04:03AM CEST:
> At Wednesday 21 July 2010, Ralf Wildenhues wrote:
> > Well, this is a common dilemma in testing: should the tester be
> > allowed to use insider information or not? [...]
> > Getting the right balance here is the most non-automa
* Stefano Lattarini wrote on Wed, Jul 21, 2010 at 11:48:24PM CEST:
> I'll still wait to push, since I'd like to have some more committs in
> maint before merging it in master. Agreed?
OK.
Ralf
* Stefano Lattarini wrote on Wed, Jul 21, 2010 at 11:28:17PM CEST:
> Attached are the amended patch (against maint) and the temporary patch
> I squashed in the old one (which FYI was against master).
> OK to apply?
OK for maint, with nits addressed.
Thanks,
Ralf
> --- a/tests/subdir5.test
> +++
At Wednesday 21 July 2010, Ralf Wildenhues wrote:
> > > Your changes seem to have valued efficiency so far. But
> > > calling perl is bound to be more expensive than a couple of
> > > greps.
> >
> > Yes, but it's blazingly fast if compared with an aclocal/automake
> > call.
>
> Sure, but you're
At Wednesday 21 July 2010, Ralf Wildenhues wrote:
> OK for maint if it rebases and tests without trouble.
Done (there was just a minor, spurious conflict with `git am', easily
solved).
I'll still wait to push, since I'd like to have some more committs in
maint before merging it in master. Agree
At Wednesday 21 July 2010, Ralf Wildenhues wrote:
> Hi Stefano,
>
> This is ok for maint with nits below addressed.
>
> > diff --git a/tests/subdir5.test b/tests/subdir5.test
> > index 2f0113b..0709440 100755
> > --- a/tests/subdir5.test
> > +++ b/tests/subdir5.test
> >
> > @@ -27,14 +27,15 @@ re
* Stefano Lattarini wrote on Wed, Jul 21, 2010 at 09:47:43PM CEST:
> At Wednesday 21 July 2010, Ralf Wildenhues wrote:
> > * Stefano Lattarini wrote on Sat, Jun 19, 2010 at 09:34:34PM CEST:
> > > Yet another testsuite-tweaking patch.
> >
> > OK for maint with nits below addressed.
> >
> > > Moder
At Wednesday 21 July 2010, Ralf Wildenhues wrote:
> Hi Stefano,
>
> * Stefano Lattarini wrote on Sat, Jun 19, 2010 at 09:34:34PM CEST:
> > Yet another testsuite-tweaking patch.
>
> OK for maint with nits below addressed.
>
> > Modernize and improve test scripts `dist*.test'.
> >
> > * tests/di
Hi Stefano,
* Stefano Lattarini wrote on Fri, Jun 18, 2010 at 01:25:20PM CEST:
> At Thursday 17 June 2010, Ralf Wildenhues wrote:
> > Thanks, most of this is uncontroversial, but a couple of things I
> > don't understand:
> > > --- a/tests/colon3.test
> > > +++ b/tests/colon3.test
> > > [CUT]
> >
At Wednesday 21 July 2010, Ralf Wildenhues wrote:
> Hi Stefano,
>
> * Stefano Lattarini wrote on Mon, Jul 19, 2010 at 10:41:13PM CEST:
> > And here is a follow-up patch to reduce possible race conditions
> > w.r.t. reuse of process PIDs. The patch is against the maint
> > branch.
>
> I'm sorry b
Hi Stefano,
* Stefano Lattarini wrote on Sat, Jun 19, 2010 at 10:15:58PM CEST:
> Modernize and improve test scripts `subdir*.test'.
>
> * tests/subdir.test: Enable `errexit' shell flag, and related
> changes. Use the `configure.in' stub created by `./defs',
> rather than writing one from scratch
Hi Stefano,
* Stefano Lattarini wrote on Sat, Jun 19, 2010 at 09:34:34PM CEST:
> Yet another testsuite-tweaking patch.
OK for maint with nits below addressed.
> Modernize and improve test scripts `dist*.test'.
>
> * tests/distcleancheck.test: Do not add useless `-e' option to
> a $MAKE call. E
Hi Stefano,
* Stefano Lattarini wrote on Mon, Jul 19, 2010 at 10:41:13PM CEST:
> And here is a follow-up patch to reduce possible race conditions
> w.r.t. reuse of process PIDs. The patch is against the maint branch.
I'm sorry but I have issues here, see below.
> Subject: [PATCH] Remove a race
13 matches
Mail list logo
