On Monday 06 June 2011, Stefano Lattarini wrote:
> With the previous commit, the user could prefer the use of $SHELL
> over /bin/sh in some tests checking the Automake-provided shell
> scripts by manually exporting `test_prefer_config_shell' to "yes"
> in the environment. With this commit, we ensu
On Tuesday 07 June 2011, Stefano Lattarini wrote:
> On Tuesday 07 June 2011, Peter Rosin wrote:
> > >> This test no longer checks if $AUTOMAKE -a copies over compile, as
> > >> that is done manually now. I assume this aspect of $AUTOMAKE -a is
> > >> tested elsewhere. Or is it?
> > >>
> > > Yes, in
On Tuesday 07 June 2011, Peter Rosin wrote:
> Nothing more to say on 1/3.
>
> Den 2011-06-07 12:29 skrev Stefano Lattarini:
> >>> index cf8d6cb..c7e8a0e 100755
> >>> --- a/tests/compile4.test
> >>> +++ b/tests/compile4.test
> >>> @@ -20,6 +20,8 @@
> >>> required='cl'
> >>> . ./defs || Exit 1
> >
Nothing more to say on 1/3.
Den 2011-06-07 12:29 skrev Stefano Lattarini:
> On Tuesday 07 June 2011, Peter Rosin wrote:
>> Den 2011-06-06 21:48 skrev Stefano Lattarini:
>>> * tests/ar-lib.test: If the variable `$test_prefer_config_shell'
>>> is set to "yes", run the script under test with configur
On Tuesday 07 June 2011, Peter Rosin wrote:
> Den 2011-06-06 21:49 skrev Stefano Lattarini:
> > With the previous commit, the user could prefer the use of $SHELL
> > over /bin/sh in some tests checking the Automake-provided shell
> > scripts by manually exporting `test_prefer_config_shell' to "yes"
On Tuesday 07 June 2011, Peter Rosin wrote:
> Den 2011-06-06 21:48 skrev Stefano Lattarini:
> > * tests/ar-lib.test: If the variable `$test_prefer_config_shell'
> > is set to "yes", run the script under test with configure-time
> > determined $SHELL, rather than with /bin/sh.
> > The `$test_prefer_
Hi Peter, thanks for the review.
On Tuesday 07 June 2011, Peter Rosin wrote:
>
> [SNIP]
>
> > diff --git a/tests/defs b/tests/defs
> > index ea036f8..37b5baa 100644
> > --- a/tests/defs
> > +++ b/tests/defs
> > @@ -283,6 +283,22 @@ unindent ()
> > }
> > sed_unindent_prog="" # Avoid interferences
Den 2011-06-06 21:49 skrev Stefano Lattarini:
> With the previous commit, the user could prefer the use of $SHELL
> over /bin/sh in some tests checking the Automake-provided shell
> scripts by manually exporting `test_prefer_config_shell' to "yes"
> in the environment. With this commit, we ensure
Den 2011-06-06 21:48 skrev Stefano Lattarini:
> * tests/ar-lib.test: If the variable `$test_prefer_config_shell'
> is set to "yes", run the script under test with configure-time
> determined $SHELL, rather than with /bin/sh.
> The `$test_prefer_config_shell' variable defaults to empty, but
> can be
Den 2011-06-06 21:48 skrev Stefano Lattarini:
> This change avoids potential spurious failures with tests using
> the requirement 'xsi-shell' to mean that they want */bin/sh* (not
> $SHELL) to be XSI-conforming. This idiom used to work before
> commit `v1.11-874-g1321be7' (as back then the test sc
Den 2011-06-06 11:06 skrev Stefano Lattarini:
>> [SNIP]
Ditto
and the reason is a dubious argument to increase testsuite coverage,
see more below.
We both think the testsuite should execute the script as they are executed
when they are used. And I think that it should onl
Den 2011-06-05 14:56 skrev Stefano Lattarini:
> On Sunday 05 June 2011, Peter Rosin wrote:
>> Den 2011-06-04 11:24 skrev Stefano Lattarini:
>>> Yes, and you're absolutely right complaining about the LIB= -> LIB=''
>>> useless change, and the cat -> unindent "unreported" change; for them
>>> I can o
12 matches
Mail list logo
