* THANKS: Fix whitespace issue.

Hi! I'm pushing this to maint. Cheers, Peter diff --git a/ChangeLog b/ChangeLog index a022b09..8634573 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +2011-10-21 Peter Rosin + + * THANKS: Fix whitespace issue. + 2011-10-18 Stefano Lattarini tests: fix spurious fail

Re: [PATCH 1/2] ar-lib: new 'AM_PROG_AR' macro, triggering the 'ar-lib' script

Ouch. Found a typo, good thing I ran the testsuite one more time... *snip* > diff --git a/tests/ar-lib7.test b/tests/ar-lib7.test > new file mode 100755 > index 000..d2ef433 > --- /dev/null > +++ b/tests/ar-lib7.test *snip* > + > +$ACLOCAL > +AUTOMAKE_fails > + > +grep '^configure\.in:*.ar

Re: testsuite on master

Stefano Lattarini wrote: > On Thursday 20 October 2011, Jim Meyering wrote: >> Stefano Lattarini wrote: >> >> > Feel free to push the patch to master. >> >> Done. >> > Thank you. > >> I saw 5 other "make check" failures on master this morning. >> I suppose it's not worth investigating them, given h

[FYI] {testsuite-work} fixup: add forgotten test scripts to $(TESTS)

* tests/list-of-tests.mk: Add various test scripts that are in the git repository but weren't correctly listed in $(TESTS). The inconsistency had been caused by botched/incomplete merges, and revealed by the "maintainer-check-list-of-tests" target. --- ChangeLog |8 tests

[FYI] merged maint in master and master in testsuite-work

Merge branch 'maint' * maint: tests: fix spurious failures with "chatty" make implementations tests: fix spurious failure on fast machines tests: avoid spurious failure of 'uninstall-fail.test' on Solaris tests: avoid spurious failure in 'parallel-tests3.test' tests: fix spurious fai

testsuite on master (was: Re: [PATCH] tests: fix aclocal-print-acdir.test)

On Thursday 20 October 2011, Jim Meyering wrote: > Stefano Lattarini wrote: > > > Feel free to push the patch to master. > > Done. > Thank you. > I saw 5 other "make check" failures on master this morning. > I suppose it's not worth investigating them, given how much > is happening in testsuite-

[FYI] maint merged in branch-1.11 and yacc-work, yacc-work merged in ylwrap-refactor

I've merged the latest maint (v1.11-511-gd2b9096) into branch-1.11 and yacc-work, and pushed. I've also merged yacc-work into ylwrap-refactor, and pushed. I'll wait for the pending patches from Jim and Peter to be pushed, before merging maint into (respectively) master and msvc. Regards, Stefa

Re: [PATCH] tests: fix aclocal-print-acdir.test

Stefano Lattarini wrote: > On Thursday 20 October 2011, Jim Meyering wrote: >> Without the patch below, I would consistently see this failure: >> >> FAIL: aclocal-print-acdir.test (exit: 1) >> >> + set -e >> ... >> ++ aclocal-1.11a -Werr

Re: [PATCH] tests: fix aclocal-print-acdir.test

On Thursday 20 October 2011, Jim Meyering wrote: > Without the patch below, I would consistently see this failure: > > FAIL: aclocal-print-acdir.test (exit: 1) > > + set -e > ... > ++ aclocal-1.11a -Werror --print-ac-dir > + test /h/

[PATCH] {maint} deps: partially revert commit `v1.11-512-geeee551'

This change partly reverts commit "Create subdirs for generated sources even when not dep tracking", of 2011-04-02. That commit had caused the bugs #8485 and #8526. Since we are nearing the bug-fixing automake release 1.11.2, the safest policy at the moment is to just revert the problematic hunks

Re: bug#8788: Weird testsuite failure on NetBSD (parallel tests, background processes)

On Tuesday 18 October 2011, Stefano Lattarini wrote: > On Tuesday 18 October 2011, Stefano Lattarini wrote: > > Reference: > > > > > > [SNIP] > > > > Now, the right fix for the bug is *not* to work around this behaviour > > of the Korn shell; rat

Re: [PATCH] {maint} tests: fix spurious failure with FreeBSD make and Yacc in VPATH

On Tuesday 18 October 2011, Stefano Lattarini wrote: > This patch removes a spurious failure experienced with FreeBSD make. > > The failure is in fact due to the real bug ; > but that bug is not a regression, and is already exposed by the test > `yacc-dist-nobuild.test

[FYI] {maint} tests: fix spurious failures with "chatty" make implementations

* tests/distcheck-missing-m4.test: On failure, some make implementations (such as Solaris make) print the whole failed recipe on standard output. This was causing a spurious failure in the checks grepping the output from make. Work around this. * tests/distcheck-outdated-m4.test: Likewise. --- C

Re: [PATCH 2/2] warnings: new 'extra-portability' category, for AM_PROG_AR

On Thursday 20 October 2011, Peter Rosin wrote: > > Anyone want to to see the final spin? > Not me. I say you should wait a couple of days to give Ralf a chance to chime in, then push the series to msvc. Thanks for your work on this, Stefano

Re: [PATCH 1/2] ar-lib: new 'AM_PROG_AR' macro, triggering the 'ar-lib' script

On Thursday 20 October 2011, Peter Rosin wrote: > Good to go with that? Anyone want to see the final spin? > OK from me. Maybe wait a day or two to allow Ralf to chime in? Thanks, Stefano

Re: [PATCH 2/2] warnings: new 'extra-portability' category, for AM_PROG_AR

Stefano Lattarini skrev 2011-10-20 20:15: > On Thursday 20 October 2011, Peter Rosin wrote: >> Stefano Lattarini skrev 2011-10-20 17:11: >> >>> Micro-nit: this would be clearer IMHO: >>> >>> # Interactions between `portability' and `extra-portability' >>> # warning categories: >>> # 1. `-We

Re: [PATCH 1/2] ar-lib: new 'AM_PROG_AR' macro, triggering the 'ar-lib' script

Stefano Lattarini skrev 2011-10-20 19:37: > On Thursday 20 October 2011, Peter Rosin wrote: diff --git a/tests/ar-lib6.test b/tests/ar-lib6.test new file mode 100755 index 000..af3cb2e --- /dev/null +++ b/tests/ar-lib6.test @@ -0,0 +1,38 @@ +#! /bin/sh +#

Re: [PATCH 2/2] warnings: new 'extra-portability' category, for AM_PROG_AR

On Thursday 20 October 2011, Peter Rosin wrote: > Stefano Lattarini skrev 2011-10-20 17:11: > > > Micro-nit: this would be clearer IMHO: > > > > # Interactions between `portability' and `extra-portability' > > # warning categories: > > # 1. `-Wextra-portability' must imply `-Wportability'.

Re: [PATCH 1/2] ar-lib: new 'AM_PROG_AR' macro, triggering the 'ar-lib' script

On Thursday 20 October 2011, Peter Rosin wrote: > >> diff --git a/tests/ar-lib6.test b/tests/ar-lib6.test > >> new file mode 100755 > >> index 000..af3cb2e > >> --- /dev/null > >> +++ b/tests/ar-lib6.test > >> @@ -0,0 +1,38 @@ > >> +#! /bin/sh > >> +# Copyright (C) 2011 Free Software Foundation

Re: [PATCH 2/2] warnings: new 'extra-portability' category, for AM_PROG_AR

Stefano Lattarini skrev 2011-10-20 17:11: > Hi Peter. See my nits and comments inlined ... > >> diff --git a/doc/automake.texi b/doc/automake.texi >> index c789e74..eea11d1 100644 >> --- a/doc/automake.texi >> +++ b/doc/automake.texi >> @@ -2680,6 +2680,9 @@ user redefinitions of Automake rules o

Re: [PATCH 1/2] ar-lib: new 'AM_PROG_AR' macro, triggering the 'ar-lib' script

Stefano Lattarini skrev 2011-10-20 16:48: > Hi Peter. > > I will only comment the parts that still have unresolved issues ... > >> diff --git a/tests/ar-lib3.test b/tests/ar-lib3.test >> new file mode 100755 >> index 000..be0d6df >> --- /dev/null >> +++ b/tests/ar-lib3.test >> @@ -0,0 +1,45 @

[PATCH] tests: fix aclocal-print-acdir.test

Without the patch below, I would consistently see this failure: FAIL: aclocal-print-acdir.test (exit: 1) + set -e ... ++ aclocal-1.11a -Werror --print-ac-dir + test /h/j/w/co/automake/m4/acdir = /h/j/w/co/automake/m4 + exit_statu

[FYI] {maint} tests: fix spurious failure on fast machines

* tests/aclocal-path-precedence.test: Also remove the `configure' script between different test runs, to ensure it is always remade by autoconf. Add proper explicative comments. --- ChangeLog |7 +++ tests/aclocal-path-install-serial.test |4 +++- 2 files

[FYI] {maint} tests: avoid spurious failure of 'uninstall-fail.test' on Solaris

* tests/uninstall-fail.test: All the Solaris 10 shells (/bin/sh, /bin/ksh, and /usr/xpg4/bin/sh), upon failing to chdir to a directory with the `cd' builtin, print a message like: "sh: /root: permission denied" which doesn't report the `cd' builtin anywhere. Relax the grepping of the error messa

Re: [PATCH 2/2] warnings: new 'extra-portability' category, for AM_PROG_AR

Hi Peter. See my nits and comments inlined ... > diff --git a/doc/automake.texi b/doc/automake.texi > index c789e74..eea11d1 100644 > --- a/doc/automake.texi > +++ b/doc/automake.texi > @@ -2680,6 +2680,9 @@ user redefinitions of Automake rules or variables > @item portability > portability iss

Re: [PATCH 1/2] ar-lib: new 'AM_PROG_AR' macro, triggering the 'ar-lib' script

Hi Peter. I will only comment the parts that still have unresolved issues ... > diff --git a/tests/ar-lib3.test b/tests/ar-lib3.test > new file mode 100755 > index 000..be0d6df > --- /dev/null > +++ b/tests/ar-lib3.test > @@ -0,0 +1,45 @@ > +#! /bin/sh > +# Copyright (C) 2011 Free Software Fo

Re: [PATCH 1/2] Add new 'AM_PROG_AR' macro, triggering the 'ar-lib' script.

On Thursday 20 October 2011, Peter Rosin wrote: > Hi Stefano, > > Thanks for the review! > > Stefano Lattarini skrev 2011-10-20 11:01: > > Micro-nit: we've started to write all the git commit summaries according > > to the format ": " > > I used ar-lib as the topic, since this is about triggering

[PATCH 2/2] warnings: new 'extra-portability' category, for AM_PROG_AR

>From edda3ec3caf5c63bb30520002adcfb9b99914893 Mon Sep 17 00:00:00 2001 From: Peter Rosin Date: Thu, 20 Oct 2011 16:15:43 +0200 Subject: [PATCH 2/2] warnings: new 'extra-portability' category, for AM_PROG_AR * lib/Automake/ChannelDefs.pm: Register new extra-portability warning channel. (switch_wa

Re: [PATCH 2/2] Invent new extra-portability warning category for AM_PROG_AR.

Hi Stefano, Thanks for the review! Stefano Lattarini skrev 2011-10-20 11:02: > Hi Peter, thanks for the patch. > > On Wednesday 19 October 2011, Peter Rosin wrote: >> From 1b554ab39084ecaf767fbea031763c211bc72e4e Mon Sep 17 00:00:00 2001 >> From: Peter Rosin >> Date: Wed, 19 Oct 2011 23:18:49 +

Re: [PATCH 1/2] Add new 'AM_PROG_AR' macro, triggering the 'ar-lib' script.

Hi Stefano, Thanks for the review! Stefano Lattarini skrev 2011-10-20 11:01: > Hi Peter, thanks for not giving up on this. > > On Wednesday 19 October 2011, Peter Rosin wrote: >> From 68bdc56f54aeb497200598ccab1f5e9f9616c556 Mon Sep 17 00:00:00 2001 >> From: Peter Rosin >> Date: Wed, 19 Oct 20

Re: [RFC] Merging `testsuite-work' and `test-protocols' branches

On Monday 17 October 2011, Stefano Lattarini wrote: > Keeping the `testsuite-work' and `test-protocols' branches separate is > becoming more and more confusing and unwiedly, and since the final aim > is to merge them both into master (someday before the 1.12 release), I > think it would be acceptab

Re: [FYI 9/8] {dist-refactor} cosmetics: remove obsolete comment

On Monday 17 October 2011, Stefano Lattarini wrote: > On Sunday 09 October 2011, Stefano Lattarini wrote: > > This patch series is meant to fix Automake bugs 9546 and 9651. > > > > Stefano Lattarini (8): > > dist: auxiliary files can be distributed from subdir Makefiles > > dist: simplify auto

[FYI] maint merged into master

Merge branch 'maint' * maint: tests: avoid spurious failure of 'uninstall-fail.test' on Cygwin tests: fix spurious failure with autoconf 2.62 docs: avoid using colon character inside arguments of @pxref

Re: [PATCH] {master} refactor: improve signature of 'check_directory' sub in automake

On Monday 17 October 2011, Stefano Lattarini wrote: > A very small refactoring that removes a tiny bit of gratuitous usage of > global status in the automake script. After this change, no regression > showed up in the testsuite. I will push in 72 hours if there is no > objection or review by then

Re: bug#9768: Makefile broken after removing included *.am file

On Wednesday 19 October 2011, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Mon, Oct 17, 2011 at 10:20:05AM CEST: > > On Sunday 16 October 2011, Ralf Wildenhues wrote: > > > What happens if I write > > > include fragment-with-typo-in-name.am > > > > > > but I want that fragment included?

Re: [PATCH 1/2] Add new 'AM_PROG_AR' macro, triggering the 'ar-lib' script.

Hi Peter, thanks for not giving up on this. On Wednesday 19 October 2011, Peter Rosin wrote: > From 68bdc56f54aeb497200598ccab1f5e9f9616c556 Mon Sep 17 00:00:00 2001 > From: Peter Rosin > Date: Wed, 19 Oct 2011 19:33:58 +0200 > Subject: [PATCH 1/2] Add new 'AM_PROG_AR' macro, triggering the 'ar-l

Re: [PATCH 2/2] Invent new extra-portability warning category for AM_PROG_AR.

Hi Peter, thanks for the patch. On Wednesday 19 October 2011, Peter Rosin wrote: > From 1b554ab39084ecaf767fbea031763c211bc72e4e Mon Sep 17 00:00:00 2001 > From: Peter Rosin > Date: Wed, 19 Oct 2011 23:18:49 +0200 > Subject: [PATCH 2/2] Invent new extra-portability warning category for > AM_PROG