Le 31 déc. 2013 à 00:11, Stefano Lattarini stefano.lattar...@gmail.com a
écrit :
Hi Akim.
Hi!
Thanks for the quick answer.
At first sight it seems that it should be guarded by ‘test -n $$redo_log’.
Indeed.
This is *really* costly, I’d be happy to have nice workarounds.
Or eve
Hi Stefano!
Le 30 oct. 2013 à 23:02, Stefano Lattarini stefano.lattar...@gmail.com a
écrit :
I've fixed the issue with the two attached patches, that will appear
in Automake 1.14.1 (someday when I'll actually get around to release
it ;-). I will wait some time before pushing the patches
The first patch enhances a test to exhibit a failure that the second
addresses.
Akim Demaille (2):
tests: strengthen the ylwrap tests
ylwrap: various fixes
NEWS | 18 ++
lib/ylwrap| 27 ++-
t/yacc-d-basic.sh | 51
* lib/ylwrap (guard): Properly honor $1.
Keep a single _ instead of several.
(RENAME_sed): new.
Use it.
---
NEWS | 18 ++
lib/ylwrap | 27 ++-
2 files changed, 36 insertions(+), 9 deletions(-)
diff --git a/NEWS b/NEWS
index 7a230ef..482216c 100644
* t/yacc-d-basic.sh: Comment changes.
(generated): New.
Use it to factor various tests.
Check that Y_TAB_H is not issued.
---
t/yacc-d-basic.sh | 51 +--
1 file changed, 25 insertions(+), 26 deletions(-)
diff --git a/t/yacc-d-basic.sh
Le 21 déc. 2012 à 17:44, Stefano Lattarini stefano.lattar...@gmail.com a
écrit :
Hi Akim.
Hi!
On 12/19/2012 02:55 PM, Akim Demaille wrote:
* lib/ylwrap (guard): Properly honor $1.
I fear this is the ChangLog style that I dislike: just reporting the
what of the change, without the why
Le 21 déc. 2012 à 18:43, Stefano Lattarini stefano.lattar...@gmail.com a
écrit :
On 12/21/2012 06:31 PM, Akim Demaille wrote:
Since you have a very good
explanation of such a why (as seen in the NEWS file), would you
mind reporting it (at least in an abridged form) in the commit message
Le 13 juil. 2012 à 19:31, Stefano Lattarini a écrit :
On 07/13/2012 04:20 PM, Akim Demaille wrote:
Sorry about these. Updated below, and in the branch too.
Thanks. I'm still seeing the test case 'yacc-bison-skeleton.sh' failing
on the Debian 64 bit system gcc10.fsffrance.org. Below
Le 14 juil. 2012 à 09:13, Akim Demaille a écrit :
The failure is due to the input:
%{
int yylex () { return 0; }
void yyerror (const char *s) { return; }
%}
%%
foobar : 'f' 'o' 'o' 'b' 'a' 'r' {};
%{%} goes into the header when there is one, and it also goes
in the implementation
Well, while at it, I looked at the other failure, for C++, and
fixed them.
It is installed in yacc-work.
Akim Demaille (4):
tests: upgrade and fix Bison test case
ylwrap: refactoring: don't rely on the file order
ylwrap: refactor: move loop invariant
ylwrap: fix C++ support
lib/ylwrap
* t/yacc-bison-skeleton-cxx.sh: Request locations, to be
even more stressful.
Use %union to make sure the %{...%} is inserted where appropriate.
Fix some indentation/coding style issues.
---
t/yacc-bison-skeleton-cxx.sh | 20
1 file changed, 12 insertions(+), 8 deletions(-)
Forthcoming changes will make us iterate over the files in a different
order.
lib/ylwrap (first): Remove, replaced by...
(parser): this.
---
lib/ylwrap | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/lib/ylwrap b/lib/ylwrap
index 725b388..4ad820d 100755
---
* lib/ylwrap (input_rx): Move its definition next to its sibling's,
outside of the main loop.
---
lib/ylwrap | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/lib/ylwrap b/lib/ylwrap
index 4ad820d..3efa632 100755
--- a/lib/ylwrap
+++ b/lib/ylwrap
@@ -108,6 +108,7 @@ case
Le 14 juil. 2012 à 10:49, Stefano Lattarini a écrit :
Hi Akim.
ACK, with one question ...
cat foo.cc 'END'
#include zardoz.hh
-using namespace std;
-
Why this change?
Well, the question is rather: why this line? It's useless,
like a useless #include.
Le 14 juil. 2012 à 12:33, Stefano Lattarini a écrit :
I've also rebased 'yacc-work' on maint (rather than on master), and
pushed the follow-up below to avoid a spurious failure.
I will do some testing on BSD and Solaris, and if there are no further
issues, the merge the series in maint.
Le 14 juil. 2012 à 11:09, Stefano Lattarini a écrit :
On 07/14/2012 10:52 AM, Stefano Lattarini wrote:
On 07/14/2012 10:32 AM, Akim Demaille wrote:
Well, while at it, I looked at the other failure, for C++, and
fixed them.
It is installed in yacc-work.
Akim Demaille (4):
tests
Le 12 juil. 2012 à 17:51, Stefano Lattarini a écrit :
On 07/12/2012 03:51 PM, Akim Demaille wrote:
* lib/ylwrap (pairwise): Instead of being a straightforward copy from
the command line arguments, and having to deal with y.tab vs. y_tab
later, let pairwise store the real file names
Le 12 juil. 2012 à 18:22, Stefano Lattarini a écrit :
On 07/12/2012 03:51 PM, Akim Demaille wrote:
* lib/am/yacc.am (am__yacc_c2h): Shorten.
See below.
@@ -37,8 +37,7 @@ if %?MAINTAINER-MODE%
@MAINTAINER_MODE_FALSE@am__skipyacc = test -f $@ ||
endif %?MAINTAINER-MODE%
## The 's/c$/h
Le 12 juil. 2012 à 17:38, Stefano Lattarini a écrit :
Hi Akim.
On 07/12/2012 03:51 PM, Akim Demaille wrote:
The following patches address a bug in ylwrap that cause it
to be unable to handle Bison glr parsers, but also prevents
future Bison releases from also using header inclusion
Le 13 juil. 2012 à 13:43, Stefano Lattarini a écrit :
See? Another thing I had got wrong, given my ignorance and the lack
of a proper explanation ;-)
I also meant that the bug is obvious :) If you rename files, you
have to rename files that use them, and that this is in the context
of Bison
, and in the branch too.
From ee7e1dd77b5bcd6a41a31030a4f662bca3ad2b39 Mon Sep 17 00:00:00 2001
From: Akim Demaille a...@lrde.epita.fr
Date: Fri, 13 Jul 2012 14:32:22 +0200
Subject: [PATCH] ylwrap: rename header inclusion in generated parsers
Some types of Bison parsers, such as the GLR ones, generate a header
* lib/ylwrap (pairwise): Instead of being a straightforward copy from
the command line arguments, and having to deal with y.tab vs. y_tab
later, let pairwise store the real file names to process, y_tab
conversion included when needed.
(main loop): Use $to instead of $2, for symmetry with $from.
/Makefile.in
# doc/Makefile.in
# lib/Automake/Makefile.in
# lib/Makefile.in
# lib/am/Makefile.in
# m4/Makefile.in
Akim Demaille (3):
ylwrap: refactor
ylwrap: simplify the list of renamings
ylwrap: rename header inclusion in generated parsers
lib/am/yacc.am| 3
* lib/ylwrap (guard): New function.
Move functions before actual code.
---
lib/ylwrap | 48
1 file changed, 28 insertions(+), 20 deletions(-)
diff --git a/lib/ylwrap b/lib/ylwrap
index 6879d8d..fd29af8 100755
--- a/lib/ylwrap
+++ b/lib/ylwrap
@@
Hi all,
Le 25 juin 2012 à 11:30, Stefano Lattarini a écrit :
Well, I guess I must step back. I installed what follows
in maint.
Sigh, advancement on Bison kept back by the fact that Automake used to
bend over backwards to support inferior yacc implementation that today
hardly anybody is
Hi Stefano,
Thanks for this!
Le 25 juin 2012 à 16:01, Stefano Lattarini a écrit :
When used with good yacc and lex implementations, like Flex and GNU Bison,
the 'ylwarp'
ylwrap
script (meant to work around the deficiencies of older or
inferior yacc and lex implementations) creates far
Le 26 juin 2012 à 17:35, Stefano Lattarini a écrit :
This is probably a better idea, yes. This could probably be done by
enhancing AM_PROG_LEX and defining a similar new AM_PROG_YACC macro.
Or better again, it could be done directly in AC_PROG_LEX and
AC_PROG_YACC, so that we could just
Le 31 mars 09 à 01:01, Ralf Wildenhues a écrit :
Salut Ralf !
* Akim Demaille wrote on Mon, Mar 30, 2009 at 09:50:59PM CEST:
Le 29 mars 09 à 00:04, Ralf Wildenhues a écrit :
I often use
STRICT_TEST_LOGS = $(shell $(LIST_FAILED_TEST_LOGS))
which makes all failing test strict
Le 24 mars 09 à 22:57, Ralf Wildenhues a écrit :
Hi Akim,
Hi Ralf!
* Akim Demaille wrote on Sat, Mar 14, 2009 at 01:52:33PM CET:
Le 14 mars 09 à 12:08, Ralf Wildenhues a écrit :
Corollary: the test driver may not be called CXXCOMPILE. General:
For extension `.ext', we cannot use
Le 28 mars 09 à 22:17, Ralf Wildenhues a écrit :
diff --git a/doc/automake.texi b/doc/automake.texi
index d3b72a5..bf41acb 100644
--- a/doc/automake.texi
+++ b/doc/automake.texi
@@ -8504,6 +8508,17 @@ the inference rules generated by
@command{automake} can apply. For
literal test names,
Le 29 mars 09 à 00:04, Ralf Wildenhues a écrit :
Hi Akim,
Hi Ralf!
Agreed. While I won't change the TESTS=foo.test semantics, we can
publish that the user can use TEST_LOGS=foo.log to limit the tests
to be
run.
Never thought about that :) Thanks.
- LAZY_TEST_SUITE is not flexible
Le 30 mars 09 à 21:37, Ralf Wildenhues a écrit :
But what is a non-extension rule? You mean if the rule is
foo: ...
?
I mean with
TESTS = foo bar.test baz.chk
TEST_EXTENSIONS = .chk
then foo.log and bar.test.log (sic!) will be generated using explicit
rules, while baz.log will
RW == Ralf Wildenhues ralf.wildenh...@gmx.de writes:
But the question remains: how do you think we should address the bug
that bothers Akim, other than by this patch and a big warning in NEWS?
My focus was more about an empty $(foodir), not an empty $(foo_DATA).
I was suggesting that it
RW == Ralf Wildenhues ralf.wildenh...@gmx.de writes:
Your rule can be simplified a lot: :-)
# Check that XFAIL tests do exist.
check-test-list-XFAIL: $(XFAIL_TESTS)
check-test-list-TFAIL: $(TFAIL_TESTS)
.PHONY: check-test-list-XFAIL check-test-list-TFAIL
Of course that will also
Le 14 mars 09 à 11:56, Ralf Wildenhues a écrit :
D'oh. Wonder how often we will keep encountering this.
Hi Ralf,
I have not understood what's going on here. Are these files running
concurrently in the same pwd?
Cheers,
Ralf
Use append mode to capture parallel test output.
*
Le 14 mars 09 à 12:01, Ralf Wildenhues a écrit :
Oh, what a joyful patch; cost me most brains. Here's why:
It would have been cool if
make check LAZY_TEST_SUITE=yes
on an up to date test directory would have no work to do at all.
Well. Couple of things wrong with the prior semantics:
-
Le 14 mars 09 à 12:08, Ralf Wildenhues a écrit :
Corollary: the test driver may not be called CXXCOMPILE. General:
For extension `.ext', we cannot use `EXTCOMPILE' as driver.
ext_COMPILE or
extCOMPILE
seem awkward to me too, as these do not allow for generalization
either, and the
Le 14 mars 09 à 13:39, Akim Demaille a écrit :
I often use
STRICT_TEST_LOGS = $(shell $(LIST_FAILED_TEST_LOGS))
which makes all failing test strict. In other words, successful
tests are not rerun by make check, but failing tests are. This is
because our test suite sometimes hits
Le 14 mars 09 à 14:46, Ralf Wildenhues a écrit :
* Akim Demaille wrote on Sat, Mar 14, 2009 at 02:25:03PM CET:
FWIW, I also noticed that we sometimes had tests that were removed/
renamed that were still marked as XFAILs. So I use this in some of
my
test suites:
Why are these not simply
Le 10 déc. 08 à 21:14, Ralf Wildenhues a écrit :
Hi Akim,
Hi!
* Akim Demaille wrote on Wed, Dec 10, 2008 at 10:21:50AM CET:
Ok. And these makes can be fooled to implement the feature by
computing
the file name at make-time instead of passing a litteral?
Not quite sure I follow here
Le 4 déc. 08 à 09:38, Ralf Wildenhues a écrit :
I have a silly question, but... is it really known for a fact that
some
Make out there do not support include if it exists?
This question is not relevant to the problem. Automake requires some
'make'-provided inclusion mechanism to work,
RW == Ralf Wildenhues [EMAIL PROTECTED] writes:
* Ralf Wildenhues wrote on Sun, Oct 12, 2008 at 10:46:06PM CEST:
I'll follow up on automake-patches with a patch to test.
Here we go. WDYT?
Hi Ralf,
Sorry I did not answer before.
In other projects I'm involved in we store in
, ignore the old default
source rule for libtool libraries.
* doc/automake.texi (Default _SOURCES): Document this.
* NEWS: Update.
* tests/specflg10.test: New test.
* tests/Makefile.am: Update.
Suggestion by Akim Demaille.
This is really nice, thanks a lot!
Le 18 oct. 08 à 03:02, Ralf Wildenhues a écrit :
* Akim Demaille wrote on Thu, Oct 16, 2008 at 04:11:22PM CEST:
I wish I could define
AM_DEFAULT_SOURCE_EXT = .cc
or whatever, so that I wouldn't have to define all the foo_SOURCES.
I agree extension is better than suffix. (Even
While talking about test suites, there is a simple change that would
make several Makefile.ams much shorter. Often tests are simple
one-compilation-unit programs, in which case the convention that
foo_SOURCES defaults to foo.c saves lot of dummy typing (especially if
there are many foos). But
RW == Ralf Wildenhues [EMAIL PROTECTED] writes:
+case fail=$$fail:xpass=$$xpass:xfail=$$xfail in \
+ fail=0:xpass=0:xfail=0) \
+msg=$$All$$all $$tests passed. ; \
+exit=true;;
RW == Ralf Wildenhues [EMAIL PROTECTED] writes:
+ # Try the variants that are tried in check.am.
+ while :; do
+ for r2h in $RST2HTML rst2html rst2html.py; do
+ echo $me: running $r2h --version
+ $r2h --version break 2
+ done
+ exit 77
+ done
+
RW == Ralf Wildenhues [EMAIL PROTECTED] writes:
[EMAIL PROTECTED] Simple tests using @samp{parallel-tests}
[EMAIL PROTECTED] @option{parallel-tests}, Using
+The option @option{parallel-tests} (@pxref{Options}) enables a test
+suite driver that is mostly compatible to the simple test
Now that Automake uses a decent version control
system which, I guess, preserves the history with
mv cp etc. it might be time to rename the lib dir
as share/?
notification email; so we list those
revisions in full, below.
- Log -
commit 66027a9bdc9bd3419f5a87e7d50c3ff0f2e920b8
Author: Akim Demaille [EMAIL PROTECTED]
Date: Sun Nov 25 12:02:22 2007 +0100
Fix uses of am__strip_dir
-
commit adde5afee18384c94974a380df4f85a372e58df9
Author: Akim Demaille [EMAIL PROTECTED]
Date: Sun Nov 25 17:43:17 2007 +0100
Several *-local in a rule do not work.
* tests/all.test: Check this case.
Use set
I have been fighting with git for almost two hours
to put my patches in order and to apply them upstream.
I wish I could have spent some time on the patches themselves,
but I guess it'll come once I understand how git works :(
I'm stuck here, and I'm tired of it. I can't seem to be
able to do
Le 24 nov. 07 à 10:18, Akim Demaille a écrit :
[EMAIL PROTECTED] ~/src/wd/automake $ git
push 10:11:43
fatal: The remote end hung up unexpectedly
error: failed to push to 'git://git.sv.gnu.org/automake.git'
I have found pages reporting that this message
Le 24 nov. 07 à 10:58, Akim Demaille a écrit :
[EMAIL PROTECTED] ~/src/wd/automake $ git config remote.origin.url ssh://[EMAIL
PROTECTED]/automake.git
Fixed.
[EMAIL PROTECTED] ~/src/wd/automake $ git config remote.origin.url ssh://[EMAIL
PROTECTED]/srv/git/automake.git
[EMAIL PROTECTED
Le 24 nov. 07 à 11:03, Ralf Wildenhues a écrit :
Hello Akim,
* Akim Demaille wrote on Sat, Nov 24, 2007 at 10:18:30AM CET:
I have been fighting with git for almost two hours
to put my patches in order and to apply them upstream.
I'm really sorry it's so much trouble for you.
It's because
-
commit 94e81d5582c92a4376744bc5e601f60773f63e71
Author: Akim Demaille [EMAIL PROTECTED]
Date: Sat Nov 24 12:24:22 2007 +0100
Ternary operator in lib/am files.
* automake.in (transform_token): New.
(transform
-
commit 9c7aee991634ac47e207fe54730afaa1b67dd2dc
Author: Akim Demaille [EMAIL PROTECTED]
Date: Sat Nov 24 15:02:41 2007 +0100
Skip comments and empty lines in dirlist in the tests.
* defs.in (extra_includes): Skip
The test suite was failing on my machine because I
have an empty line in a dirlist. It resulted in
a -I without argument.
I suggest the following patch.
* defs.in (extra_includes): Skip comments and empty
lines in dirlist.
diff --git a/tests/defs.in b/tests/defs.in
index
Le 19 nov. 07 à 10:31, Ralf Wildenhues a écrit :
Hello Akim,
* Akim Demaille wrote on Mon, Nov 19, 2007 at 06:47:41AM CET:
The first thing I would like to do is to factor the
calls to install, using install FILES... DIR.
The first thing you should do then is get the GNU Coding Standards
| # This program is free software; you can redistribute it and/or
modify
| # it under the terms of the GNU General Public License as
published by
| -# the Free Software Foundation; either version 3, or (at your
option)
| +# the Free Software Foundation; either version 2, or (at your
I see that the documentation of Automake suggests:
all-local:
cd subdir $(MAKE) $(AM_MAKEFLAGS) all
check-local:
cd subdir $(MAKE) $(AM_MAKEFLAGS) test
clean-local:
cd subdir $(MAKE) $(AM_MAKEFLAGS) clean
# Assuming the package
Le 19 nov. 07 à 06:26, Akim Demaille a écrit :
I would like to work a bit on the install targets
The first thing I would like to do is to factor the
calls to install, using install FILES... DIR. One
problem is nobase_. I see several means to cope with it:
- Don't try to factor calls
Le 29 mars 05, à 20:46, Alexandre Duret-Lutz a écrit :
+data.c data.h data.w data.x: data.stamp
+## Recover from the removal of $@@
+@@if test -f $@@; then :; else \
+ trap 'rm -rf data.lock data.stamp 1 2 13 15; \
+## mkdir is a portable test-and-set
+ if mkdir data.lock
63 matches
Mail list logo
