Re: [PATCH] missing: add autoreconf, autogen and perl as supported programs

2015-08-14 Thread Eric Blake
, and not a problem with your original submission. Anyone that is subscribed to the list got the real contents, not the list-archived-munged contents. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital

Re: [FYI] {micro} sync: update third-part files from upstream

2015-01-05 Thread Eric Blake
-2002, 2004-2014 Free Software Foundation, Hmm, is it worth getting autoconf up to 2015, and propagate that into gnulib, before you commit this? -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital

Re: [PATCH] compile: don't place built object files in $(srcdir), ever ...

2015-01-02 Thread Eric Blake
), and 'baz.o' in $(top_builddir) rather than in +$(top_srcdir). + +This was the second part of automake bug#13928. + And thanks for tackling this! -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt

Re: [PATCH] PATH: use double quote

2014-09-22 Thread Eric Blake
) are now handled differently. You need a lot more justification for WHY this patch is necessary. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH] PATH: use double quote

2014-09-22 Thread Eric Blake
for the shortest line. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: AM_CONDITIONAL fails with line break at the end of $2

2014-07-17 Thread Eric Blake
On 07/17/2014 12:44 PM, Dimitrios Apostolou wrote: Hi Erik, thank you for forwarding to the appropriate list! On Thu, 17 Jul 2014, Eric Blake wrote: I don't know if automake should work around your bad syntax, or if you should just fix your configure.ac to use correct syntax to begin

Re: AM_CONDITIONAL fails with line break at the end of $2

2014-07-17 Thread Eric Blake
dropping autoconf On 07/17/2014 10:24 AM, Eric Blake wrote: [adding automake] On 07/17/2014 10:00 AM, Dimitrios Apostolou wrote: --- cond.m4 2014-07-17 17:46:37.741723897 +0200 +++ cond.2.m42014-07-17 17:50:43.456076469 +0200 @@ -13,17 +13,18 @@ [AC_PREREQ([2.52])dnl m4_if

Re: bug#14991: distcheck passes --prefix to configure before *DISTCHECK_CONFIGURE_FLAGS

2013-10-30 Thread Eric Blake
the options passed to the original ./configure invocation through to the configure invocations in make distcheck. This was causing problems, because it also passed through the original --srcdir and --prefix options. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library

Re: [FYI] {micro} NEWS: update with the changes since v1.14

2013-10-29 Thread Eric Blake
that this bug O(N) perhaps? -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [FYI] {branch-1.13.2} HACKING: miscellaneous fixes, updates and enhancements

2013-05-15 Thread Eric Blake
his name in the commit message - and in the test case you write. Put him into THANKS. + that fixes or exposes the bug, an put him into THANKS. s/an/and/ -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP

Re: [FYI] {maint} news: document new 'subdir-objects' warning

2013-05-10 Thread Eric Blake
/bugreport.cgi?bug=13378#35 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13378#44 + - The next major Automake version (2.0) will unconditionally turn on +the 'subdir-objects' option. I order to smooth out the transition, s/I/In/ -- Eric Blake eblake redhat com+1-919-301-3266

Re: [PATCH] THANKS: update Eric Blake's e-mail address

2013-05-10 Thread Eric Blake
...@informatik.tu-chemnitz.de Erez Zadok e...@cs.columbia.edu -Eric Blake e...@byu.net +Eric Blake ebl...@redhat.com Eric Dorlande...@debian.org Eric Magnienemagn...@club-internet.fr Eric

Re: bug#13524: Improving user experience for non-recursive builds

2013-02-04 Thread Eric Blake
. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH 1/5] Drop support for 'configure.in' as the Autoconf input file

2013-01-28 Thread Eric Blake
of the tool it was originally created with, rather than rebootstrapping with the latest version of the tool and forcing the distro maintainers to heavily patch old packages. In other words, this is not necessarily a good argument. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt

Re: bug#13378: Cleaning up AC_PROG_CC_C_O semantics

2013-01-16 Thread Eric Blake
on doing that, so please go ahead. Didn't you already add _AM_PROG_CC_C_O_HELPME; is that a sufficient witness macro for whether to use the proposed cleanups? -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP

Re: [PATCH 01/11] compile: avoid AC_PROG_CC messy rewrite

2013-01-14 Thread Eric Blake
you really intend always distribute 'compile' script, and (if losing compiler, rewrite $CC). Try this wording: Instead, just touch up AC_PROG_CC to rewrite $CC when a losing compiler is detected, and to always distribute the 'compile' script. -- Eric Blake eblake redhat com+1-919-301-3266

[PATCH] docs: mention dist-hook help for EXTRA_DIST

2013-01-03 Thread Eric Blake
From: Karl Berry k...@gnu.org * automake.texi (Basics of Distribution): mention dist-hook as working around the problems of whole directories in EXTRA_DIST. --- I didn't mind taking 3 minutes to convert this into a git commit. doc/automake.texi | 4 +++- 1 file changed, 3 insertions(+), 1

Re: [PATCH] aclocal: AC_CONFIG_MACRO_DIRS: work around autom4te option parsing bugs

2012-11-15 Thread Eric Blake
([AC_CONFIG_MACRO_DIRS], [_AM_CONFIG_MACRO_DIRS($@)])]) -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH] aclocal: tracing AC_CONFIG_MACRO_DIRS can work with older autoconf as well

2012-11-15 Thread Eric Blake
or autoconf 2.70 to have this work, and that back-compat to automake 1.12 and autoconf 2.69 requires manual effort in configure.ac. Meanwhile, I ought to do the same in the autoconf manual. ACK once you fix the comment. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization

Re: bug#12845: [PATCH] aclocal: tracing AC_CONFIG_MACRO_DIRS can work with older autoconf as well

2012-11-15 Thread Eric Blake
, you can't remove it from the pre-selections, even if newer automake no longer traces it. Basically, the preselections must be the union of anything that any released autotool wants to trace. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org

Re: bug#12845: [PATCH] aclocal: tracing AC_CONFIG_MACRO_DIRS can work with older autoconf as well

2012-11-15 Thread Eric Blake
, the preselections must be the union of anything that any released autotool wants to trace. I was aware of this. But thanks for spelling it out explicitly anyway. Glad to hear we're on the same page, then. And saves me the effort of researching something in a codebase you are more familiar with :O) -- Eric

Re: [PATCH 1/6] aclocal: multiple local m4 macro dirs with AC_CONFIG_MACRO_DIRS

2012-11-09 Thread Eric Blake
crammed in one AC_CONFIG_MACRO_DIRS call), you don't need to do any of the split(/\s+/) magic. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH] AC_CONFIG_MACRO_DIRS: improve tracing and add sanity checks

2012-11-09 Thread Eric Blake
On 11/09/2012 03:53 PM, Eric Blake wrote: Too many legacy tools exist for us to unilaterally quit supporting AC_CONFIG_MACRO_DIR - it is feasible for someone to want their package to bootstrap with both automake 1.13 and libtool 2.4.2, where the newer automake will only trace the new style

Re: [PATCH 6/6] aclocal: avoid spurious warnings from autom4te with AC_CONFIG_MACRO_DIRS

2012-11-07 Thread Eric Blake
inclusion as the witness of whether to warn would work even for older autoconf (where including the file has no effect), rather than the current situation of warning about an unknown option. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org

Re: [PATCH 6/6] aclocal: avoid spurious warnings from autom4te with AC_CONFIG_MACRO_DIRS

2012-11-07 Thread Eric Blake
like enough is waiting on me that I need to carve out a full day for autoconf work. You've convinced me - I'll have a patches posted to autoconf, including the best parts of what you have posted and were waiting for a 2-day review window, within the next 48 hours. -- Eric Blake ebl

Re: [PATCH 0/2] AC_CONFIG_MACRO_DIRS: implementation and documentation

2012-11-02 Thread Eric Blake
the dedicated file and therefore get the warning. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH] warn: new special syntax warning, hack for aclocal

2012-11-02 Thread Eric Blake
is that if the 'h' is aspirated, as in hack, then you use 'a'; if the 'h' is silent, as in hour, then use 'an') ACK with that fix; and assuming I ever get around to reviewing the other two patches that add AC_CONFIG_MACRO_DIRS in the first place (looking at them now...) -- Eric Blake ebl

Re: [FYI] {maint} tests: avoid spurious failure of 't/uninstall-fail.sh' on OpenIndiana

2012-08-06 Thread Eric Blake
positives when +# grepping error messages. inst=__inst-dir__ ./configure --prefix=$(pwd)/$inst -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH 1/2] aclocal: multiple local m4 macro dirs with AC_CONFIG_MACRO_DIR

2012-07-21 Thread Eric Blake
On 07/13/2012 04:40 PM, Eric Blake wrote: My plan for autoconf is to implement AC_CONFIG_MACRO_DIRS, which can be invoked multiple times and also takes a whitespace-separated list in a single call, but which will basically then call AC_CONFIG_MACRO_DIR once per unique entry

Re: [PATCH 1/2] aclocal: multiple local m4 macro dirs with AC_CONFIG_MACRO_DIR

2012-07-21 Thread Eric Blake
On 07/21/2012 09:51 AM, Eric Blake wrote: On 07/13/2012 04:40 PM, Eric Blake wrote: My plan for autoconf is to implement AC_CONFIG_MACRO_DIRS, which can be invoked multiple times and also takes a whitespace-separated list in a single call, but which will basically then call

Re: bug#11893: Regression in automake 1.12.1 on Mac OS X

2012-07-12 Thread Eric Blake
.' to ensure that -ef is understood, before then trying -ef to check for case insensitivity. Other than that, the only supported method in existing POSIX for checking for equal files is by parsing 'ls -i' output; but I don't know if 'ls -i' is portable to ancient hosts. -- Eric Blake ebl...@redhat.com

Re: bug#11893: Regression in automake 1.12.1 on Mac OS X

2012-07-12 Thread Eric Blake
for a first cut at the problem at hand. Or, maybe you should just create a file in /tmp under one spelling and check existence of the file by another spelling. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description

Re: bug#11893: Regression in automake 1.12.1 on Mac OS X

2012-07-12 Thread Eric Blake
On 07/12/2012 11:06 AM, Eric Blake wrote: Minor correction: That said, /bin/RMDIR is probably completely portable, but seems like it ^ not would be reliable in practice. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library

Re: bug#10766: bug#11893: Regression in automake 1.12.1 on Mac OS X

2012-07-12 Thread Eric Blake
On 07/12/2012 12:42 PM, Stefano Lattarini wrote: In the light of our discussion, attached is the patch I'd finally like to push. WDYT? Looks fine to me (although I have not actually tested it). -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http

Re: [PATCH 1/2] AC_CONFIG_MACRO_DIR: accept more than one argument

2012-07-04 Thread Eric Blake
newer semantic of autoconf. (Obviously, if libtool uses grep, we should fix that as well...) -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH 1/2] AC_CONFIG_MACRO_DIR: accept more than one argument

2012-07-04 Thread Eric Blake
On 07/04/2012 05:03 AM, Eric Blake wrote: Would it also make sense to allow multiple calls to AC_CONFIG_MACRO_DIR to stack, as in: AC_CONFIG_MACRO_DIR([dir1]) AC_CONFIG_MACRO_DIR([dir2]) And should we mention that the first directory listed has special significance to other tools like

Re: [PATCH 1/2] aclocal: multiple local m4 macro dirs with AC_CONFIG_MACRO_DIR

2012-07-04 Thread Eric Blake
(that is, AC_CONFIG_MACRO_DIRS will be smart enough to filter out duplicates). Tracing code should then trace _just_ AC_CONFIG_MACRO_DIR, which will be called once per directory, and where the first call is the preferred dumping ground for new macros. There shouldn't be a need to trace AC_CONFIG_MACRO_DIRS. -- Eric Blake

Re: [PATCH] {master} missing: do not touch timestamps; only warn for out-of-date files

2012-06-27 Thread Eric Blake
-missing}. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

[PATCH] docs: document AM_MISSING_PROG

2012-06-27 Thread Eric Blake
Addresses automake bug#11793. This macro has been present for a long time, and coreutils has been relying on it despite no documentation, which argues that it is stable enough to be worth documenting. Furthermore, since we are hoping to change our preferred invocation from 'missing --run

Re: [PATCH] docs: document AM_MISSING_PROG

2012-06-27 Thread Eric Blake
On 06/27/2012 03:55 PM, Eric Blake wrote: Addresses automake bug#11793. This macro has been present for a long time, and coreutils has been relying on it despite no documentation, which argues that it is stable enough to be worth documenting. Furthermore, since we are hoping to change

Re: bug#11793: AM_MISSING_PROG undocumented

2012-06-27 Thread Eric Blake
. Absolutely. Patches welcome ;-) Slowly but surely starting the process of sending patches :) -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH] yacc, lex: new 'no-ylwrap' option to prevent use of the 'ylwrap' script

2012-06-26 Thread Eric Blake
, especially if it would make automake easier to maintain. What sort of improvements are needed? This initial work leaves in Bison as m4/flex.m4. I know there is work to do (test, doc etc.), but at least I'd like some feedback. Then I'll proceed to Yacc/Bison. -- Eric Blake ebl

Re: Automake-installed auxiliary scripts can get silently out-of-date after an Automake upgrade

2012-06-26 Thread Eric Blake
convention also came with an easily probed witness option. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

[PATCH] missing: retore back-compat for use by older automake

2012-06-26 Thread Eric Blake
Commit a22717dffe3 removed the --run argument, since our new preferred calling conventions now imply it; but if a newer 'missing' is mixed with an already built project that used an older Automake version, then the 'Makefile' in that project will fail due to passing the --run option when trying to

Re: Automake-installed auxiliary scripts can get silently out-of-date after an Automake upgrade

2012-06-26 Thread Eric Blake
On 06/26/2012 12:04 PM, Bruno Haible wrote: Eric Blake wrote: Any idea for a simple solution to this problem? Aren't there timestamps in the auxiliary scripts for a reason? If a script is updated as part of a new automake release, can't automake insert some sanity checks to see

AM_MISSING_PROG undocumented

2012-06-26 Thread Eric Blake
[adding bug-automake, to turn into a formal bug] On 06/26/2012 11:39 AM, Eric Blake wrote: And while looking into how M4 differs from coreutils, I noticed that coreutils uses this via a .m4 file included into its configure.ac: AM_MISSING_PROG(HELP2MAN, help2man) which is roughly

Re: Automake-installed auxiliary scripts can get silently out-of-date after an Automake upgrade

2012-06-26 Thread Eric Blake
. For the scripts that you mentiones, like 'install-sh', which are generically useful, should we go ahead and re-home them to have gnulib instead of automake be the canonical upstream? -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc

Re: [PATCH] missing: retore back-compat for use by older automake

2012-06-26 Thread Eric Blake
On 06/26/2012 11:26 AM, Stefano Lattarini wrote: On 06/26/2012 06:40 PM, Eric Blake wrote: Commit a22717dffe3 removed the --run argument, since our new preferred calling conventions now imply it; but if a newer 'missing' is mixed with an already built project that used an older Automake

Re: AM_MISSING_PROG undocumented

2012-06-26 Thread Eric Blake
[adding bug-autoconf, for an autoconf documentation issue] On 06/26/2012 11:46 AM, Eric Blake wrote: [adding bug-automake, to turn into a formal bug] On 06/26/2012 11:39 AM, Eric Blake wrote: And while looking into how M4 differs from coreutils, I noticed that coreutils uses this via

Re: [PATCH] {master} missing: do not touch timestamps; only warn for out-of-date files

2012-06-25 Thread Eric Blake
On 06/25/2012 09:46 PM, Eric Blake wrote: case $1 in ---run) - # Try to run requested program, and just exit if it succeeds. - run= - shift - $@ exit 0 - # Exit code 63 means version mismatch. This often happens - # when the user try to use an ancient version of a tool

Re: [PATCH] tests: avoid one last `...` command substitution in 'test-init.sh'

2012-06-22 Thread Eric Blake
directory components. + me=${argv0##*/} Should this strip to the last [\\/] instead of /? + # Strip test suffix. + case $me in +*.tap) me=${me%.tap};; + *.sh) me=${me%.sh} ;; + esac fi -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library

Re: [PATCH] tests: avoid one last `...` command substitution in 'test-init.sh'

2012-06-22 Thread Eric Blake
real users/developers; until then, I'd keep the simpler idiom above. OK? Simpler is fine by me; I was just pointing out that you had a change in behavior, and wondering whether it was intentional (answer is yes, it was). -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt

Re: [FYI] {maint} bootstrap: overhaul and improve

2012-06-20 Thread Eric Blake
make. did you mean 'even' instead of 'env'? Other than that, I didn't review closely, but assume it is decent. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH] {maint} tests: use more POSIX shell features our test scripts

2012-06-14 Thread Eric Blake
few days, I can resume my review in time for your initial push. Or you can go ahead and push, and I can report any further issues for followup patches, since the overall idea looks good and most of the changes appear to have been mechanical. -- Eric Blake ebl...@redhat.com+1-919-301-3266

Re: [PATCH 1/5] tests: shell running test scripts is now named AM_TEST_RUNNER_SHELL

2012-05-07 Thread Eric Blake
. This patch looks mostly mechanical. I didn't check if you had any missed conversions, but the ones you made are sane. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH 2/5] configure: search a sturdy POSIX shell to be used in the testsuite

2012-05-07 Thread Eric Blake
on the user's path that does what we want). But in the fallback mode, wouldn't it be better to list xpg6 before xpg4, for the additional fixes in xpg6? Overall, looks reasonable for finding a decent shell. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http

Re: [PATCH 3/5] tests: remove obsolete uses of $sh_errexit_works

2012-05-07 Thread Eric Blake
-check-cleanup.tap |4 t/self-check-exit.tap | 13 + t/self-check-explicit-skips.sh |2 -- 6 files changed, 2 insertions(+), 26 deletions(-) Nice cleanups! -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http

Re: [PATCH 4/5] test defs: fix indentation (cosmetic change)

2012-05-07 Thread Eric Blake
file changed, 56 insertions(+), 57 deletions(-) Always nice to reviewers to separate indentation cleanups from logic changes. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH 5/5] tests: fix a spurious failure with dash

2012-05-07 Thread Eric Blake
about being able to trigger a syntax error? -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH 0/5] Convert automake testsuite to the use of a POSIX shell

2012-05-01 Thread Eric Blake
| 18 ++-- t/self-check-sanity.sh |8 +- t/self-check-tap.sh| 16 ++-- 14 files changed, 320 insertions(+), 151 deletions(-) -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description

Re: [PATCH] {maint} aclocal: error out again on unrecognized arguments

2012-05-01 Thread Eric Blake
: + + - When given non-option arguments, aclocal rejects them, instead of +silently ignoring them. perhaps to 1.11.3? -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH] {maint} aclocal: error out again on unrecognized arguments

2012-05-01 Thread Eric Blake
On 05/01/2012 04:27 PM, Stefano Lattarini wrote: HI Eric, thanks for the super-quick review. On 05/02/2012 12:18 AM, Eric Blake wrote: On 05/01/2012 04:14 PM, Stefano Lattarini wrote: Starting from commit v1.11-662-g52246cc of XXX, XXX, aclocal has Did you mean to fix the XXX? Oops, I

Re: bug#11356: automake 1.12 and (C) 2011

2012-04-27 Thread Eric Blake
executable, I suggest a more permanent solution, by borrowing the same trick used by Autoconf. Make this @RELEASE_YEAR@, which is set by an AC_SUBST'd string that auto-updates itself at configure time, instead of manually changing it each time a year rolls around. -- Eric Blake ebl...@redhat.com

Re: [PATCH] {maint} bootstrap: add convenience make target

2012-04-27 Thread Eric Blake
reviewing how it all works. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH] {maint} news: break up in two files, one for maint, one for master

2012-04-26 Thread Eric Blake
an interesting solution. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [FYI] {master} refactor: use modern semantics of 'open'

2012-04-26 Thread Eric Blake
On 04/26/2012 05:12 AM, Stefano Lattarini wrote: Hi Eric, sorry for the delay. On 04/25/2012 01:25 AM, Eric Blake wrote: Actually, this appears to make _all_ the XFile uses work; all that remains broken is places such as bin/autoupdate.in calling raw open instead of using XFile. diff

Re: bug#11347: the remake rules in the automake test suite are too greedy

2012-04-26 Thread Eric Blake
Makefile.am # Static dependencies valid for each test case. check_SCRIPTS = t/wrap/aclocal-$(APIVERSION) t/wrap/automake-$(APIVERSION) -- 1.7.9.5 -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital

Re: [PATCH] {maint} news: break up in two files, one for maint, one for master

2012-04-26 Thread Eric Blake
to enforce good NEWS entries across both branches, then simpler is reasonable. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

[FYI] {master} refactor: use modern semantics of 'open'

2012-04-24 Thread Eric Blake
6ee479858ab4a4c4054d6ee334adae4e38295e52 Mon Sep 17 00:00:00 2001 From: Eric Blake ebl...@redhat.com Date: Tue, 24 Apr 2012 16:06:03 -0600 Subject: [PATCH] bin: replace older perl open_quote workaround with modern idiom Now that we require more modern perl, we might as well use it. See https://lists.gnu.org

Re: [FYI] {master} refactor: use modern semantics of 'open'

2012-04-24 Thread Eric Blake
On 04/24/2012 04:50 PM, Russ Allbery wrote: Eric Blake ebl...@redhat.com writes: Help! I can't release autoconf 2.69 until I figure out how to work around this patch. After updating to the latest shared files, as well as applying this patch, I'm now stuck with output going to a literal

Re: [FYI] {master} refactor: use modern semantics of 'open'

2012-04-24 Thread Eric Blake
On 04/24/2012 05:17 PM, Stefano Lattarini wrote: Hi Eric, Russ. On 04/25/2012 01:08 AM, Eric Blake wrote: On 04/24/2012 04:50 PM, Russ Allbery wrote: Eric Blake ebl...@redhat.com writes: Help! I can't release autoconf 2.69 until I figure out how to work around this patch. After updating

Re: [PATCH 2/2] maint: drop 'Automake::Struct' module

2012-03-05 Thread Eric Blake
On 03/05/2012 12:20 PM, Stefano Lattarini wrote: On 03/05/2012 02:18 PM, Eric Blake wrote: On 03/04/2012 08:14 AM, Stefano Lattarini wrote: Now that we require Perl 5.6.2, we can drop the 'Automake::Struct' module, which was basically just a backport of Perl 5.6's 'Class::Struct' to Perl 5.5

Re: bug#10898: test-suite output of automake-1.11.3 - it requested I send it to you!

2012-02-28 Thread Eric Blake
in our testsuite when a shell suffering of this bug was used to run the test cases. Yuck - this sounds like it should be documented in the autoconf manual. Is it only shell functions that are affected, but global use of ${1+$@} is still safe? -- Eric Blake ebl...@redhat.com+1-919-301-3266

Re: [FYI] {master} maint: assume 'test -x' is portable

2012-02-27 Thread Eric Blake
./foo.sh; echo $? test -x foo.sh; echo $? chmod a+x foo.sh; echo $? ./foo.sh; echo $? test -x foo.sh; echo $? Once I know those behaviors, I think I can ensure that my proposed test to require a working 'test -x' as a pre-req of finding a sane shell should still work for MSYS. -- Eric Blake ebl

Re: pkglibdir, pkgdatadir and program_transform_name

2012-02-27 Thread Eric Blake
of the second installation, and then adding automake and/or autoconf support for providing configure support for an alternate package name, seems like it would be worthwhile for more than just grub. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org

Re: [PATCH] hacking: document format for git commit messages

2012-02-27 Thread Eric Blake
commit pushed, even if the line is redundant with the author. - Ralf Wildenhues used the Signed-off-by as well (bit I never asked him why); Eric Blake uses them too (Eric, if you are reading, care to tell us why?); Habit, because I've submitted to git before. But I can drop them, just

Re: [FYI] {master} maint: assume 'test -x' is portable

2012-02-27 Thread Eric Blake
So I'm pretty sure that I'm safe to check in my patches without causing grief for MSYS, although if you'd test the pre-release before 2.69, it can't hurt things. I hope to have the pre-release announcement out later today. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt

Re: automake 1.11.3 check-TESTS and command line length

2012-02-27 Thread Eric Blake
... Yes. Unlike on *ix systems, where argv and environ are independent entities, Windows makes you deal with both limits at the same time, so increasing the size of environ reduces the size permitted in argv. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http

Re: bug#10878: make dist with read-only srcdir generates read-only tarball

2012-02-24 Thread Eric Blake
distcheck'. If you want to guarantee that the generated tarball has certain permissions, then you, as the package author, must add something in your dist-hook to guarantee it, since automake cannot know which files you _need_ to leave writable. -- Eric Blake ebl...@redhat.com+1-919-301-3266

Re: [FYI] {master} maint: assume 'test -x' is portable

2012-02-23 Thread Eric Blake
system. Since we are at it, improve diagnostic in case of failure. The autoconf manual still recommends: Do not use @samp{test -x}, because 4.3BSD does not have it. Is this still an issue? Or should we be updating the autoconf manual? -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt

Re: [FYI] {master} news: minor fixlets and reorganization

2012-02-21 Thread Eric Blake
as a separator - it is an easy character to search for. Whereas lines of cause spurious hits when searching for '===' when solving a merge conflict. I'm not opposed to the change if you have a good reason, but I don't yet see that good reason. -- Eric Blake ebl...@redhat.com+1-919-301-3266

Re: [FYI] {master} news: minor fixlets and reorganization

2012-02-21 Thread Eric Blake
On 02/21/2012 06:05 AM, Stefano Lattarini wrote: On 02/21/2012 01:39 PM, Eric Blake wrote: On 02/21/2012 05:34 AM, Stefano Lattarini wrote: * NEWS: Get rid of form-feed characters (^L) throughout the file. Use separator lines instead (composed by 76 '=' characters), or just an extra blank

Re: [FYI] {master} readme: update and renew

2012-02-16 Thread Eric Blake
also has three mailing lists: +Automake has also three mailing lists: Drop this hunk; the original also has sounds better to a native speaker. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital

Re: Merging 'yacc-work' into master

2012-02-14 Thread Eric Blake
On 02/14/2012 05:10 AM, Stefano Lattarini wrote: Maybe we should aim for a cleaner and more general solution, and resurrect and extend the following patch by Eric Blake instead: http://lists.gnu.org/archive/html/automake/2012-01/msg00011.html BTW, Eric, any reason for which you never

Re: [RFC] Removing obsolete branch 'branch-1-10'

2012-02-14 Thread Eric Blake
by then. Is there _any_ chance that there might be a distro out there that is basing backported patches on top of branch-1-10? I'm a bit hesitant to remove this particular branch, but I won't complain if I get outvoted. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization

Re: [FYI] {yl-work-for-master} fixup: remove double news entry

2012-02-13 Thread Eric Blake
it's time to write a custom merge driver for NEWS, similar to the custom merge file for ChangeLog? -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [PATCH] depcomp: recognize tabs as whitespace in the dashmstdout mode

2012-02-03 Thread Eric Blake
, but also agree that it creates merge conflicts any time development on the file diverges across branches, so removing it won't hurt my feelings, but it will make it harder to tell whether I have the latest version of the script. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt

Re: bug#10448: [PATCHES] {master} dist: distdir not unconditionally removed anymore for xz and lzip

2012-01-09 Thread Eric Blake
On 01/08/2012 02:19 AM, Stefano Lattarini wrote: The problem with 'dist-xz' was introduced in the merge commit `v1.11-1183-g72c8dcb', and the problem with 'dist-lzip' was introduced in the merge commit `xxx' You may want to fix that xxx before pushing patch 2/2. -- Eric Blake ebl

Re: bug#8071: Please rename automake invocation node

2011-12-30 Thread Eric Blake
Names. The @anchor allows old @c links to still work. @anchor{Specifying Names} I'm not sure if putting the @anchor after the @node make a difference. If the anchor takes the old name to the previous node, then we may want to move the anchor to appear after the @node. -- Eric Blake ebl

Re: [PATCH] {maint} dist: add support for lzip compression

2011-12-30 Thread Eric Blake
it be better to split this into two commits - Antonio's actual (tiny) change, and separately the tests/ addition that you wrote to expose it? -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital

Re: bug#8071: Please rename automake invocation node

2011-12-30 Thread Eric Blake
in that directory, I see doc/automake.html/Invoking-aclocal.html with contents: meta http-equiv=refresh content=0; url=Optional.html#Invoking%20aclocal which means the anchor got associated with the page Optional.html, instead of the desired aclocal-Invocation.html. So we _do_ need to make the swap. -- Eric

Re: [PATCH] {maint} dist: obsolote support for lzma (superseded by xz)

2011-12-30 Thread Eric Blake
cause an unacceptable memory consumptions when one tries to s/consumptions/consumption/ -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: bug#8071: Please rename automake invocation node

2011-12-28 Thread Eric Blake
will then keep the old link live by virtue of the anchor, without having to mess with .symlinks. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [FYI] {maint} tests: report useful system information from 'test-suite.log'

2011-12-22 Thread Eric Blake
. + Exit 77 +fi + +# Some unexpected error occurred; this must be reported as an hard error +# by the testsuite driver. +Exit 99 -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [FYI] {maint} tests: report useful system information from 'test-suite.log'

2011-12-22 Thread Eric Blake
/; hope it's OK as well (it seems to me). Yep, your followup works just fine. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: [Platform-testers] Automake 1.11.1b test release

2011-12-16 Thread Eric Blake
? -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature

Re: Testing automake on Cygwin 1.7

2011-11-28 Thread Eric Blake
was changed. That is, any test that relies on a directory's modification time always being reliable in relation to the timestamps of files within that directory is inherently non-portable. -- Eric Blake ebl...@redhat.com+1-919-301-3266 Libvirt virtualization library http://libvirt.org

Re: [FYI 1/2] {test-protocols} tap/awk: handle exit statuses 256 (seen on few korn shells)

2011-09-28 Thread Eric Blake
of this assignment. so be prepared to handle them both. Yes, portability does demand we handle both. Also, would you mind preparing an autoconf patch to mention this? -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

Re: bug#9579: distcheck does not detect incomplete uninstall as advertised

2011-09-23 Thread Eric Blake
be too tricky to be really worth, so we declare -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org

Re: [PATCH] ylwrap: fix unusual indentation whitespace

2011-08-25 Thread Eric Blake
On 08/25/2011 12:56 PM, Stefano Lattarini wrote: Hi Eric, thanks for the patch. On Thursday 25 August 2011, Eric Blake wrote: On 08/25/2011 12:41 PM, Eric Blake wrote: * lib/ylwrap: Convert to spaces. Reported by Karl Berry. Signed-off-by: Eric Blakeebl...@redhat.com --- I'm assuming

  1   2   >