Re: [PATCH] {maint} tests: new subroutines for test skipping/failing

On Saturday 23 April 2011, Jim Meyering wrote: > Stefano Lattarini wrote: > > OK, I've added Jim as the primary author of this patch (both in the > > ChangeLog and with "git --author"). I'll wait his ACK on this attribution > > before pushing. > > Hi Stefano, > > Thanks for the heads-up. That lo

Re: [PATCH] {maint} tests: new subroutines for test skipping/failing

Stefano Lattarini wrote: > Hello automakers. Resuming an old thread ... > > Reference: > > > On Monday 17 January 2011, Ralf Wildenhues wrote: >> [ Cc:ing Jim because of ideas at the end ] >> > And CC:ing him again becaus

Re: [PATCH] {maint} tests: new subroutines for test skipping/failing

Hello automakers. Resuming an old thread ... Reference: On Monday 17 January 2011, Ralf Wildenhues wrote: > [ Cc:ing Jim because of ideas at the end ] > And CC:ing him again because I'd like an ACK from him (see below).

Re: [PATCH] {maint} tests: new subroutines for test skipping/failing

On Monday 18 April 2011, Stefano Lattarini wrote: > On Sunday 17 April 2011, Stefano Lattarini wrote: > > On Sunday 17 April 2011, Ralf Wildenhues wrote: > > > Hello Stefano, > > > > > > * Stefano Lattarini wrote on Sun, Apr 17, 2011 at 03:27:17PM CEST: > > > > Reference: > > > > > > > >

Re: [PATCH] {maint} tests: new subroutines for test skipping/failing

On Sunday 17 April 2011, Stefano Lattarini wrote: > On Sunday 17 April 2011, Ralf Wildenhues wrote: > > Hello Stefano, > > > > * Stefano Lattarini wrote on Sun, Apr 17, 2011 at 03:27:17PM CEST: > > > Reference: > > > > > >

Re: [PATCH] {maint} tests: new subroutines for test skipping/failing

On Sunday 17 April 2011, Ralf Wildenhues wrote: > Hello Stefano, > > * Stefano Lattarini wrote on Sun, Apr 17, 2011 at 03:27:17PM CEST: > > Reference: > > > > > > On Wednesday 30 March 2011, Stefano Lattarini wrote: > > >

Re: [PATCH] {maint} tests: new subroutines for test skipping/failing

Hello Stefano, * Stefano Lattarini wrote on Sun, Apr 17, 2011 at 03:27:17PM CEST: > Reference: > > > On Wednesday 30 March 2011, Stefano Lattarini wrote: > > > > > $(AM_TESTS_SETUP) $(TESTS_SETUP) $(TESTS_ENVIRONMENT)

Re: [PATCH] {maint} tests: new subroutines for test skipping/failing

Reference: On Wednesday 30 March 2011, Stefano Lattarini wrote: > On Monday 14 March 2011, Stefano Lattarini wrote: > > Hello Ralf and all automakers. > > > > Reference: > >

Re: [PATCH] {maint} tests: new subroutines for test skipping/failing

On Monday 14 March 2011, Stefano Lattarini wrote: > Hello Ralf and all automakers. > > Reference: > > Whole original thread: > > which stemmed fro

Re: [PATCH] {maint} tests: new subroutines for test skipping/failing

Hello Ralf and all automakers. Reference: Whole original thread: which stemmed from:

[PATCH] {maint} tests defs: clear TESTS_ENVIRONMENT variable (was: Re: [PATCH] {maint} tests: new subroutines for test skipping/failing)

Reference: On Sunday 06 February 2011, Stefano Lattarini wrote: > On Friday 04 February 2011, Ralf Wildenhues wrote: > > * Stefano Lattarini wrote on Mon, Jan 24, 2011 at 04:04:30PM CET: > > > --- /dev/null > > > +++ b/tes

Re: [PATCH] {maint} tests: new subroutines for test skipping/failing

Reference: On Sunday 06 February 2011, Stefano Lattarini wrote: > On Friday 04 February 2011, Ralf Wildenhues wrote: > > Hello Stefano, > > > Hi Ralf, and sorry for the delay. > > > you've already applied this patch, but

Re: [PATCH] {maint} tests: new subroutines for test skipping/failing

On Friday 04 February 2011, Ralf Wildenhues wrote: > Hello Stefano, > Hi Ralf, and sorry for the delay. > you've already applied this patch, but I have a couple of nits anyway: > > * Stefano Lattarini wrote on Mon, Jan 24, 2011 at 04:04:30PM CET: > > Subject: [PATCH] coverage: more tests on simpl

Re: [PATCH] {maint} tests: new subroutines for test skipping/failing

Hello Stefano, you've already applied this patch, but I have a couple of nits anyway: * Stefano Lattarini wrote on Mon, Jan 24, 2011 at 04:04:30PM CET: > Subject: [PATCH] coverage: more tests on simple and parallel test drivers > > * tests/parallel-tests-subdir.test: New test. > * tests/check-ex

Re: [PATCH] {maint} tests: new subroutines for test skipping/failing

Reference: On Monday 24 January 2011, Stefano Lattarini wrote: > > While writing the above patch, I noticed that the coverage of the > simple-tests and parallel-tests drivers is still lacking in some > respects. The attac

Re: [PATCH] {maint} tests: new subroutines for test skipping/failing

Hello automakers. > check: new developer-reserved AM_TESTS_SETUP variable > > For reference, see the discussion at: > > > * lib/am/check.am [%?PARALLEL_TESTS%] (am__check_pre): Pass also > $(AM_TESTS_SETUP). Comments updat

Re: [PATCH] {maint} tests: new subroutines for test skipping/failing

Hello Ralf. On Wednesday 19 January 2011, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Wed, Jan 19, 2011 at 08:23:20PM CET: > > On Wednesday 19 January 2011, Ralf Wildenhues wrote: > > > AM_TESTS_ENVIRONMENT = foo=1 > > > TESTS_ENVIRONMENT = foo=2 > > > > > > the > > > $(AM_TESTS_E

Re: [PATCH] {maint} tests: new subroutines for test skipping/failing

Ralf Wildenhues wrote: ... >> > > +# This is useful when using automake's parallel tests mode, to print >> > > +# the reason for skip/failure to console, rather than to the .log files. >> > > +: ${stderr_fileno_=2} >> > > + >> > > +warn_() { echo "$@" 1>&$stderr_fileno_; } >> > > +fail_() { warn_ "

Re: [PATCH] {maint} tests: new subroutines for test skipping/failing

* Stefano Lattarini wrote on Wed, Jan 19, 2011 at 08:23:20PM CET: > On Wednesday 19 January 2011, Ralf Wildenhues wrote: > > AM_TESTS_ENVIRONMENT = foo=1 > > TESTS_ENVIRONMENT = foo=2 > > > > the > > $(AM_TESTS_ENVIRONMENT) $(TESTS_ENVIRONMENT) ./test > > > > will let Solaris sh pass foo=1

Re: [PATCH] {maint} tests: new subroutines for test skipping/failing

On Wednesday 19 January 2011, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Tue, Jan 18, 2011 at 11:35:13PM CET: > > On Tuesday 18 January 2011, Ralf Wildenhues wrote: > > > * Stefano Lattarini wrote on Mon, Jan 17, 2011 at 10:55:55PM CET: > > > > On Monday 17 January 2011, Ralf Wildenhues

Re: [PATCH] {maint} tests: new subroutines for test skipping/failing

* Stefano Lattarini wrote on Tue, Jan 18, 2011 at 11:35:13PM CET: > On Tuesday 18 January 2011, Ralf Wildenhues wrote: > > * Stefano Lattarini wrote on Mon, Jan 17, 2011 at 10:55:55PM CET: > > > On Monday 17 January 2011, Ralf Wildenhues wrote: > > > > Why not document framework_failure_? > > > >

Re: [PATCH] {maint} tests: new subroutines for test skipping/failing

On Tuesday 18 January 2011, Jim Meyering wrote: > Ralf Wildenhues wrote: > > ... > > > >> +# This is useful when using automake's parallel tests mode, to print > >> +# the reason for skip/failure to console, rather than to the .log files. > >> +: ${stderr_fileno_=2} > >> + > >> +warn_() { echo "$@"

Re: [PATCH] {maint} tests: new subroutines for test skipping/failing

On Tuesday 18 January 2011, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Mon, Jan 17, 2011 at 10:55:55PM CET: > > On Monday 17 January 2011, Ralf Wildenhues wrote: > > > * Stefano Lattarini wrote on Sun, Jan 16, 2011 at 03:56:07PM CET: > > > > + Use the `skip_' function to skip tests, wit

Re: [PATCH] {maint} tests: new subroutines for test skipping/failing

* Stefano Lattarini wrote on Tue, Jan 18, 2011 at 11:21:42PM CET: > On Tuesday 18 January 2011, Ralf Wildenhues wrote: > > 1) AM_TESTS_SETUP TESTS_SETUP > > > > or > > 2) AM_TEST_SETUP TEST_SETUP > > > Honestly, I find (1) more intuitive, and I'd prefer it even without the > TESTS_ENVIRONMENT pr

Re: [PATCH] {maint} tests: new subroutines for test skipping/failing

On Tuesday 18 January 2011, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Mon, Jan 17, 2011 at 10:55:55PM CET: > > > $(AM_TESTS_SETUP) $(TESTS_SETUP) > > One thing I'm a bit unsure about: > 1) AM_TESTS_SETUP TESTS_SETUP > > or > 2) AM_TEST_SETUP TEST_SETUP > > ? I would have preferred

Re: [PATCH] {maint} tests: new subroutines for test skipping/failing

* Stefano Lattarini wrote on Mon, Jan 17, 2011 at 10:55:55PM CET: > On Monday 17 January 2011, Ralf Wildenhues wrote: > > * Stefano Lattarini wrote on Sun, Jan 16, 2011 at 03:56:07PM CET: > > > + Use the `skip_' function to skip tests, with a meaningful message if > > > + possible. Where conveni

Re: [PATCH] {maint} tests: new subroutines for test skipping/failing

* Stefano Lattarini wrote on Mon, Jan 17, 2011 at 10:55:55PM CET: > > $(AM_TESTS_SETUP) $(TESTS_SETUP) One thing I'm a bit unsure about: 1) AM_TESTS_SETUP TESTS_SETUP or 2) AM_TEST_SETUP TEST_SETUP ? I would have preferred TEST_ENVIRONMENT, but that one is far too late to change. (1) is cons

Re: [PATCH] {maint} tests: new subroutines for test skipping/failing

Ralf Wildenhues wrote: ... > Why not document framework_failure_? > >>For tests that use the `parallel-tests' Automake option, set the shell >>variable `parallel_tests' to "yes" before including ./defs. Also, >>use for them a name that ends in `-p.test' and does not clash with any > >>

Re: [PATCH] {maint} tests: new subroutines for test skipping/failing

On Monday 17 January 2011, Ralf Wildenhues wrote: > [ Cc:ing Jim because of ideas at the end ] > > * Stefano Lattarini wrote on Sun, Jan 16, 2011 at 03:56:07PM CET: > > This patch stemmed from this discussion: > > > > > >

Re: [PATCH] {maint} tests: new subroutines for test skipping/failing

[ Cc:ing Jim because of ideas at the end ] * Stefano Lattarini wrote on Sun, Jan 16, 2011 at 03:56:07PM CET: > This patch stemmed from this discussion: > > > I'd like to have the patch applied to maint, to make eventual i

[PATCH] {maint} tests: new subroutines for test skipping/failing

Hello automakers. This patch stemmed from this discussion: I'd like to have the patch applied to maint, to make eventual integration of new tests easier. But the follow-up patches converting the testsuite to the use of s