[FYI] pushed to master (was: Re: [PATCH] {master} Extend, fix and improve tests on Lex and Yacc support.)

2010-12-18 Thread Stefano Lattarini
On Saturday 18 December 2010, Ralf Wildenhues wrote: > [MEGA CUT] > > > > > > # Don't redefine several times the same variable. > > > > > > -cp Makefile.am Makefile.src > > > > > > +cp -f Makefile.am Makefile.src > > > > > > > > > > Why should you need this change? Generally, I don't see why you

Re: [PATCH] {master} Extend, fix and improve tests on Lex and Yacc support.

2010-12-17 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Fri, Dec 17, 2010 at 03:33:32PM CET: > On Friday 17 December 2010, Ralf Wildenhues wrote: > > > > The *current* tests are good enough for the current code. > > > Yes, but not enough if we plan to modify that code You can add tests as you go modifying the code. Doing

Re: [PATCH] {master} Extend, fix and improve tests on Lex and Yacc support.

2010-12-17 Thread Stefano Lattarini
Hi Ralf. I still have one question (about `cp -f', see the end of the mail); I will push once it's addressed ... On Friday 17 December 2010, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Thu, Dec 16, 2010 at 10:10:29PM CET: > > On Thursday 16 December 2010, Ralf Wildenhues wrote: > > > >

Re: [PATCH] {master} Extend, fix and improve tests on Lex and Yacc support.

2010-12-16 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Thu, Dec 16, 2010 at 10:10:29PM CET: > On Thursday 16 December 2010, Ralf Wildenhues wrote: > > > > BTW, notice that I'm planning to further extend the Lex/Yacc tests > > > and make them more "semantic", but that should be better done in a > > > follow-up patch IMVHO.

Re: [PATCH] {master} Extend, fix and improve tests on Lex and Yacc support.

2010-12-16 Thread Stefano Lattarini
On Thursday 16 December 2010, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Mon, Dec 13, 2010 at 07:54:05PM CET: > > OK to apply to a temporary branch off of maint, and merge to master? > > The patch is ok with nits addressed. > I've addressed almost all of them, but I have a doubt about o

Re: [PATCH] {master} Extend, fix and improve tests on Lex and Yacc support.

2010-12-16 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Mon, Dec 13, 2010 at 07:54:05PM CET: > OK to apply to a temporary branch off of maint, and merge to master? The patch is ok with nits addressed. > BTW, notice that I'm planning to further extend the Lex/Yacc tests > and make them more "semantic", but that should be be

[PATCH] {master} Extend, fix and improve tests on Lex and Yacc support.

2010-12-13 Thread Stefano Lattarini
Hello automakers. This is a reproposal of an older patch of mine: I've rebased the patch on current maint, and thrown in a couple of fixes/improvements (in particular, I've renamed the new test `yacc1.test' to the more pr