Hi again,
On Mon, Jun 20, 2011 at 10:33, Stefano Lattarini
wrote:
> On Friday 17 June 2011, Stefano Lattarini wrote:
>> Hi Bert, and thanks again for your patch.
>>
>> I have some minor observations and objections below (please do not take
>> them as a belittling of your work; they are either con
* Ralf Wildenhues wrote on Mon, Jun 20, 2011 at 10:29:02PM CEST:
> * Stefano Lattarini wrote on Mon, Jun 20, 2011 at 10:33:53AM CEST:
> > +# Prefix each line by 'col' and terminate each with 'std', for coloring.
> > +# Multi line coloring is problematic with "less -R", so we really need
> > +# to c
* Stefano Lattarini wrote on Mon, Jun 20, 2011 at 10:33:53AM CEST:
> OK, I've amended the patch on Bert's behalf, as he can't do that himself
> at the moment. Attached is what I've pushed (to maint).
Thanks for handling this, and to Bert for the report and patch!
Minor nit:
> --- a/lib/am/check
27;ve pushed (to maint).
Regards,
Stefano
From b8c2b69913b652bcfd4665b041f11d8b5316da2b Mon Sep 17 00:00:00 2001
Message-Id:
From: Bert Wesarg
Date: Fri, 17 Jun 2011 21:59:52 +0200
Subject: [PATCH] check: don't use multi-line coloring for the report
"less -R" can't handle multi-line coloring as
Hi Bert, and thanks again for your patch.
I have some minor observations and objections below (please do not take
them as a belittling of your work; they are either constructive criticism,
or requests for cosmetic changes mandated by the GNU coding standards).
I hope you have time and will to addr
less -R can't handle multi-line coloring as it is done for the check reports
of the serial and parallel testsuite, because of performance reasons. Thus,
color each line of the check report by its own.
---
ChangeLog |9 +
THANKS |1 +
lib/am/check.am | 40 ++
Hi,
On Fri, Jun 17, 2011 at 17:12, Stefano Lattarini
wrote:
> Hi Bert, and thanks for persiting on this.
only for today, I'm in vacation for the next two weeks ;-) But I try
to post a patch today.
> You could avoid the use of printf above by using the "automatic concatenation"
> feature of awk:
Hi Bert, and thanks for persiting on this.
On Friday 17 June 2011, Bert Wesarg wrote:
> On Thu, Jun 16, 2011 at 22:00, Ralf Wildenhues wrote:
> > Hello,
> >
> > * Bert Wesarg wrote on Thu, Jun 16, 2011 at 08:19:23PM CEST:
> >> the parallel part is a little trickier. Because the line printing is
>
On Thu, Jun 16, 2011 at 22:00, Ralf Wildenhues wrote:
> Hello,
>
> * Bert Wesarg wrote on Thu, Jun 16, 2011 at 08:19:23PM CEST:
>> the parallel part is a little trickier. Because the line printing is
>> done by awk. I would like to know, whether it is portable to use the
>> printf function of awk.
Hello,
* Bert Wesarg wrote on Thu, Jun 16, 2011 at 08:19:23PM CEST:
> the parallel part is a little trickier. Because the line printing is
> done by awk. I would like to know, whether it is portable to use the
> printf function of awk. It is POSIX, but you may know that this
> doesn't count much.
Hi,
the parallel part is a little trickier. Because the line printing is
done by awk. I would like to know, whether it is portable to use the
printf function of awk. It is POSIX, but you may know that this
doesn't count much. I couldn't find any prior usage in automake and
autoconf either. Nor doe
On Thu, Jun 16, 2011 at 09:41, Stefano Lattarini
wrote:
> I verified that the problem you reported is really present, and
> I agree it would be nice to fix it.
>
> However, your patch fixes the problem only fot the old "serial"
> testsuite harness, not for the new "parallel" one. It would be
> ni
On Thursday 16 June 2011, Bert Wesarg wrote:
> On Thu, Jun 16, 2011 at 09:41, Stefano Lattarini
> wrote:
> > I verified that the problem you reported is really present, and
> > I agree it would be nice to fix it.
> >
> > However, your patch fixes the problem only fot the old "serial"
> > testsuite
Hi Bert, thanks for the patch.
On Thursday 16 June 2011, Bert Wesarg wrote:
> less can't handle coloring which spans newlines because of performance
> reasons. Thus, color each line of the check report by its own.
>
> ---
>
> For reference, git had a similar problem and I talked to the less
> ma
less can't handle coloring which spans newlines because of performance
reasons. Thus, color each line of the check report by its own.
---
For reference, git had a similar problem and I talked to the less
maintainer about the problem. Here is the resulting fix in git:
http://repo.or.cz/w/git.git/
15 matches
Mail list logo
