Re: [PATCH] tests: avoid one last `...` command substitution in 'test-init.sh'

2012-06-24 Thread Stefano Lattarini
On 06/23/2012 08:23 PM, Dave Hart wrote: > On Fri, Jun 22, 2012 at 10:13 PM, Stefano Lattarini > wrote: >> * t/ax/test-init.sh (me): In the definition of this variable. This >> also shave off a couple of forks, and the need for a sanity check > > s/shave/shaves/ > s/and the/and removes the/ > >

Re: [PATCH] tests: avoid one last `...` command substitution in 'test-init.sh'

2012-06-23 Thread Dave Hart
On Fri, Jun 22, 2012 at 10:13 PM, Stefano Lattarini wrote: > * t/ax/test-init.sh (me): In the definition of this variable.  This > also shave off a couple of forks, and the need for a sanity check s/shave/shaves/ s/and the/and removes the/ Otherwise, it looks good. Cheers, Dave Hart

Re: [PATCH] tests: avoid one last `...` command substitution in 'test-init.sh'

2012-06-22 Thread Eric Blake
On 06/22/2012 04:28 PM, Stefano Lattarini wrote: >>> - # Guard against failure to spawn sed (seen on MSYS), or empty $argv0. >>> - me=`echo "$argv0" | sed -e 's,.*[\\/],,;s/\.sh$//;s/\.tap$//'` \ >>> -&& test -n "$me" \ >>> -|| { echo "$argv0: failed to define \$me" >&2; exit 99; } >>> +

Re: [PATCH] tests: avoid one last `...` command substitution in 'test-init.sh'

2012-06-22 Thread Stefano Lattarini
Hi Eric. On 06/23/2012 12:17 AM, Eric Blake wrote: > On 06/22/2012 04:13 PM, Stefano Lattarini wrote: >> * t/ax/test-init.sh (me): In the definition of this variable. This >> also shave off a couple of forks, and the need for a sanity check >> only required in fringe situations. >> >> Signed-off-

Re: [PATCH] tests: avoid one last `...` command substitution in 'test-init.sh'

2012-06-22 Thread Eric Blake
On 06/22/2012 04:13 PM, Stefano Lattarini wrote: > * t/ax/test-init.sh (me): In the definition of this variable. This > also shave off a couple of forks, and the need for a sanity check > only required in fringe situations. > > Signed-off-by: Stefano Lattarini > --- > t/ax/test-init.sh | 11 +

[PATCH] tests: avoid one last `...` command substitution in 'test-init.sh'

2012-06-22 Thread Stefano Lattarini
* t/ax/test-init.sh (me): In the definition of this variable. This also shave off a couple of forks, and the need for a sanity check only required in fringe situations. Signed-off-by: Stefano Lattarini --- t/ax/test-init.sh | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) di