Re: [PATCHES] Bootstrap: Allow user overriding of $AUTOCONF and $PERL.

2010-08-08 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 12:53:21PM CEST: At Sunday 08 August 2010, Ralf Wildenhues wrote: Also, regenerating the tree with Autoconf 2.67 and committing that separately is preapproved for maint. Couldn't this cause problems when later merging to master? If yes,

on merging patches (was: [PATCHES] Bootstrap: Allow user overriding of $AUTOCONF and $PERL.)

2010-08-08 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 12:53:21PM CEST: At Sunday 08 August 2010, Ralf Wildenhues wrote: Fine with me. If you have all your patches in branches Yes, a branch for every patch (series). or otherwise ordered, you can also just wait until I'm done reviewing and

Re: [PATCHES] Bootstrap: Allow user overriding of $AUTOCONF and $PERL.

2010-08-08 Thread Stefano Lattarini
At Sunday 08 August 2010, Ralf Wildenhues wrote: * Stefano Lattarini wrote on Sun, Aug 08, 2010 at 12:09:52PM CEST: I squashed the following into the first patch: It's OK for you? Sure. (BTW, if my understanding is correct, this would make a nice addition to HACKING, too).

Re: [PATCHES] Bootstrap: Allow user overriding of $AUTOCONF and $PERL.

2010-08-08 Thread Ralf Wildenhues
[ the gnu list server seems down ATM; expect delays ] Hi Stefano, * Stefano Lattarini wrote on Wed, Jul 28, 2010 at 11:07:20AM CEST: At Wednesday 28 July 2010, Ralf Wildenhues wrote: But even then, when developing Automake you will need to be extra careful to never let autoconf be invoked

Re: [PATCHES] Bootstrap: Allow user overriding of $AUTOCONF and $PERL.

2010-07-28 Thread Stefano Lattarini
At Wednesday 28 July 2010, Ralf Wildenhues wrote: Hello Stefano, * Stefano Lattarini wrote on Tue, Jul 27, 2010 at 10:58:24PM CEST: Subject: [PATCH 1/2] Bootstrap: let the user choose which autoconf to use. Well, you should change +AUTOCONF=${AUTOCONF-autoconf} to :

[PATCHES] Bootstrap: Allow user overriding of $AUTOCONF and $PERL.

2010-07-27 Thread Stefano Lattarini
Separated in two patches for easier cherry-picking. For maint. Regards, Stefano -*-*- Subject: [PATCH 1/2] Bootstrap: let the user choose which autoconf to use. * bootstrap ($AUTOCONF): New variable, from the environment. Use it instead of calling autoconf directly. --- ChangeLog |6

Re: [PATCHES] Bootstrap: Allow user overriding of $AUTOCONF and $PERL.

2010-07-27 Thread Eric Blake
On 07/27/2010 02:58 PM, Stefano Lattarini wrote: +# Let user choose which version of autoconf to use. +AUTOCONF=${AUTOCONF-autoconf} + I'm used to this variant, with less typing: : ${AUTOCONF=autoconf} But your way works, too. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt

Re: [PATCHES] Bootstrap: Allow user overriding of $AUTOCONF and $PERL.

2010-07-27 Thread Eric Blake
On 07/27/2010 03:08 PM, Eric Blake wrote: On 07/27/2010 02:58 PM, Stefano Lattarini wrote: +# Let user choose which version of autoconf to use. +AUTOCONF=${AUTOCONF-autoconf} + I'm used to this variant, with less typing: : ${AUTOCONF=autoconf} But your way works, too. Huh, I just

Re: [PATCHES] Bootstrap: Allow user overriding of $AUTOCONF and $PERL.

2010-07-27 Thread Stefano Lattarini
Hi Eric. At Tuesday 27 July 2010, Eric Blake wrote: On 07/27/2010 03:08 PM, Eric Blake wrote: On 07/27/2010 02:58 PM, Stefano Lattarini wrote: +# Let user choose which version of autoconf to use. +AUTOCONF=${AUTOCONF-autoconf} + I'm used to this variant, with less typing: :

Re: [PATCHES] Bootstrap: Allow user overriding of $AUTOCONF and $PERL.

2010-07-27 Thread Eric Blake
On 07/27/2010 03:37 PM, Stefano Lattarini wrote: I'm used to this variant, with less typing: : ${AUTOCONF=autoconf} But your way works, too. Can you confirm it's as portable as the ways suggested in the autoconf manual? If yes, do you think it could be an useful addition to that manual?