Avoid possible false negatives in canon-name.test (by enabling `set -e'). * tests/canon-name.test: Enable shell `errexit' flag (and bumped copyright years). Due to this change, the testcase should now fail on unexpected failures of aclocal, and on failures in grepping the expected diagnostic in automake stderr.
No portability problems should be introduced, since the test script uses only simple commands and a call to the `AUTOMAKE_fails' shell function, which calls `Exit 1' on unexpected $AUTOMAKE success (thus avoiding the possibility of false negatives), and returns with a status of `0' otherwise (thus avoiding the possibility of false positives).
From 31e6009bbe153c04f7d4fa6985364109db0dda05 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini <stefano.lattar...@gmail.com> Date: Thu, 8 Apr 2010 18:30:29 +0200 Subject: [PATCH 1/2] Avoid possible false negatives in canon-name.test. * tests/canon-name.test: Enable shell `errexit' flag (and bumped copyright years). Due to this change, the testcase should now fail on unexpected failures of aclocal, and on failures in grepping the expected diagnostic in automake stderr. --- ChangeLog | 8 ++++++++ tests/canon-name.test | 4 +++- 2 files changed, 11 insertions(+), 1 deletions(-) diff --git a/ChangeLog b/ChangeLog index 19b7772..93beab5 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2010-04-12 Stefano Lattarini <stefano.lattar...@gmail.com> + + Avoid possible false negatives in canon-name.test. + * tests/canon-name.test: Enable shell `errexit' flag (and bumped + copyright years). Due to this change, the testcase should now + fail on unexpected failures of aclocal, and on failures in grepping + the expected diagnostic in automake stderr. + 2010-04-11 Ralf Wildenhues <ralf.wildenh...@gmx.de> Fix per-Makefile.am setting of -Werror. diff --git a/tests/canon-name.test b/tests/canon-name.test index 50a4dff..7f9febb 100755 --- a/tests/canon-name.test +++ b/tests/canon-name.test @@ -1,5 +1,5 @@ #! /bin/sh -# Copyright (C) 2007 Free Software Foundation, Inc. +# Copyright (C) 2007, 2010 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -18,6 +18,8 @@ . ./defs || Exit 1 +set -e + cat > configure.in << 'END' AC_INIT([canon-name], [1.0]) AM_INIT_AUTOMAKE -- 1.6.5
