Re: Implementing notrans_man_MANS

2008-03-12 Thread Peter Breitenlohner
On Tue, 11 Mar 2008, Ralf Wildenhues wrote: Having one test is fine, and it looks good, too. I suppose we might want to change the MANS line and the install-manX rules to be flattened, they already look pretty ugly in the Makefile. But that can happen in a followup patch. Hello Ralf, I guess

Re: Implementing notrans_man_MANS

2008-03-11 Thread Ralf Wildenhues
Hello Peter, * Peter Breitenlohner wrote on Mon, Mar 10, 2008 at 01:26:08PM CET: > > [...] I can only use if/endif if/endif and not if/else/endif > because a section may have trans_ as well as notrans_ man pages. Ah yes, sure. > Attached are revised versions of the three patches. I hope they tak

Re: Implementing notrans_man_MANS

2008-03-10 Thread Peter Breitenlohner
On Thu, 6 Mar 2008, Ralf Wildenhues wrote: * Peter Breitenlohner wrote on Thu, Mar 06, 2008 at 01:27:05PM CET: or still something else. If so please indicate what. Oh sorry, I was in a hurry and not thinking. What I meant was that while you can't wrap arbitrary lines ending in backslash-newl

Re: Implementing notrans_man_MANS

2008-03-06 Thread Ralf Wildenhues
* Peter Breitenlohner wrote on Thu, Mar 06, 2008 at 01:27:05PM CET: > On Thu, 6 Mar 2008, Ralf Wildenhues wrote: > Also, the whole thing would probably be a lot more readable if the ?NOTR?/?DOTR? prefixes vanished and were replaced by full rules, wrapped in `if %?NOTRANS_MANS%'. Tha

Re: Implementing notrans_man_MANS

2008-03-06 Thread Peter Breitenlohner
On Thu, 6 Mar 2008, Ralf Wildenhues wrote: Also, the whole thing would probably be a lot more readable if the ?NOTR?/?DOTR? prefixes vanished and were replaced by full rules, wrapped in `if %?NOTRANS_MANS%'. That would be a better name for NOTR, and since it would then only appear a couple of t

Re: Implementing notrans_man_MANS

2008-03-06 Thread Ralf Wildenhues
Hi Peter, * Peter Breitenlohner wrote on Thu, Mar 06, 2008 at 10:43:20AM CET: > On Wed, 5 Mar 2008, Ralf Wildenhues wrote: > >> This triple loop is already at 72 iterations. Not good for performance. >> If this grows further, we may have to access variables in a different >> manner here. > > I as

Re: Implementing notrans_man_MANS

2008-03-06 Thread Peter Breitenlohner
On Wed, 5 Mar 2008, Ralf Wildenhues wrote: Well, here's a review of your patches. If you have time to address the comments, that would be great, otherwise I will eventually do it. Hi Ralf, I will go through your comments and think most of them pose no problem. For the moment just a few remar

Re: Implementing notrans_man_MANS

2008-03-05 Thread Ralf Wildenhues
Hello Peter, * Peter Breitenlohner wrote on Wed, Feb 20, 2008 at 02:20:04PM CET: > > attached are five patches (the diffs are actually against the result of > applying your patch for PR 516 from 2008-01-22): Thanks for your work in this, and sorry for the delay. I saw that your paperwork is now

Re: Implementing notrans_man_MANS

2008-02-20 Thread Peter Breitenlohner
On Tue, 19 Feb 2008, Ralf Wildenhues wrote: How should I proceed, once all that is finished? Email to you and/or automake bugzilla? automake-patches@gnu.org is best. Are unified diffs against the autoamke-1.10.1 tarball OK? Yes. What about re-indenting existing code? Please as a separa