Re: cond5.test spurious failure

2010-08-06 Thread Peter Rosin
Hi Stefano, Den 2010-08-06 13:54 skrev Stefano Lattarini: At Friday 06 August 2010, Peter Rosin wrote: [CUT] I did get a spurious failure in cond5.test, but it went away when I ran it separately. Did you by chance run many tests in parallel? If yes, you might have hit a known issue: The

Re: cond5.test spurious failure

2010-08-06 Thread Stefano Lattarini
At Friday 06 August 2010, Peter Rosin wrote: Hi Stefano, Den 2010-08-06 13:54 skrev Stefano Lattarini: At Friday 06 August 2010, Peter Rosin wrote: [CUT] I was not running in parallel and I was running off of the msvc branch (basically maint I think) plus the commit in the previous

Re: cond5.test spurious failure

2010-08-06 Thread Peter Rosin
Den 2010-08-06 15:56 skrev Peter Rosin: kill success: === Running test ./tmp.test ++ pwd /home/peda/automake/git/automake/tests/tmp.dir + set -e + cat + cat + sh -c 'echo %aclocal pid: $$; sleep 2' %aclocal pid: 12228 + pid=13504 + sh -c 'echo %automake pid: $$; sleep 4; echo variable OPT_SRC

Re: cond5.test spurious failure

2010-08-06 Thread Peter Rosin
Den 2010-08-06 15:15 skrev Stefano Lattarini: To help us pinpoint the problem, could you please try to run the attached fake test scripts multiple times, and post the outputs? Please forgive me the for the ugliness of such scripts, but I'm just taking wild guesses here. For tmp.test, I swapped

[PATCH] Remove a race condition from test cond5.test (was: cond5.test spurious failure)

2010-08-06 Thread Stefano Lattarini
Peter, thanks for your analysis. So it seems a bug in the kill builtin of the MSYS shell after all, just like you suggested. At Friday 06 August 2010, Peter Rosin wrote: [CUT] tmp3.test always works, but takes different branches depending on if kill worked or not. kill failure: ===

Re: cond5.test spurious failure

2010-08-06 Thread Peter Rosin
Den 2010-08-06 15:15 skrev Stefano Lattarini: At Friday 06 August 2010, Peter Rosin wrote: Hi Stefano, Den 2010-08-06 13:54 skrev Stefano Lattarini: At Friday 06 August 2010, Peter Rosin wrote: [CUT] I was not running in parallel and I was running off of the msvc branch (basically maint I

Re: cond5.test spurious failure

2010-08-06 Thread Stefano Lattarini
Hi Peter. It seems our patches crossed... At Friday 06 August 2010, Peter Rosin wrote: As seen above, kill seems to always work once it starts to work, so I tried to insert a sleep before the first kill. That fixes it. I have 10+ consecutive successes, no fails. Please apply this on top of

Re: cond5.test spurious failure

2010-08-06 Thread Ralf Wildenhues
* Peter Rosin wrote on Fri, Aug 06, 2010 at 04:11:20PM CEST: Please apply this on top of maint: Thanks, done. You can make us even happier if you submit patches with git format-patch $ref where $ref is the starting point you're basing on. I don't care whether you attach the files or send

Re: cond5.test spurious failure

2010-08-06 Thread Stefano Lattarini
At Friday 06 August 2010, Ralf Wildenhues wrote: * Peter Rosin wrote on Fri, Aug 06, 2010 at 04:11:20PM CEST: Please apply this on top of maint: Thanks, done. You can make us even happier if you submit patches with git format-patch $ref where $ref is the starting point you're basing on.

Re: cond5.test spurious failure

2010-08-06 Thread Peter Rosin
Hi Stefano, Den 2010-08-06 20:52 skrev Stefano Lattarini: At Friday 06 August 2010, Ralf Wildenhues wrote: Stefano, sorry for not taking your patch; I saw Peter's earlier and had good success testing it on MinGW; also, I think it is easier to understand than yours. Hope you don't mind.

Re: cond5.test spurious failure

2010-08-06 Thread Stefano Lattarini
At Friday 06 August 2010, Peter Rosin wrote: Hi Stefano, FWIW, your patch worked 10+ times in a row for me, and no fails. I personally don't care which patch eventually makes it... It seems it has been your one ;-). No big deal for me, either, and thanks for the testing. Regards,