Re: [PATCH] Testsuite now works with BSD make in parallel mode.

Hi Stefano, * Stefano Lattarini wrote on Thu, Jun 10, 2010 at 11:21:26PM CEST: > * tests/defs.in: Unset variables __MKLVL__ and MAKE_JOBS_FIFO, > which are exported by BSD make when run in parallel mode, and > which can confuse make processes spawned by our testsuite. > This change fixes a lot of

Re: [PATCH] Minor improvements in bootstrap script.

* Stefano Lattarini wrote on Thu, Jun 10, 2010 at 08:48:51PM CEST: > At Thursday 10 June 2010, Ralf Wildenhues wrote: > > Yes. The changes are ok if you split the patch into one purely > > without semantic changes, and the rest (so that we don't need to > > revert the fo

Re: [PATCH] Extend tests/README (trailing `:' in test scripts)

Hi Stefano, * Stefano Lattarini wrote on Fri, Jun 11, 2010 at 12:42:24PM CEST: > OK to apply this patch to tests/README? I think the original one has > fallen off your radar (in fact I posted it in quite an inappropriate > place, see below). It has indeed fallen off my radar, unlike some others.

pushing patches (was: [PATCH] Extend tests/README (trailing `:' in test scripts))

Hi Stefano, * Stefano Lattarini wrote on Fri, Jun 11, 2010 at 12:42:24PM CEST: > OK to apply this patch to tests/README? [...] Speaking of "OK to apply", would you prefer pushing approved patches yourself? If yes, please apply as project member on

Re: [PATCH] Enable `errexit' shell flag in various tests (again).

Hi Stefano, * Stefano Lattarini wrote on Fri, Jun 11, 2010 at 05:30:57PM CEST: > Enable `errexit' shell flag in various tests. > > * tests/backsl.test: Enable the `errexit' shell flag, and > related changes. > * tests/backsl2.test: Likewise. > * tests/block.test: Likewise. > * tests/canon2.test:

Re: [PATCH] Testsuite: ensure verbose printing of captured stderr.

Hi Stefano, * Stefano Lattarini wrote on Fri, Jun 11, 2010 at 09:22:40PM CEST: > * tests/acloca18.test: Print captured stderr before either failing > or grepping it. Be sure to send captured stderr to stderr, not to > stdout. > * tests/ansi3b.test: Likewise. > * tests/cond39.test: Likewise. > * t

Re: [PATCH] Modernize, improve and/or fix tests `pluseq*.test.

Hi Stefano, * Stefano Lattarini wrote on Fri, Jun 11, 2010 at 05:35:58PM CEST: > Modernize, improve and/or fix tests `pluseq*.test. > > * tests/pluseq5.test: Append to configure.in using cat with an > here-doc, not using echo. > * tests/pluseq10.test: Make sure that the captured output of > `make

the branch a patch is for (was: [PATCH] Testsuite: ensure verbose printing of captured stderr.)

* Stefano Lattarini wrote on Sat, Jun 12, 2010 at 01:36:01PM CEST: > At Saturday 12 June 2010, Ralf Wildenhues wrote: > > This is ok for maint, except that cscope.test does not exist on > > maint. I folded the patch below into it, committed on maint, and > > commited

Re: [PATCH] Modernize, improve and/or fix various test scripts (again)

Hi Stefano, * Stefano Lattarini wrote on Thu, Jun 10, 2010 at 12:43:41AM CEST: > Again, this might seem huge, but most changes are trivial and/or > similar one to the others. > And having all these tweakings packed in a big lump should make their > reviewing easier IMHO (at least, it shouldn't mak

Re: [PATCHES] Minor cleanup and/or cosmetic patches for the testsuite.

Hi Stefano, * Stefano Lattarini wrote on Sat, Jun 12, 2010 at 07:16:02PM CEST: > Here I present four simple patches that were originally part of my > patch series on the refactoring of 'tests/defs'. But they are mostly > indipendent from that series, which (by the way) is already growing > way

Re: [PATCHES] Minor cleanup and/or cosmetic patches for the testsuite.

* Stefano Lattarini wrote on Sat, Jun 12, 2010 at 08:35:56PM CEST: > At Saturday 12 June 2010, Stefano Lattarini wrote: > > At Saturday 12 June 2010, Ralf Wildenhues wrote: > > > patch 4 is not, because it will do the wrong thing with, say, > > > AUTOUPDATE='autoup

Re: pr-msvc-support merge

[ adding automake-patches; this is http://thread.gmane.org/gmane.comp.gnu.libtool.general/10927/focus=10954 ] * Peter Rosin wrote on Mon, Jun 14, 2010 at 09:35:45AM CEST: > Den 2010-06-12 10:05 skrev Ralf Wildenhues: > >Well, I sort of figured that the 'compile' script cou

Re: pr-msvc-support merge

Hello Peter, let's cut the libtool list from replies, ok? * Peter Rosin wrote on Wed, Jun 16, 2010 at 02:30:47PM CEST: > Den 2010-06-14 22:40 skrev Ralf Wildenhues: > >* Peter Rosin wrote on Mon, Jun 14, 2010 at 09:35:45AM CEST: > Running the tests are still an outright pain t

Re: [PATCH] New tests on obsoleted usages of automake/autoconf macros.

Hi Stefano, * Stefano Lattarini wrote on Sat, Jun 12, 2010 at 11:31:57PM CEST: > New tests on obsoleted usages of automake/autoconf macros (as > AC_INIT, AM_INIT_AUTOMAKE and AC_OUTPUT). I have some detail questions about these tests, below. Thanks for working on them! Cheers, Ralf > --- /dev/n

Re: [PATCH] Add useful comment in test script ext.test.

* Stefano Lattarini wrote on Sun, Jun 13, 2010 at 10:40:22PM CEST: > Another cosmetic change adding an IMHO useful comment to an idiom in a > test script. Thanks! For maint. Ralf > * tests/ext.test: Add a comment explaining why an apparently > useless `if' statement is indeed required.

Re: [PATCH] Modernize, improve and/or extend tests `colon*.test.

* Stefano Lattarini wrote on Sat, Jun 12, 2010 at 11:48:15PM CEST: > Another patch tweaking scripts in the testsuite. Thanks, most of this is uncontroversial, but a couple of things I don't understand: > --- a/tests/colon3.test > +++ b/tests/colon3.test > @@ -1,6 +1,6 @@ > #! /bin/sh > -# Copyri

Re: pr-msvc-support merge

* Peter Rosin wrote on Wed, Jun 16, 2010 at 10:30:22PM CEST: > Den 2010-06-16 20:57 skrev Ralf Wildenhues: > >This explanation of yours lends itself nicely to a testsuite addition > >that exercises the 'compile' script (no need to go through Autoconf or > >Automak

Re: [PATCH] Fix code for requiring gfortran and g77 in tests.

Hi Stefano, * Stefano Lattarini wrote on Sun, Jun 13, 2010 at 10:03:33PM CEST: > Another improvements to 'tests/defs', factored out from my on-going > refactoring of test scripts setup. This time it is (should be) a real > improvement, not just a cosmetic one. I see your point, but do you have

Re: [PATCH] Modernize, improve and extend tests `suffix*.test'.

* Stefano Lattarini wrote on Sat, Jun 19, 2010 at 10:47:10PM CEST: > Yet another testsuite-tweaking patch (the last one for today). > Modernize, improve and extend tests `suffix*.test'. > > * tests/suffix3.test: Enable `errexit' shell flag, and related > changes. > * tests/suffix4.test: Likewise.

Re: [PATCH] New test: distributed broken symlinks cause failure.

* Stefano Lattarini wrote on Sat, Jun 19, 2010 at 09:53:17PM CEST: > I ping this again, since I'm pretty sure it has fallen off your radar. > > I say so because, since the last ping, you have applied (or at least > commented) much bigger and potentially more invasive patches of mine, > but not t

Re: [PATCH 0/2] Bugfix w.r.t. $(AM_LFLAGS)/$(LFLAGS) and $(AM_YFLAGS)/$(YFLAGS) precedence.

Hi Stefano, I'm falling more and more behind on patches, it seems. * Stefano Lattarini wrote on Sat, May 01, 2010 at 10:33:46AM CEST: > The Automake manual states in: > > http://www.gnu.org/software/automake/manual/html_node/Flag-Variables-Ordering.html > (and the good sense dictates) that all

Re: [PATCH] New test: distributed broken symlinks cause failure.

Hi Stefano, * Stefano Lattarini wrote on Sun, Jun 20, 2010 at 10:27:26PM CEST: > At Sunday 20 June 2010, Ralf Wildenhues wrote: > > The test doesn't look safe for MinGW. Its 'ln -s' is emulated by > > 'cp -p' which, from looking at the test, will cause a

Re: [PATCH 1/3] Refactor and extend tests on cscope functionality.

Hi Stefano, * Stefano Lattarini wrote on Sat, Jun 19, 2010 at 05:04:22PM CEST: > * tests/cscope.test: Improve and normalize generation and names > of source files. > Do not use hackish, belated SKIPs anymore. > Slighty extend existing tests. > (configure.in): Do not call macro `AM_PROG_GCJ' anymor

Re: [PATCH] Fix code for requiring gfortran and g77 in tests.

* Stefano Lattarini wrote on Sun, Jun 20, 2010 at 11:07:01PM CEST: > At Sunday 20 June 2010, Ralf Wildenhues wrote: > > * Stefano Lattarini wrote on Sun, Jun 13, 2010 at 10:03:33PM CEST: > > > Another improvements to 'tests/defs', factored out from my > > >

Re: pr-msvc-support merge

* Peter Rosin wrote on Mon, Jun 21, 2010 at 10:07:19AM CEST: > I have now run the test-suite once without the patch and once with > the patch. There was only one difference (that seem totally > unrelated). When I run that test by itself it behaves the same both > with and without the patch so I'll

Re: pr-msvc-support merge

* Peter Rosin wrote on Tue, Jun 22, 2010 at 01:53:49PM CEST: > Den 2010-06-22 05:38 skrev Charles Wilson: > >What if $CC is specified as 'cl.exe'? IIUC, this means that the compile > >script will be invoked as "compile cl.exe " but then this case: > > > >+ cl | *[/\\]cl) > >+func_cl_wrappe

Re: [PATCH 0/2] Bugfix w.r.t. $(AM_LFLAGS)/$(LFLAGS) and $(AM_YFLAGS)/$(YFLAGS) precedence.

* Stefano Lattarini wrote on Tue, Jun 22, 2010 at 01:15:04PM CEST: > At Monday 21 June 2010, Ralf Wildenhues wrote: > > I'm falling more and more behind on patches, it seems. > In this last period, it seems quite the opposite to me :-) > Thanks for your work! You've don

Re: [PATCH] Fix bugs in test script silent5.test.

Hi Stefano, * Stefano Lattarini wrote on Wed, Jun 23, 2010 at 10:01:26PM CEST: > This tiny patch fix a nasty bug in 'silent5.test' (due to the use of > grep instead of egrep) that could have lead to false negatives. > > The bug was introduced in one of my previous patches ("Improved test > sile

Re: [PATCH 0/2] Bugfix w.r.t. $(AM_LFLAGS)/$(LFLAGS) and $(AM_YFLAGS)/$(YFLAGS) precedence.

* Stefano Lattarini wrote on Wed, Jun 23, 2010 at 03:28:59PM CEST: > At Monday 21 June 2010, Ralf Wildenhues wrote: > > I'm putting them in a new branch off of maint, and adding the > > following patch below to fix a couple of nits in them. > > I'm merging the

Re: [PATCH] Improve and extend test cond5.test.

* Stefano Lattarini wrote on Wed, Jun 23, 2010 at 03:04:07PM CEST: > May I ping this? If you think the patch is OK, I'd like to see it > applied, since at present I'm continuing to experience annoying > spurious failures in cond5.test. Thanks for the reminder. Yes, the patch looks good for mai

Re: [PATCH] Improve and extend test cond5.test.

* Stefano Lattarini wrote on Thu, Jun 24, 2010 at 10:32:02PM CEST: > At Thursday 24 June 2010, Ralf Wildenhues wrote: > > Do you have an old system? > Well, it's not new :-) > > $ cat /proc/cpuinfo > model name : AMD Athlon(tm) XP 1800+ > $ free | awk 

Re: [PATCH] Drop useless requirement "gzip" in lex5.test.

* Stefano Lattarini wrote on Fri, Jun 25, 2010 at 05:32:56PM CEST: > * tests/lex5.test ($required): Do not list "gzip", as it's > never used. Thanks! For maint. Cheers, Ralf

Re: [PATCH] Tests: remove useless repetitions of `foreign' automake option.

Hi Stefano, * Stefano Lattarini wrote on Fri, Jun 25, 2010 at 05:22:19PM CEST: > A minor cleanup patch for the testsuite. Should cause no semantic > change whatsoever. Yes, but ... > Tests: remove useless repetitions of `foreign' automake option. > > * multlib.test (configure.in): Remove usel

Re: [PATCH] Tests: remove useless repetitions of `foreign' automake option.

* Stefano Lattarini wrote on Sat, Jun 26, 2010 at 01:40:49PM CEST: > At Saturday 26 June 2010, Ralf Wildenhues wrote: > > or is that always just used > > in order to save on generating the GNU-specific files? > This should be the real reason, yes (and is also the reason why >

Re: [PATCH] Fix bugs in test script silent5.test.

* Stefano Lattarini wrote on Sat, Jun 26, 2010 at 02:15:18PM CEST: > + Fix typo-related bug in test script silent5.test. > + * tests/silent5.test: Use $EGREP, not $GREP (which is not even > + defined). Thanks.

Clean up @var handling in the manual.

Similarly to a recent patch for Libtool, this cleans up the Automake manual use of @var. IMHO, the lower-casing really helps the PDF rendering, making metasyntactic variables much easier to detect. Tested make info pdf html, glossed over, committed to maint. Cheers, Ralf Clean up @var handl

Update program --help output to match current GCS.

Similar to a recent patch against Libtool, this gets program behavior updated to match GCS. The autoconf.texi change doesn't actually make the bug reporting address be set from configure.ac, but a factored one is still better than repetitions. Committed to maint. Cheers, Ralf Update program

Re: [PATCH 14/14] Make sure all tests needing gzip require it explicitly.

Hi Stefano, * Stefano Lattarini wrote on Fri, Jul 02, 2010 at 05:23:36PM CEST: > OK, this should have really been the first patch in the series, so let's review it first. > but I > didn't think of it until the series was almost finished, and at that > point I dind't want to risk a rebase with a

Re: pushing patches

; At Saturday 12 June 2010, Ralf Wildenhues wrote: > > Speaking of "OK to apply", would you prefer pushing approved > > patches yourself? If yes, please apply as project member on > > <http://savannah.gnu.org/project/memberlist.php?group=automake> > Done. >

Re: [PATCH 0/6] Lex, Yacc and explicit declarations of dependencies.

Hi Stefano, * Stefano Lattarini wrote on Mon, Jul 05, 2010 at 01:36:03PM CEST: > I rebased the patch series against master to resolve some (really > minor) conflicts; and since I was at it, I updated the ChangeLog to > tell that the bug addressed by this series affects also Solaris 10 > /usr/xp

Re: [PATCH] Improve declaration of dependencies in the testsuite.

Hi Stefano, * Stefano Lattarini wrote on Fri, Jul 02, 2010 at 12:22:39AM CEST: > Ralf Wildenhues wrote: > > I wonder why I can't use > > gmake --assume-old=defs check RECHECK_LOGS= > > to work around this, though. Must be due to the make recursions. > This seems to

where to base patch series off of (was: [PATCH 0/6] Lex, Yacc and explicit declarations of dependencies.)

Hi Stefano, * Stefano Lattarini wrote on Tue, Jul 06, 2010 at 11:36:26AM CEST: > At Tuesday 06 July 2010, Ralf Wildenhues wrote: > > Please give me another week to review the series; > OK; but note that this message wasn't meant to hurry you: if this > change goes in auto

Re: [PATCH + QUESTION] Improve and extend tests `man*.test'.

Hi Stefano, * Stefano Lattarini wrote on Mon, Jul 12, 2010 at 06:04:17PM CEST: > * tests/man7.test: New test, extracted from old man4.test, which > checks for a bug in maintainer-clean w.r.t. generated manpages. > Passes with GNU make and Solaris make, fails with BSD make. it passes for me with f

Re: [QUESTION] Pushing patches.

Hi Stefano, * Stefano Lattarini wrote on Wed, Jul 14, 2010 at 03:51:05PM CEST: > Independently from the fact that you give or not your OK to this > particular patch, I'd like to know if the following procedure is > correct for the pushing of simple patches which should go into > both maint and mas

Re: [QUESTION] Pushing patches.

Hi Stefano, * Stefano Lattarini wrote on Thu, Jul 15, 2010 at 12:26:57PM CEST: [ git-merge-changelog ] > However, there is a problem w.r.t. the Automake policy of keeping > multiple ChangeLog entries with same author and date lumped togheter. > In fact, git-merge-changelog seems to separate them

Re: [QUESTION] Pushing patches.

* Stefano Lattarini wrote on Thu, Jul 15, 2010 at 08:59:17PM CEST: > At Thursday 15 July 2010, Ralf Wildenhues wrote: > > * Stefano Lattarini wrote on Thu, Jul 15, 2010 at 12:26:57PM CEST: > > Bruno prefers the former style, but maybe he accepts a patch to > > optionally

Re: [PATCH] Work around a bug in Solaris make's file-inclusion mechanism.

* Stefano Lattarini wrote on Thu, Jul 15, 2010 at 09:38:28PM CEST: > At Saturday 15 May 2010, Stefano Lattarini wrote: > > [From a thread in bug-autom...@gnu.org] > > [] > > > > Hello Ralf. I went ahead and wrote a patch to apply y

Re: [PATCH] Work around a bug in Solaris make's file-inclusion mechanism.

Hello Dave, Stefano, * Dave Hart wrote on Fri, Jul 16, 2010 at 03:47:53AM CEST: > On Thu, Jul 15, 2010 at 22:59 UTC, Stefano Lattarini wrote: > > At Thursday 15 July 2010, Ralf Wildenhues wrote: > >> No, the patch should not modify initial double slash, that is not > >>

Re: [PATCH] Remove a race condition from test cond5.test.

a more complex but more > correct combo of wrapper script(s) and temporary file(s). > Necessity of this fix suggested by Ralf Wildenhues. > --- a/tests/cond5.test > +++ b/tests/cond5.test > @@ -44,25 +44,42 @@ END > > # The bug is that automake hangs. So we give it an appr

Re: [PATCH] Modernize and improve test scripts `dist*.test'.

Hi Stefano, * Stefano Lattarini wrote on Sat, Jun 19, 2010 at 09:34:34PM CEST: > Yet another testsuite-tweaking patch. OK for maint with nits below addressed. > Modernize and improve test scripts `dist*.test'. > > * tests/distcleancheck.test: Do not add useless `-e' option to > a $MAKE call. E

Re: [PATCH] Modernize and improve test scripts `subdir*.test'.

Hi Stefano, * Stefano Lattarini wrote on Sat, Jun 19, 2010 at 10:15:58PM CEST: > Modernize and improve test scripts `subdir*.test'. > > * tests/subdir.test: Enable `errexit' shell flag, and related > changes. Use the `configure.in' stub created by `./defs', > rather than writing one from scratch

Re: [PATCH] Modernize, improve and/or extend tests `colon*.test.

Hi Stefano, * Stefano Lattarini wrote on Fri, Jun 18, 2010 at 01:25:20PM CEST: > At Thursday 17 June 2010, Ralf Wildenhues wrote: > > Thanks, most of this is uncontroversial, but a couple of things I > > don't understand: > > > --- a/tests/colon3.test > > &

Re: [PATCH] Modernize and improve test scripts `dist*.test'.

* Stefano Lattarini wrote on Wed, Jul 21, 2010 at 09:47:43PM CEST: > At Wednesday 21 July 2010, Ralf Wildenhues wrote: > > * Stefano Lattarini wrote on Sat, Jun 19, 2010 at 09:34:34PM CEST: > > > Yet another testsuite-tweaking patch. > > > > OK for m

Re: [PATCH] Modernize and improve test scripts `subdir*.test'.

* Stefano Lattarini wrote on Wed, Jul 21, 2010 at 11:28:17PM CEST: > Attached are the amended patch (against maint) and the temporary patch > I squashed in the old one (which FYI was against master). > OK to apply? OK for maint, with nits addressed. Thanks, Ralf > --- a/tests/subdir5.test > +++

Re: [PATCH] Modernize and improve test scripts `dist*.test'.

* Stefano Lattarini wrote on Wed, Jul 21, 2010 at 11:48:24PM CEST: > I'll still wait to push, since I'd like to have some more committs in > maint before merging it in master. Agreed? OK. Ralf

unit-testing Automake (was: [PATCH] Modernize, improve and/or extend tests `colon*.test.)

* Stefano Lattarini wrote on Thu, Jul 22, 2010 at 01:04:03AM CEST: > At Wednesday 21 July 2010, Ralf Wildenhues wrote: > > Well, this is a common dilemma in testing: should the tester be > > allowed to use insider information or not? [...] > > Getting the right balance

Re: [PATCH] Fixed typo in ChangeLog (2010-06-06, Stefano Lattarini)

Hi Stefano, * Stefano Lattarini wrote on Sun, Jul 25, 2010 at 11:27:16PM CEST: > Very simple ChangeLog fix. OK to apply to maint? you can just go ahead and apply these kinds of things as obvious. Thanks, Ralf > From 7e1cbc9a026b4a52f78ac28c4ca5853ee8c8bfa6 Mon Sep 17 00:00:00 2001 > From: Stef

Re: [RFC] Refactoring maintainer checks (use perl, add whitelisting)

Hello Stefano, * Stefano Lattarini wrote on Mon, Jul 26, 2010 at 01:58:08PM CEST: > This patch substitutes (almost) all the sed/grep maintainer syntax checks > in `Makefile.am' with a new perl script `maintcheck.pl'. Why? Honest question. perl regex isn't necessarily more readable than sed, in

Coverage: bogus option to AM_INIT_AUTOMAKE.

I'm adding this trivial coverage addition to maint. Cheers, Ralf Coverage: bogus option to AM_INIT_AUTOMAKE. * tests/init2.test: New test. * tests/Makefile.am: Update. diff --git a/tests/Makefile.am b/tests/Makefile.am index 568be8a..4fc4d15 100644 --- a/tests/Makefile.am +++ b/

Avoid syntax error if IF-TRUE part of AM_COND_IF is empty.

Adding this patch to maint to fix the glitch at least for the IF-TRUE case. It's unfortunately not fixable as nicely in the IF-FALSE case since we don't want to override $? there. Cheers, Ralf Avoid syntax error if IF-TRUE part of AM_COND_IF expands empty. * m4/cond-if.m4 (AM_COND_I

Fix AM_COND_IF for gone-invalid condition shell expression.

Fixing this kind of nasty (silent wrong-code) bug, for maint. Hope AM_COND_IF hasn't seen a lot of uses this way yet. Cheers, Ralf Fix AM_COND_IF for gone-invalid condition shell expression. * m4/cond-if.m4 (AM_COND_IF): test contents of $COND_TRUE variable, rather than re-evalua

Document current policy for development with git.

Hi Stefano, all, I've rewritten the HACKING section on development with git a bit to better reflect what I currently think is a good way to go on. Patch for maint. Comments appreciated. FYI, I am waiting for regenerating the in-tree files with Autoconf 2.67 until the official tarballs have come

Re: trivial typo

Hi Patrick, * Patrick Welche wrote on Sat, Jul 10, 2010 at 06:48:30PM CEST: > -Script are not distributed by default; as we have just seen, those > +Scripts are not distributed by default; as we have just seen, those Thanks! Committed to my maint branch, will be pushed out within the next couple

Re: [PATCHES] Bootstrap: Allow user overriding of $AUTOCONF and $PERL.

Hello Stefano, * Stefano Lattarini wrote on Tue, Jul 27, 2010 at 10:58:24PM CEST: > Subject: [PATCH 1/2] Bootstrap: let the user choose which autoconf to > use. Well, you should change > +AUTOCONF=${AUTOCONF-autoconf} to : ${AUTOCONF=autoconf} But even then, when developing Automake you wil

Re: Document current policy for development with git.

Hi Stefano, Eric, thanks for the review! * Stefano Lattarini wrote on Tue, Jul 27, 2010 at 10:34:32PM CEST: > At Tuesday 27 July 2010, Ralf Wildenhues wrote: > > > +* The git tree currently carries a number of branches: master for the > > + current development, and rele

Add more hints for debugging make rules.

Committing the doc update below to maint, for master and branch-1.11. Also, I'm adding you to THANKS, Ludo and Andy, hoping that you'll be providing more help in the near future anyway. ;-) Thanks, Ralf Add more hints for debugging make rules. * doc/automake.texi (Debugging Make Ru

Re: pr-msvc-support merge

Hi Peter, * Peter Rosin wrote on Wed, Jun 23, 2010 at 08:08:08AM CEST: > +2010-06-23 Peter Rosin > + > + Wrap some MSVC options in the compile script. > + * lib/compile: MSVC supports naming the output file, the option > + is just not called -o, so transform -o into the approp

Re: New auxiliary archive script

Hi Peter, * Peter Rosin wrote on Sun, Aug 01, 2010 at 06:54:57PM CEST: > Now we need a something similar for the MS archiver (lib.exe) Right. > As it happens, binutils ar does not work as well as lib, MSVC > sometimes has problems with the archives produced by ar. I > know that I have stated oth

Re: New auxiliary archive script

Hi Peter, thanks for your work on this! * Peter Rosin wrote on Wed, Aug 04, 2010 at 12:14:28PM CEST: > Den 2010-08-01 20:06 skrev Ralf Wildenhues: > >Yes, in principle: when them bugs are fixed. Would you be willing to > >rewrite the script so it > > > >- has

Re: New auxiliary archive script

* Eric Blake wrote on Wed, Aug 04, 2010 at 11:04:29PM CEST: > On 08/04/2010 02:18 PM, Ralf Wildenhues wrote: > >> # strip leading dash in $action > >> case $action in > >> -*) action="${action#-}" ;; > >> esac > > > > The case sta

Re: New auxiliary archive script

* Peter Rosin wrote on Thu, Aug 05, 2010 at 11:10:38AM CEST: > Den 2010-08-04 22:18 skrev Ralf Wildenhues: > >Now if you insist, then maybe we can just find another compromise name. > >Please set $me to the name and use that throughout, so at least a change > >is easil

Re: New auxiliary archive script

* Peter Rosin wrote on Fri, Aug 06, 2010 at 12:00:53AM CEST: > Den 2010-08-01 20:06 skrev Ralf Wildenhues: > >For actual applicability, it is sufficient if you provide a working > >script, post testsuite results with it in place (you might want to > > MAKE='make AR=...

Re: cond5.test spurious failure

* Peter Rosin wrote on Fri, Aug 06, 2010 at 04:11:20PM CEST: > Please apply this on top of maint: Thanks, done. You can make us even happier if you submit patches with git format-patch $ref where $ref is the starting point you're basing on. I don't care whether you attach the files or send th

Re: [PATCH] Fixlets and minor improvements for HACKING.

Hi Stefano, * Stefano Lattarini wrote on Fri, Aug 06, 2010 at 11:50:46AM CEST: > Subject: [PATCH] Fixlets and minor improvements for HACKING. > > * HACKING: Add some missing fullstops in sentences. Remove > some extra empty lines, for consistency. > (Test suite): Add pointer to `tests/README'. >

Re: [PATCH] Work around a nasty bug of Solaris make

* Stefano Lattarini wrote on Fri, Aug 06, 2010 at 01:21:05AM CEST: > At Friday 06 August 2010, Eric Blake wrote: > > You'd need something like: > > done | { tr '\012\015' ' '; echo; } | sed 's/ *$$//' > A little ugly... I prefer to be more explicit and clear, FWIW, I find the above clear and t

Re: New auxiliary archive script

Darn, we need another name: 'archive' is likely too common when automake is going to put all files with that name in the distribution of each package using Automake. No need to send another patch, but any other good suggestions that fit in with the existing scripts? I don't find arlib so bad, exc

Re: [PATCH] Modernize, improve and/or extend tests `colon*.test.

* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 06:06:04PM CEST: > At Sunday 08 August 2010, Ralf Wildenhues wrote: > > No. You save a fork with > > > > foo () > > { > > ... > > foo_result=bar > > } > > > > foo ARG...

Re: [PATCH] Remove a couple of obsoleted tests.

* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 01:29:19PM CEST: > At Sunday 08 August 2010, Ralf Wildenhues wrote: > > Except this would have been caught by "make check" already, so it > > doesn't count as an argument in favor of that patch, right? ;-) >

Re: [PATCH] Minor improvements and fixes in tests `depcomp*.test'.

* Stefano Lattarini wrote on Tue, Jun 22, 2010 at 06:48:00PM CEST: > Yet another testsuite-tweaking patch. > * tests/depcomp.test: Do not create useless dummy source files. > Add a trailing `:' command. > * tests/depcomp2.test: Use `unset' on the CFLAG variable to ensure > it's not in in the envir

Re: [PATCHES] Bootstrap: Allow user overriding of $AUTOCONF and $PERL.

* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 12:53:21PM CEST: > At Sunday 08 August 2010, Ralf Wildenhues wrote: > > Also, regenerating the tree with Autoconf 2.67 and committing that > > separately is preapproved for maint. > Couldn't this cause problems when later mer

Re: [PATCHES] Bootstrap: Allow user overriding of $AUTOCONF and $PERL.

* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 12:09:52PM CEST: > I squashed the following into the first patch: > It's OK for you? Sure. > > > (BTW, if my understanding is correct, this would make a nice > > > addition to HACKING, too). > > > > Yep. > Attached is a follow-up patch that does

Re: [PATCH] Tweak, extend and improve tests `cond[a-z]*.test'.

Hello Stefano, * Stefano Lattarini wrote on Wed, Jul 14, 2010 at 03:26:04PM CEST: > * tests/condd.test: Add trailing `:' command. Typofix in > comment. Prefer fgrep over grep. > * tests/condhook.test: Make sure target `install-data-hook' is > not called by `make install', but that data files are

Re: [PATCH] Modernize, improve and/or extend tests `colon*.test.

* Stefano Lattarini wrote on Thu, Aug 05, 2010 at 01:54:20PM CEST: > Ping on this? It seems to me that most issues with this patch had > already been solved, so it's probably a pity to let it bitrotting > here... Well, I'd prefer the extract_dependencies script approach which would be more corre

Re: [PATCH] Minor improvements for tests `acloca*.test'.

* Stefano Lattarini wrote on Sun, Jun 27, 2010 at 04:48:03PM CEST: > Another testsuite-tweaking patch. This time, the changes should be > small and simple. > Minor improvements for tests `acloca*.test'. This is not ok. Let's just drop everything from it except for the changes I've copied below

transform2.test failure on Cygwin: replacing an executable with a script

I'm seeing a presumably new failure on Cygwin that I don't remember seeing before. The gist is the following: transform2.test tries something like install bla.exe .../inst/bin/foo.exe install script.sh .../inst/bin/foo and the second one fails (to overwrite the foo.exe). Does anybody happen

Re: [PATCH] Separate failing part of test `all.test'.

* Stefano Lattarini wrote on Wed, Jul 14, 2010 at 01:36:57PM CEST: > * tests/all.test: Run aclocal only once. Minor cosmetic changes. > Move checks that several *-local's in a single rule work ... This sentence does not make sense to me. Maybe a missing word? > * tests/manylocal.test: ... in th

Re: [PATCH] Modernize, improve and extend tests `subobj*.test'.

* Stefano Lattarini wrote on Wed, Jul 14, 2010 at 03:41:14PM CEST: > * tests/subobjname.test: Add trailing `:' command. > * tests/subobj.test: Make grepping of `Makefile.in' stricter. > Escape literal dots in grep regexps. > * tests/subobj2.test: Add trailing `:' command. Do not use the > unport

Re: [PATCH] Remove a couple of obsoleted tests.

* Stefano Lattarini wrote on Wed, Jul 14, 2010 at 01:16:28PM CEST: > Remove a couple of obsoleted tests. > > * tests/fpinstall.test: Removed. > * tests/fpinst2.test: Likewise. OK for maint, but only if you also update tests/Makefile.{am,in} to avoid subsequent testsuite failure. ;-) Cheers,

Re: Priorities in Automake developement

* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 05:55:47PM CEST: > At Sunday 08 August 2010, Ralf Wildenhues wrote: > > > 2. Automake, in its current incarnation, is mostly > > > feature-complete IMHO > > > > I don't quite agree; esp. since several people

Re: [PATCH] Modernize, improve and/or extend tests `colon*.test.

* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 05:09:03PM CEST: > At Sunday 08 August 2010, Ralf Wildenhues wrote: > > tgt1 tgt2 \ > > tgt3 : dep1 dep2 \ > > dep3 \ > > dep4 > > > > Posix is perfectly clear about the list of t

fake merges (was: [PATCHES] Bootstrap: Allow user overriding of $AUTOCONF and $PERL.)

* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 01:13:07PM CEST: > At Sunday 08 August 2010, Ralf Wildenhues wrote: > > * Stefano Lattarini wrote on Sun, Aug 08, 2010 at 12:53:21PM CEST: > > > At Sunday 08 August 2010, Ralf Wildenhues wrote: > > > > Also, regenerati

Re: [PATCH] Modernize, improve and extend tests `subobj*.test'.

* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 12:44:32PM CEST: > At Sunday 08 August 2010, Ralf Wildenhues wrote: > > > -$FGREP 'generic/a.$(OBJEXT)' Makefile.in > > > +grep '^generic/a\.\$(OBJEXT):' Makefile.in > > > > Some day I

Re: [INFO] push + merge delayed

* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 07:17:49PM CEST: > I just want state explicitly that I'll wait until tomorrow > (or even the day after) to merge and push the patches we have > reviewed this afternoon, since the time for today is almost out, > and I don't want to do a push without

Re: [PATCH] Modernize, improve and/or extend tests `colon*.test.

* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 04:38:08PM CEST: > At Sunday 08 August 2010, Ralf Wildenhues wrote: > > * Stefano Lattarini wrote on Thu, Aug 05, 2010 at 01:54:20PM CEST: > > > Ping on this? It seems to me that most issues with this patch > > > had a

Re: [PATCH] Modernize, improve and extend tests `pr*.test'.

* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 04:06:32PM CEST: > At Sunday 08 August 2010, Ralf Wildenhues wrote: > > ok with it if you also add more meaningful descriptions to the > > tests, say, the PR descriptions. > I'd love to do that (maybe as a separate patc

Re: [PATCH] Modernize, improve and/or extend tests `colon*.test.

* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 05:48:58PM CEST: > At Sunday 08 August 2010, Ralf Wildenhues wrote: > > * Stefano Lattarini wrote on Sun, Aug 08, 2010 at 05:35:57PM CEST: > > > foo=`extract_makefile_deps tgt2 Makefile`; echo x"$foo"x > >

Re: Priorities in Automake developement

This topic is actually better discussed when the list server is up again, and on the automake@ list, so others can chime in, too. So just a couple of quick notes for now, and I hope to write more about the general topic soonish: * Stefano Lattarini wrote on Sun, Aug 08, 2010 at 03:59:34PM CEST: >

Re: [PATCH] Modernize, improve and/or extend tests `colon*.test.

* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 05:35:57PM CEST: > I'm just saying that when we'll write the `extract_makefile_deps' > function, it shouldn't bother with preserving tabs and backslashes; Well, it should deal with them correctly, yes. > on the other hand, it should actively norm

Re: [PATCH] Improve and extend tests `asm*.test'.

* Stefano Lattarini wrote on Wed, Jul 14, 2010 at 02:19:20PM CEST: > * tests/asm.test: Use configure.in stub generated by ./defs, > and avoid obsoleted autoconf constructs. Make grepping of > Automake stderr stricter. Do not create useless source file. > Improve verbose messages. Minor cosmetic

Re: [PATCH] Remove a couple of obsoleted tests.

* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 01:04:14PM CEST: > At Sunday 08 August 2010, Ralf Wildenhues wrote: > > * Stefano Lattarini wrote on Wed, Jul 14, 2010 at 01:16:28PM CEST: > > > Remove a couple of obsoleted tests. > > > > > > * tests/fpinstall.

<    1   2   3   4   5   6   7   8   9   10   >