[avr-libc-dev] [patch #6352] Far pointer library

2010-06-03 Thread Jan Waclawek
Follow-up Comment #5, patch #6352 (project avr-libc): Adding one more function, memcmp_PF(). Jan Waclawek (file #20682) ___ Additional Item Attachment: File name: memcmp_PF.zip Size:4 KB ___

Re: [avr-libc-dev] New pgm_read_ptr() macro?

2010-06-03 Thread Jan Waclawek
>3) Resolving the compiler/linker issues, specifically code generated >when the gs() macro kicks in. Jan, I'm still not convinced its purely a >linker error, more likely a problem with gs() but I didn't get to dig >much further. I believe the most competent to judge is the author of that patch, Bj

Re: [avr-libc-dev] New pgm_read_ptr() macro?

2010-06-03 Thread Jan Waclawek
David, We are not talking about macros exactly. 1. pgm_read_xxx_far() macros are contained in the "original" 2. the major "component" of Carlos' morepgmspace.h is the GET_FAR_POINTER macro, which allows to access objects placed in far FLASH (rather than having them placed at an absolute addres

Re: [avr-libc-dev] New pgm_read_ptr() macro?

2010-06-03 Thread David Brown
On 03/06/2010 14:55, Jan Waclawek wrote: I would also like very much to finally add the FAR macros that Carlos put together a long time ago, or something very similar. I don't remember if there was ever any issues with them that need to get resolved, or if there is basic agreement that these shou

Re: [avr-libc-dev] New pgm_read_ptr() macro?

2010-06-03 Thread Dale Whitfield
Hi > > I would also like very much to finally add the FAR macros that Carlos put > > together a long time ago, or something very similar. I don't remember if > > there was ever any issues with them that need to get resolved, or if there > > is basic agreement that these should be added the way

RE: [avr-libc-dev] New pgm_read_ptr() macro?

2010-06-03 Thread Jan Waclawek
> I would also like very much to finally add the FAR macros that Carlos put > together a long time ago, or something very similar. I don't remember if > there was ever any issues with them that need to get resolved, or if there is > basic agreement that these should be added the way they are etc

RE: [avr-libc-dev] New pgm_read_ptr() macro?

2010-06-03 Thread Weddington, Eric
> -Original Message- > From: > avr-libc-dev-bounces+eric.weddington=atmel@nongnu.org > [mailto:avr-libc-dev-bounces+eric.weddington=atmel@nongnu. > org] On Behalf Of David Brown > Sent: Thursday, June 03, 2010 1:04 PM > To: avr-libc-dev@nongnu.org > Subject: Re: [avr-libc-dev]

Re: [avr-libc-dev] New pgm_read_ptr() macro?

2010-06-03 Thread David Brown
On 03/06/2010 10:09, Weddington, Eric wrote: Hi Jan, Be sure to keep posts on-list. I would be ok with adding this and adding Dean's new macro too. Removing functionality from avr-libc gets into backwards-compatibility issues. However, I want to make sure that this has been tested out, and tha

RE: [avr-libc-dev] New pgm_read_ptr() macro?

2010-06-03 Thread Weddington, Eric
Hi Jan, Be sure to keep posts on-list. I would be ok with adding this and adding Dean's new macro too. Removing functionality from avr-libc gets into backwards-compatibility issues. However, I want to make sure that this has been tested out, and that documentation is included. In both patches.

RE: [avr-libc-dev] New pgm_read_ptr() macro?

2010-06-03 Thread Weddington, Eric
I think it's not so much a philosophical change that concerns me. I'm interested in how resulting code size would be affected, as suggested by someone else on this list (sorry, I've forgotten who it was). Have you done some testing about resulting code size using this macro compared to the mor

Re: [avr-libc-dev] New pgm_read_ptr() macro?

2010-06-03 Thread David Brown
Hi, Are there any opinions about whether a macro such as the one I gave below should be part of avrlibc? It's not as clear-cut as Dean's pgm_read_ptr() macro, which follows the existing patterns in the headers. Macros like mine are more like template programming than the fixed-size macros,