[jira] Assigned: (AVRO-211) Nested schema does not get parsed in C++

2009-11-18 Thread Scott Banachowski (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Banachowski reassigned AVRO-211: -- Assignee: Scott Banachowski Nested schema does not get parsed in C++

[jira] Created: (AVRO-213) run Apache RAT as a part of testing

2009-11-18 Thread Doug Cutting (JIRA)
run Apache RAT as a part of testing --- Key: AVRO-213 URL: https://issues.apache.org/jira/browse/AVRO-213 Project: Avro Issue Type: Improvement Reporter: Doug Cutting Assignee: Doug

[jira] Updated: (AVRO-210) Memory leak with recursive schemas when constructed by hand

2009-11-18 Thread Scott Banachowski (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Banachowski updated AVRO-210: --- Status: Patch Available (was: Open) I went ahead and fixed this in patch AVRO-211. Since the

[jira] Updated: (AVRO-211) Nested schema does not get parsed in C++

2009-11-18 Thread Scott Banachowski (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Banachowski updated AVRO-211: --- Attachment: AVRO-211.patch Nested schema does not get parsed in C++

[jira] Updated: (AVRO-213) run Apache RAT as a part of testing

2009-11-18 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Doug Cutting updated AVRO-213: -- Attachment: AVRO-213.patch Patch that adds a rat task. I added a src/rat-excludes.txt file that lists

[jira] Updated: (AVRO-213) run Apache RAT as a part of testing

2009-11-18 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Doug Cutting updated AVRO-213: -- Fix Version/s: 1.3.0 Status: Patch Available (was: Open) run Apache RAT as a part of

[jira] Updated: (AVRO-206) Java compiler/python parser don't conform to spec re object schema

2009-11-18 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Doug Cutting updated AVRO-206: -- Attachment: AVRO-206.patch Here's a patch w/ tests for the java side of this. Java compiler/python

[jira] Commented: (AVRO-210) Memory leak with recursive schemas when constructed by hand

2009-11-18 Thread Scott Banachowski (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12779673#action_12779673 ] Scott Banachowski commented on AVRO-210: Checked the change by running unittest with

Re: clarification on schema resolution

2009-11-18 Thread Doug Cutting
Scott Banachowski wrote: What I am really wondering is what flagging an error means in this context. What if this is a field of a record--in this case, does error mean that the entire record is bad? Or do I simply ignore this field and process the rest of the record? And if I do the latter,

[jira] Updated: (AVRO-202) Add __all__ listing to avro module

2009-11-18 Thread Jeff Hammerbacher (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Hammerbacher updated AVRO-202: --- Status: Patch Available (was: Open) Add __all__ listing to avro module

[jira] Updated: (AVRO-201) Move DataFile[Reader|Writer] from io.py into datafile.py

2009-11-18 Thread Jeff Hammerbacher (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Hammerbacher updated AVRO-201: --- Status: Patch Available (was: Open) Move DataFile[Reader|Writer] from io.py into datafile.py

[jira] Updated: (AVRO-202) Add __all__ listing to avro module

2009-11-18 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated AVRO-202: -- Status: Open (was: Patch Available) -1, please add a test for this I reviewed the patch and tested in

[jira] Updated: (AVRO-203) Add single space between # and text in license headers for Python files

2009-11-18 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated AVRO-203: -- Hadoop Flags: [Reviewed] +1, this patch looks good to me, ready for commit. Add single space between #

[jira] Updated: (AVRO-201) Move DataFile[Reader|Writer] from io.py into datafile.py

2009-11-18 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated AVRO-201: -- Attachment: AVRO-201.patch This updated patch fixes the license header on the new file to be consistent

[jira] Updated: (AVRO-201) Move DataFile[Reader|Writer] from io.py into datafile.py

2009-11-18 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated AVRO-201: -- Hadoop Flags: [Reviewed] +1, ready for commit I reviewed the patch and it looks fine, no new tests but

[jira] Updated: (AVRO-199) Clean up schemas in testio.py

2009-11-18 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated AVRO-199: -- Status: Patch Available (was: Open) Clean up schemas in testio.py -

[jira] Updated: (AVRO-199) Clean up schemas in testio.py

2009-11-18 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated AVRO-199: -- Status: Open (was: Patch Available) This patch looks good to me in general, the use of 'xxx' rather

[jira] Commented: (AVRO-199) Clean up schemas in testio.py

2009-11-18 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12779727#action_12779727 ] Patrick Hunt commented on AVRO-199: --- Unfort the indentation is lost in my prior comment

[jira] Commented: (AVRO-208) java specific compiler doesn't check for ambiguous enums

2009-11-18 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12779730#action_12779730 ] Patrick Hunt commented on AVRO-208: --- How could it be otw? Is it ever legal to have dup

[jira] Updated: (AVRO-202) Add __all__ listing to avro module

2009-11-18 Thread Jeff Hammerbacher (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Hammerbacher updated AVRO-202: --- Attachment: AVRO-202.patch Add __all__ listing to avro module

[jira] Commented: (AVRO-202) Add __all__ listing to avro module

2009-11-18 Thread Jeff Hammerbacher (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12779734#action_12779734 ] Jeff Hammerbacher commented on AVRO-202: Thanks for the review, Patrick. I added a

[jira] Commented: (AVRO-199) Clean up schemas in testio.py

2009-11-18 Thread Jeff Hammerbacher (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12779746#action_12779746 ] Jeff Hammerbacher commented on AVRO-199: Yo, Neither PEP 8 nor Code Like a

[jira] Created: (AVRO-214) Add feature matrix to documentation detailing the state of implementation of the spec for each language implementation

2009-11-18 Thread Jeff Hammerbacher (JIRA)
Add feature matrix to documentation detailing the state of implementation of the spec for each language implementation -- Key: AVRO-214 URL:

[jira] Commented: (AVRO-202) Add __all__ listing to avro module

2009-11-18 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12779753#action_12779753 ] Patrick Hunt commented on AVRO-202: --- instead you could change a test like

[jira] Commented: (AVRO-214) Add feature matrix to documentation detailing the state of implementation of the spec for each language implementation

2009-11-18 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12779754#action_12779754 ] Doug Cutting commented on AVRO-214: --- To be concrete, I suggest: - add to the top-level

[jira] Commented: (AVRO-199) Clean up schemas in testio.py

2009-11-18 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12779758#action_12779758 ] Patrick Hunt commented on AVRO-199: --- as I said, my personal preference. I have many spoon

[jira] Commented: (AVRO-202) Add __all__ listing to avro module

2009-11-18 Thread Jeff Hammerbacher (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12779763#action_12779763 ] Jeff Hammerbacher commented on AVRO-202: Would you want a test to ensure that the

[jira] Updated: (AVRO-201) Move DataFile[Reader|Writer] from io.py into datafile.py

2009-11-18 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Doug Cutting updated AVRO-201: -- Issue Type: Improvement (was: Task) Move DataFile[Reader|Writer] from io.py into datafile.py

[jira] Updated: (AVRO-203) Add single space between # and text in license headers for Python files

2009-11-18 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Doug Cutting updated AVRO-203: -- Issue Type: Improvement (was: Task) The Task issue type is rarely used. It's for stuff like account

[jira] Commented: (AVRO-211) Nested schema does not get parsed in C++

2009-11-18 Thread Thiruvalluvan M. G. (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12779820#action_12779820 ] Thiruvalluvan M. G. commented on AVRO-211: -- +1 This patch compiles the nested

Re: clarification on schema resolution

2009-11-18 Thread Scott Carey
On 11/18/09 1:51 PM, Doug Cutting cutt...@apache.org wrote: I don't know that these conventions are always the best. Consider the extreme: if the reader's top-level schema is int and the writer wrote using a float schema, should we: a. require that implementations signal an error; b.

[jira] Updated: (AVRO-202) Add __all__ listing to avro module

2009-11-18 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated AVRO-202: -- Hadoop Flags: [Reviewed] I'm fine with the patch the way it is currently, +1. I don't see how to resolve

[jira] Commented: (AVRO-202) Add __all__ listing to avro module

2009-11-18 Thread Philip Zeyliger (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12779845#action_12779845 ] Philip Zeyliger commented on AVRO-202: -- +1. Add __all__ listing to avro module