At 1251683820 time_t, koniu wrote:
> Can you give some solid arguments for splitting it?
They're just doing 2 differents things.
You can always add a 3rd function doing the common work to avoid
duplication.
I'm not that uncomfortable with that compared to the fact that it fixes
the history so I p
On Fri, Aug 28, 2009 at 09:57, Julien Danjou wrote:
>> + if not data.history[screen] then
>> + data.history[screen] = {}
> Bad indent.
Fixed.
>> + -- limit history
>> + elseif #data.history[screen] == history.limit then
>> + table.remove(data.history[scre
At 1251393183 time_t, koniu wrote:
> +if not compare_select(curtags, data.history.current[screen]) and
> #selectedlist(screen) > 0 then
> +-- create history table
> +if not data.history[screen] then
> + data.history[screen] = {}
Bad indent.
> +-- limit histor
A little amendment to the 1st patch - typo in a comment + dirty whitespace.
k
From 275eeb31ab4e2e9badc63cbcf637efff3b0c8a8b Mon Sep 17 00:00:00 2001
From: koniu
Date: Thu, 27 Aug 2009 15:03:45 +0100
Subject: [PATCH 1/4] awful.tag: fix and improve tag history
This fixes a long standing tag histor
Tada.
On Thu, Aug 27, 2009 at 16:46, Julien Danjou wrote:
> Seems ok to merge, except that there's still 3 things that I'd like:
> - Configurable history limit (20 is arbitrary)
> a variable in the module that the user can modify is enough and
> trivial to add;
Done, setting awful.tag.history.
At 1251387674 time_t, koniu wrote:
> Actually this is different issue, L107:s/screen/s/ ? Try the amended
> patch as attached.
Seems better indeed!
Seems ok to merge, except that there's still 3 things that I'd like:
- Configurable history limit (20 is arbitrary)
a variable in the module that t
At 1251387477 time_t, koniu wrote:
> Sometimes meaning right after reload or after repeated restore until
> you run out of history entries? Indeed, I didnt add handling of
> restore when there's nothing recorded.
No, I don't think so. I'm using it like a dumb user:
I switch to tag 1;
I switch to
>> W: awesome: luaA_dofunction:113: error while running function
>> stack traceback:
>> /usr/local/share/awesome/lib/awful/tag.lua:107: in function 'press'
>> /usr/local/share/awesome/lib/awful/key.lua:36: in function
>>
>> error: /usr/local/share/awesome/lib/awful/tag.lua:107: tabl
On Thu, Aug 27, 2009 at 16:33, Julien Danjou wrote:
> At 1251386782 time_t, koniu wrote:
>> Done, see attachments.
>
> It sometime fails with:
>
> W: awesome: luaA_dofunction:113: error while running function
> stack traceback:
> /usr/local/share/awesome/lib/awful/tag.lua:107: in function 'p
At 1251386782 time_t, koniu wrote:
> Done, see attachments.
It sometime fails with:
W: awesome: luaA_dofunction:113: error while running function
stack traceback:
/usr/local/share/awesome/lib/awful/tag.lua:107: in function 'press'
/usr/local/share/awesome/lib/awful/key.lua:36: in
> At 1251382869 time_t, koniu wrote:
>> good?
>
> Yes, the implementation is good (I did not test the patch, but I trust
> you and I will test before merging).
>
> You can get extra point for:
> * moving stuff to awful.tag;
> * simplifying default rc.lua;
> * maybe using tag::history::update (maybe
Dear koniu,
At 1251382869 time_t, koniu wrote:
> good?
Yes, the implementation is good (I did not test the patch, but I trust
you and I will test before merging).
You can get extra point for:
* moving stuff to awful.tag;
* simplifying default rc.lua;
* maybe using tag::history::update (maybe som
as
to preferred solution welcome, patches will follow.
-- same with default binding:
awful.key({ modkey, "Control" }, i,
good?
k
From 80889280c009bc1288e476a53497638c1dd4ef9e Mon Sep 17 00:00:00 2001
From: koniu
Date: Thu, 27 Aug 2009 15:03:45 +0100
Subject: [PATCH] awful.tag: fix tag
13 matches
Mail list logo
