Re: hg: jdk7/awt/jdk: 6749920: Cleanup AWT peer interfaces

2008-09-29 Thread Mario Torre
Il giorno lun, 29/09/2008 alle 22.38 +0100, Andrew John Hughes ha scritto: > Woo! Is that the first external author on a JDK7 changeset? In fact I think is the second, Martin Buchholz was the first. But I think it's indeed a very big step, because the process was very open at some point, I expec

Re: hg: jdk7/awt/jdk: 6749920: Cleanup AWT peer interfaces

2008-09-29 Thread Andrew John Hughes
2008/9/29 <[EMAIL PROTECTED]>: > Changeset: 672290c883fd > Author:rkennke > Date: 2008-09-29 20:16 +0200 > URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/672290c883fd > > 6749920: Cleanup AWT peer interfaces > Summary: Remove duplicate and obsolete methods in the AWT peer interfac

Re: hg: jdk7/awt/jdk: 6749920: Cleanup AWT peer interfaces

2008-09-29 Thread Mario Torre
Il giorno lun, 29/09/2008 alle 22.35 +0200, Roman Kennke ha scritto: > Maybe use the original one 6749750 ? ;-) Sorry for messing things up. > > > And thanks for the help! > > Thanks for your help! Btw, this was a really big step. Thanks to you all for being so collaborative! Cheers, Mario --

Re: hg: jdk7/awt/jdk: 6749920: Cleanup AWT peer interfaces

2008-09-29 Thread Andrei Dmitriev
So now the status of that CR is Fix Available. Is it possible for people like me to do anything with the bugs, except read them and submit comments? I don't see any 'status' select box or similar. Unfortunately, no, there is no any public access to the bug database yet. :( BTW, s

Re: hg: jdk7/awt/jdk: 6749920: Cleanup AWT peer interfaces

2008-09-29 Thread Roman Kennke
Hi, > I'm updating the CR 6749750 (seem you mentioned a little bit another CR > in a push comment, see). Whoops. I was just copy+pasting a bug ID I found on this thread. Bad me :-) > So now the status of that CR is Fix Available. Is it possible for people like me to do anything with the bugs,

Re: hg: jdk7/awt/jdk: 6749920: Cleanup AWT peer interfaces

2008-09-29 Thread Andrei Dmitriev
Congrats, Roman! I'm updating the CR 6749750 (seem you mentioned a little bit another CR in a push comment, see). So now the status of that CR is Fix Available. BTW, seem when pushing a patch for 6749920 we would suggested to provide another CR number because duplicate are prohibited. And tha

Re: [PATCH] Cleanup AWT peer interfaces

2008-09-29 Thread Martin Buchholz
On Mon, Sep 29, 2008 at 10:10, Roman Kennke <[EMAIL PROTECTED]> wrote: >> Please, add me (OpenJDK user 'art') and Andrei ('dav') to the list of >> reviewers. > > Ok, I did. I tried to push and then got this: > > remote: Invalid changeset author: Roman Kennke <[EMAIL PROTECTED]> > > I can rollback

hg: jdk7/awt/jdk: 6749920: Cleanup AWT peer interfaces

2008-09-29 Thread roman
Changeset: 672290c883fd Author:rkennke Date: 2008-09-29 20:16 +0200 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/672290c883fd 6749920: Cleanup AWT peer interfaces Summary: Remove duplicate and obsolete methods in the AWT peer interfaces. Reviewed-by: art, dav ! src/share/classe

Re: [PATCH] Cleanup AWT peer interfaces

2008-09-29 Thread Roman Kennke
Hi again, > >> the issue with SCA/OpenJDK user names (see email below) is resolved, so > >> you can push your changes into awt-gate workspace. Note, we decided to > >> push the docs change in a separate patch (and it is still in progress, > >> as far as I see). > > > > Wow cool, my first self-

Re: [PATCH] Cleanup AWT peer interfaces

2008-09-29 Thread Artem Ananiev
Roman Kennke wrote: Hi Artem, the issue with SCA/OpenJDK user names (see email below) is resolved, so you can push your changes into awt-gate workspace. Note, we decided to push the docs change in a separate patch (and it is still in progress, as far as I see). Wow cool, my first self-comm

Re: [PATCH] Cleanup AWT peer interfaces

2008-09-29 Thread Martin Buchholz
On Mon, Sep 29, 2008 at 08:56, Roman Kennke <[EMAIL PROTECTED]> wrote: > I think, it would be useful to have a list of AWT group > members and their shortnames somewhere. (This applies to all groups I > suppose..) There is a list of all "people" http://db.openjdk.java.net/people but I don't know

Re: [PATCH] Cleanup AWT peer interfaces

2008-09-29 Thread Roman Kennke
Hi Artem, > the issue with SCA/OpenJDK user names (see email below) is resolved, so > you can push your changes into awt-gate workspace. Note, we decided to > push the docs change in a separate patch (and it is still in progress, > as far as I see). Wow cool, my first self-committed patch :-)

Re: [PATCH] Cleanup AWT peer interfaces

2008-09-29 Thread Andrei V. Dmitriev
Artem Ananiev wrote: Hi, Roman, the issue with SCA/OpenJDK user names (see email below) is resolved, so you can push your changes into awt-gate workspace. Note, we decided to push the docs change in a separate patch (and it is still in progress, as far as I see). Confirmed! And GL, Roman! :

Re: [PATCH] Cleanup AWT peer interfaces

2008-09-29 Thread Artem Ananiev
Hi, Roman, the issue with SCA/OpenJDK user names (see email below) is resolved, so you can push your changes into awt-gate workspace. Note, we decided to push the docs change in a separate patch (and it is still in progress, as far as I see). Thanks, Artem Artem Ananiev wrote: Andrew Joh

hg: jdk7/awt/jdk: 6746212: Broken MouseEvents for TrayIcon

2008-09-29 Thread andrei . dmitriev
Changeset: 7e0533679ea1 Author:dav Date: 2008-09-29 14:54 +0400 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/7e0533679ea1 6746212: Broken MouseEvents for TrayIcon Reviewed-by: dcherepanov, art ! src/windows/native/sun/windows/awt_TrayIcon.cpp