Re: Request for review: 6832386 Fix JTreg test: java/awt/Graphics/DrawImageBG/SystemBgColorTest.java

2009-05-06 Thread Kelly O'Hair
Looks fine to me. -kto Anthony Petrov wrote: awt-dev: please review the fix for 6open and 7 at: http://cr.openjdk.java.net/~anthony/6open-1-systemExitNotNeeded-6832386.0/ and http://cr.openjdk.java.net/~anthony/7-10-systemExitNotNeeded-6832386.0/ (should admit the webrevs are quite identical

Re: Request for review: 6832386 Fix JTreg test: java/awt/Graphics/DrawImageBG/SystemBgColorTest.java

2009-05-06 Thread Joseph D. Darcy
Anthony Petrov wrote: awt-dev: please review the fix for 6open and 7 at: http://cr.openjdk.java.net/~anthony/6open-1-systemExitNotNeeded-6832386.0/ and http://cr.openjdk.java.net/~anthony/7-10-systemExitNotNeeded-6832386.0/ (should admit the webrevs are quite identical :) ) The correspondin

hg: jdk7/awt/jdk: 6838046: Rollback 6762511 due to build failure (6838003)

2009-05-06 Thread anthony . petrov
Changeset: b28b073e72b6 Author:anthony Date: 2009-05-06 20:06 +0400 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/b28b073e72b6 6838046: Rollback 6762511 due to build failure (6838003) Reviewed-by: yan ! src/solaris/classes/sun/awt/X11GraphicsConfig.java ! src/solaris/classes/sun

Re: Request for review: 6832386 Fix JTreg test: java/awt/Graphics/DrawImageBG/SystemBgColorTest.java

2009-05-06 Thread Artem Ananiev
I personally don't see any problems with the fix. Thanks, Artem Anthony Petrov wrote: awt-dev: please review the fix for 6open and 7 at: http://cr.openjdk.java.net/~anthony/6open-1-systemExitNotNeeded-6832386.0/ and http://cr.openjdk.java.net/~anthony/7-10-systemExitNotNeeded-6832386.0/ (sho

Request for review: 6832386 Fix JTreg test: java/awt/Graphics/DrawImageBG/SystemBgColorTest.java

2009-05-06 Thread Anthony Petrov
awt-dev: please review the fix for 6open and 7 at: http://cr.openjdk.java.net/~anthony/6open-1-systemExitNotNeeded-6832386.0/ and http://cr.openjdk.java.net/~anthony/7-10-systemExitNotNeeded-6832386.0/ (should admit the webrevs are quite identical :) ) The corresponding Bugzilla bug entry is at

hg: jdk7/awt/jdk: 6837004: java.awt.GraphicsDevice.setFullScreenWindow throws NPE for windows with background color not set

2009-05-06 Thread artem . ananiev
Changeset: ba95c9101e50 Author:art Date: 2009-05-06 12:39 +0400 URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/ba95c9101e50 6837004: java.awt.GraphicsDevice.setFullScreenWindow throws NPE for windows with background color not set Reviewed-by: yan, dcherepanov ! src/share/classes