Il 23/06/2009 23:51, Roman Kennke ha scritto:
Hi,
Someone would need to make darn sure that ALL uses of the old
name have been changed. I counted 362 references to this variable
in the openjdk7 repositories, I assume a similar number in openjdk6.
The closed jdk sources have an additional 13 ref
Il 23/06/2009 23:37, Phil Race ha scritto:
Ah, everyone must be looking at the old (1.16) lcms that we
replaced quite a few builds ago. It didn't have the #if macintosh
Whoops... I admit that we depend on a slightly older OpenJDK version,
and this time I didn't checked the latest code :) I ju
Hi,
Someone would need to make darn sure that ALL uses of the old
name have been changed. I counted 362 references to this variable
in the openjdk7 repositories, I assume a similar number in openjdk6.
The closed jdk sources have an additional 13 references to this
_LITTLE_ENDIAN name Sun would n
Hi,
first of all, I think this is a LCMS problem, so we should think about
how to fix this _upstream_, otherwise we end up maintaining a patched
version of lcms *shudder*.
Then I don't think it's a good idea to depend on such 'internal'
defines. One OS defines or not _LITTLE_ENDIAN, others (
Someone would need to make darn sure that ALL uses of the old
name have been changed. I counted 362 references to this variable
in the openjdk7 repositories, I assume a similar number in openjdk6.
The closed jdk sources have an additional 13 references to this
_LITTLE_ENDIAN name Sun would need to
Roman Kennke wrote:
Hi,
first of all, I think this is a LCMS problem, so we should think about
how to fix this _upstream_, otherwise we end up maintaining a patched
version of lcms *shudder*.
But I see only that in the lcms.h file. And it is protected inside
#if macintosh so I can't believ
Mario Torre wrote:
Hello all!
I have a problem with a block of code that checks if _LITTLE_ENDIAN is
defined, the code is in little cms and looks like:
#ifndef _LITTLE_ENDIAN
#define USE_BIG_ENDIAN 1
#endif
The issue that I have is that on VxWorks, the target I'm working on,
there is al
I like this patch!
Well, the only thing is with that:
public static boolean arebordersEqual(double border1, double border2) {
The name would look better if you follow the advice:
http://java.sun.com/docs/codeconv/html/CodeConventions.doc8.html#367
"Methods should be verbs, in mixed case with the
Hi Anthony,
On Tue, Jun 23, 2009 at 6:29 PM, Anthony Petrov wrote:
> Hi Oleg,
>
> Thank you very much for reviewing that!
You are welcome :) I hope I will be able to complete it by this weekend.
> On 06/21/2009 08:11 AM, Oleg Sukhodolsky wrote:
>>
>> src/share/classes/java/awt/Component.java
>>
Mario Torre wrote:
> Hello all!
>
> I have a problem with a block of code that checks if _LITTLE_ENDIAN is
> defined, the code is in little cms and looks like:
>
> #ifndef _LITTLE_ENDIAN
> #define USE_BIG_ENDIAN 1
> #endif
>
> The issue that I have is that on VxWorks, the target I'm working on
Hi,
Sorry for the mis-spell, I will remember from now on :). And here is the
corrected patch, let me know when it gets approved. Thanks a lot.
Man Lung Wong
- Original Message -
From: "Andrei Dmitriev"
To: "Man Wong"
Cc: awt-dev@openjdk.java.net
Sent: Tuesday, June 23, 2009 9:52:45 AM
Hi Oleg,
Thank you very much for reviewing that!
On 06/21/2009 08:11 AM, Oleg Sukhodolsky wrote:
src/share/classes/java/awt/Component.java
I suspect that you are disallowed to remove non-transient field from
serializable component :( this is backward incompatible change)
That makes me very sa
There are other occurrences of "boarders" in the file. I'd like all of
them also changed to be changed to "borders" or something like that if I
read their meaning correctly.
That bug number is for the reference only, you don't need to change it
either way. I do ;)
Could you please resubmit the
Hi,
Thanks for the reply. Should I make the fix and send it to you again? By the
way, for the fix, you only want the parameters name changed and should I also
change the bug information to the one that you just send me? Thanks again.
Man Lung Wong
- Original Message -
From: "Andrei Dmi
Hi,
I am just wondering if you had a chance to go through the patch I sent out last
week on LayoutExtraGap. Let me know either way. Thanks.
Man Lung Wong
On 06/22/2009 06:38 AM, Artem Ananiev wrote:
I'd be personally fine with another approach: don't traverse up all the
parents of the components and check if they all are valid as it's done
now. Instead, we can find the top-most valid container and perform the
mixing for all its children only.
C
Hello all!
I have a problem with a block of code that checks if _LITTLE_ENDIAN is
defined, the code is in little cms and looks like:
#ifndef _LITTLE_ENDIAN
#define USE_BIG_ENDIAN 1
#endif
The issue that I have is that on VxWorks, the target I'm working on,
there is always a definition of _
Changeset: 51e452ff726a
Author:anthony
Date: 2009-06-23 16:10 +0400
URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/51e452ff726a
6851646:
test/closed/java/awt/GridBagLayout/GridBagLayoutIpadXYTest/GridBagLayoutIpadXYTest.java
can fail
Summary: Added realSync() call. Made the test
Changeset: e279dd2c5a2c
Author:ant
Date: 2009-06-23 15:53 +0400
URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/e279dd2c5a2c
6821291: assertion failure in awt_Frame.h
Reviewed-by: dcherepanov, art
! src/windows/native/sun/windows/awt_Frame.cpp
! src/windows/native/sun/windows/awt_
Yep, thanks.
Anthony Petrov wrote:
On 06/23/2009 03:12 PM, Andrei Dmitriev wrote:
6848458: java/awt/GridLayout/LayoutExtraGaps/LayoutExtraGaps.java
fails (I can't find it through bugs.sun.com perhaps due to some
temporary problems with the site)
This link works for me: http://bugs.sun.com/view
Changeset: 61e25d428bfe
Author:dcherepanov
Date: 2009-06-23 15:10 +0400
URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/61e25d428bfe
6736247: Component.printAll Invalid local JNI handle
Reviewed-by: anthony
! src/windows/native/sun/windows/awt_Component.cpp
+ test/java/awt/Compone
On 06/23/2009 03:12 PM, Andrei Dmitriev wrote:
6848458: java/awt/GridLayout/LayoutExtraGaps/LayoutExtraGaps.java fails
(I can't find it through bugs.sun.com perhaps due to some temporary
problems with the site)
This link works for me: http://bugs.sun.com/view_bug.do?bug_id=6848458
--
best rega
Hi,
thanks for the analysis of this defect.
BTW, it's covered by the CR:
6848458: java/awt/GridLayout/LayoutExtraGaps/LayoutExtraGaps.java fails
(I can't find it through bugs.sun.com perhaps due to some temporary
problems with the site)
I like the fix but I'd name parameters not "boarders", but
Changeset: d1bdaf29e531
Author:dcherepanov
Date: 2009-06-23 13:35 +0400
URL: http://hg.openjdk.java.net/jdk7/awt/jdk/rev/d1bdaf29e531
6824169: Need to remove some AWT class dependencies
Reviewed-by: art, anthony, igor, alexp
! src/share/classes/java/awt/AWTEvent.java
! src/share/cl
24 matches
Mail list logo
