Re: Review request #0: 6863566 (Java should support the freedesktop.org startup notification specification)

2009-07-30 Thread Joseph D. Darcy
Oleg Sukhodolsky wrote: Hi, just a short question: do we really have to change the launcher? Why we can not add the changes to AWT's native code (somewhere near LoadLibrary())? Yes, it would be preferable if the launcher did not change for this. -Joe Oleg. On Wed, Jul 29, 2009 at 3:13

Re: Review request #3: 6852592 (revalidate() must be smarter)

2009-07-30 Thread Alexander Potochkin
Hello Anthony So the code is ready to the situation when there is no validate root If you make Window a validate root, the for loop will always find it and the logic will be changed Yes! And that seems to be completely correct: we HAVE TO call validate() on a validate root (or a top-level c

Re: Fwd: Your Report (Review ID: 1570033) - Shift+Tab no longer generates a KEY_TYPED event; used to with JRE 1.5

2009-07-30 Thread Anton V. Tarasov
Peter, I've filed a bug - 6866784. It will be available at bugs.sun.com in a couple of days. Thanks, Anton. Anton V. Tarasov wrote: Hi Peter, Peter Arrenbrecht wrote: Folks, I filed a bug about a missing KEY_TYPED event for Shift+Tab for JRE 1.6 and up a while ago. Now I've found an additi

Re: Review request #3: 6852592 (revalidate() must be smarter)

2009-07-30 Thread Anthony Petrov
On 07/23/2009 06:54 PM, Artem Ananiev wrote: This looks like a good idea. And what about the AWT ScrollPane? Shouldn't it return true as well? As well as this one. Legacy AWT applications are supposed to invoke the validate() method on the top-level component. After the proposed change the

Re: Review request #0: 6863566 (Java should support the freedesktop.org startup notification specification)

2009-07-30 Thread Anthony Petrov
On 07/29/2009 11:10 PM, Damjan Jovanovic wrote: Damjan, have you by the way tested the fix with a GUI Java application that does not display a top-level window, but rather creates a tray icon only? Does the notification get correctly removed from the task bar in that case? It doesn't :-(. The