Re: Review: Remove private API from graphics code

2012-08-31 Thread Scott Kovatch
On Aug 31, 2012, at 11:16 AM, Phil Race wrote: > Scott, > > These files were added by Bino to support printing. Quartz isn't used > except for printing in JDK 7, so as I understand it, testing on-screen in > Java2Demo should not exercise this code. I'm surprised that you saw > it being exercise

Re: Review: Remove private API from graphics code

2012-08-31 Thread Phil Race
The recommendation is to restore the graphics state rather than inverting :- https://developer.apple.com/library/mac/#documentation/graphicsimaging/conceptual/drawingwithquartz2d/dq_affine/dq_affine.html "Quartz also provides an affine transform function that inverts a matrix, |CGAffineTransfor

Re: [8] Review request for 7186109: Simplify lock machinery for PostEventQueue & EventQueue

2012-08-31 Thread Peter Levart
But haven't we started with the synchronized flush at the beginning and only did that to prevent a deadlock? In any case, it's better not to block toolkit thread. Regards, Peter On Aug 31, 2012 1:01 PM, "Oleg Pekhovskiy" wrote: > Hi Peter, > > making PostEventQueue.flush() method 'synchronized

Re: Review: Remove private API from graphics code

2012-08-31 Thread Phil Race
Scott, These files were added by Bino to support printing. Quartz isn't used except for printing in JDK 7, so as I understand it, testing on-screen in Java2Demo should not exercise this code. I'm surprised that you saw it being exercised. Did you do any printing testing ? The matrix inversion se

Re: [8] Review request for 7186109: Simplify lock machinery for PostEventQueue & EventQueue

2012-08-31 Thread Peter Levart
When you catch InterruptedException, you must do one of 3 things: 1 - handle it 2 - rethrow it 3 - re-assert thread interrupted status (Thread.currentThread().interrupt()) so that it will be thrown at some other (more appropriate) place/time. So if you don't want to complicate code and API to do 2

Review: Remove private API from graphics code

2012-08-31 Thread Scott Kovatch
http://cr.openjdk.java.net/~skovatch/7187834/webrev.00/ This is based on the patch submitted by Marco Dinacci. I had to modify it a bit to get it to compile against 7u-dev, but nothing major. The changes in ImageSurfaceData.h were needed as a result of my use of Xcode 4.4.1 on Mountain Lion. I

Re: [8] Review request for 7186109: Simplify lock machinery for PostEventQueue & EventQueue

2012-08-31 Thread Anthony Petrov
I think you should re-throw the InterruptedException caught at flush(). BTW, the flush() method can be invoked on a thread other than EDT (at least in theory). -- best regards, Anthony On 8/30/2012 9:01 PM, Oleg Pekhovskiy wrote: Hi, I got another idea preparing the next version of fix. Pre

Re: [8] Review request for 7186109: Simplify lock machinery for PostEventQueue & EventQueue

2012-08-31 Thread Anthony Petrov
Hi Peter, Well, if an event is posted after the flush() call but before the lock() in detach(), two things may happen: 1. The event makes it to the event queue before detach() locks the pushPopLock. In which case the peekEvent() sees the event and prevents EDT detaching. 2. detach() takes

hg: jdk8/awt/jdk: 6981400: Tabbing between textfield do not work properly when ALT+TAB; ...

2012-08-31 Thread anton . tarasov
Changeset: 0e007aa6f9db Author:ant Date: 2012-08-31 16:31 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/0e007aa6f9db 6981400: Tabbing between textfield do not work properly when ALT+TAB 7157015: [macosx] Situation when KeyEventDispatcher doesn't work on AWT but does on Swi

Re: [8] Review request for 6981400 Tabbing between textfield do not work properly when ALT+TAB

2012-08-31 Thread Anton V. Tarasov
Had to adopt the changes in LWWindowPeer.java to the latest changes in jdk: http://cr.openjdk.java.net/~ant/6981400/webrev.7/src/macosx/classes/sun/lwawt/LWWindowPeer.java.udiff.html The changes are inessential, still the last webrev is this: http://cr.openjdk.java.net/~ant/6981400/webrev.7 Th

Re: [8] Review request for 7186109: Simplify lock machinery for PostEventQueue & EventQueue

2012-08-31 Thread Oleg Pekhovskiy
Hi Peter, making PostEventQueue.flush() method 'synchronized' will block Toolkit thread during PostEventQueue.postEvent() call, that is bad. In our case synchronization monitor is released on wait(), thus no blocking occurs. Thanks, Oleg 31.08.2012 1:01, Peter Levart wrote: If I'm right, t

hg: jdk8/awt/jdk: 7186794: Setter not found. PropertyDescriptor(PropertyDescriptor, PropertyDescriptor)

2012-08-31 Thread sergey . malenkov
Changeset: b291b6d220c7 Author:malenkov Date: 2012-08-31 14:49 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b291b6d220c7 7186794: Setter not found. PropertyDescriptor(PropertyDescriptor,PropertyDescriptor) Reviewed-by: rupashka ! src/share/classes/java/beans/PropertyDesc

hg: jdk8/awt/jdk: 7192955: Introspector overide PropertyDescriptor for generic type field defined in super class

2012-08-31 Thread sergey . malenkov
Changeset: 973693566c46 Author:malenkov Date: 2012-08-31 14:32 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/973693566c46 7192955: Introspector overide PropertyDescriptor for generic type field defined in super class Reviewed-by: rupashka ! src/share/classes/java/beans/Pr