Hi Laurent,
The fix looks great to me. Thank you very much.
We still need at least one review, though. Hopefully net-dev@ and/or
swing-dev@ folks might help us out a bit.
--
best regards,
Anthony
On 3/20/2013 15:10, Anthony Petrov wrote:
Hi Laurent,
Thanks for the patch. I've filed a bug a
This looks perfect. Thank you, Denis.
--
best regards,
Anthony
On 3/21/2013 20:19, Denis S. Fokin wrote:
Hi Anthony,
it is not quite static, but I have added the initialization. The
declaration now is extern and the initialization is in the compilation
unit scope.
http://cr.openjdk.java.ne
Hi Anthony,
it is not quite static, but I have added the initialization. The
declaration now is extern and the initialization is in the compilation
unit scope.
http://cr.openjdk.java.net/~denis/7123476/webrev.09/
Thank you,
Denis.
On 3/21/2013 5:02 PM, Anthony Petrov wrote:
Hi Denis,
I
Hi Denis,
I suggest to add a static initializer for the gnome_url_show symbol in
the gnome_interface.c so that even if gnome_load() fails, the variable
would be equal to NULL rather than point to a random address in memory.
Otherwise the fix looks fine to me.
--
best regards,
Anthony
On 03/
Changeset: ef948ef2b58f
Author:alexsch
Date: 2013-03-21 16:50 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ef948ef2b58f
8007146: [macosx] Setting a display mode crashes JDK under VNC
Reviewed-by: serb
! src/macosx/native/sun/awt/CGraphicsDevice.m
+ test/java/awt/GraphicsD
