Review Request: JDK-8000406 - change files using @GenerateNativeHeader to use @Native

2013-04-01 Thread Dan Xu
Hi All, In this fix, I have updated files in JDK libraries to use @Native annotation instead of @GenerateNativeHeader to mark classes that contain no native methods but constants used by native codes. @GenerateNativeHeader was added earlier in the development for JDK8."This has proved probl

[8] Review Request for 8010009 : [macosx] Unable type into online word games on MacOSX

2013-04-01 Thread Petr Pchelko
Hello, AWT team. Please review the fix for the following issue: http://bugs.sun.com/view_bug.do?bug_id=8010009 The fix is available at: http://cr.openjdk.java.net/~pchelko/8010009/webrev.00/ The problem occurred because we use input methods for plugin keyboard input. So when the text from the in

Re: [8] Review request for 8010721: [macosx] In JDK7 the menu bar disappears when a Dialog is shown

2013-04-01 Thread Vladislav Karnaukhov
Hello Sergey, all, please review a new version: http://cr.openjdk.java.net/~vkarnauk/8010721/jdk8/webrev.02/ I agree that previous one was too complex and error-prone. The current version is much lighter and addresses various use-cases with different windows types and modality. Regards, -

Re: sun.awt.X11 logs still using String + (waste)

2013-04-01 Thread Sergey Bylokhov
Hi, Anthony Only two comments: 1 Why we need some special text in the log output like "***" and "###" 2 XScrollbarPeer.java: +if (log.isLoggable(PlatformLogger.FINEST)) { +log.finer("KeyEvent on scrollbar: " + event); +} On 4/1/13 12:20 PM, Anthony Petrov wrote: Aw

Re: Review Request for 8006941 : [macosx] Deadlock in drag and drop & 7199783 : Setting cursor on DragSourceContext does not work on OSX

2013-04-01 Thread Petr Pchelko
Hello, AWT Team. This is a reminder. Could I please get a second review on this? For your convenience: Bug: http://bugs.sun.com/view_bug.do?bug_id=7199783 Setting cursor on DragSourceContext does not work on OSX http://bugs.sun.com/view_bug.do?bug_id=8006941 Deadlock in drag and drop Fix: http

Re: Review request: 8010925: COPY AND PASTE TO AND FROM SIGNED APPLET FAILS AFTER FIRST INTERNAL COPY PRFRMD

2013-04-01 Thread Anthony Petrov
I'm not sure if there's a reasonable way to test this fix. You can use the Clipboard API w/o creating/showing any top-level windows which would emulate the conditions where the bug is currently reproduced in the browser environment. However, you'll never receive the synthetic focus event then,

Re: sun.awt.X11 logs still using String + (waste)

2013-04-01 Thread Anthony Petrov
Awt, Swing, Net engineers, Could anyone review the fix please? For your convenience: Bug: http://bugs.sun.com/view_bug.do?bug_id=8010297 Fix: http://cr.openjdk.java.net/~anthony/8-55-isLoggable-8010297.0/ -- best regards, Anthony On 3/22/2013 2:26, Anthony Petrov wrote: Hi Laurent, The fix