Re: sun.awt.X11 logs still using String + (waste)

2013-04-09 Thread Mandy Chung
On 4/9/13 12:37 AM, Laurent Bourgès wrote: Mandy, first I would like to have the given patch applied to OpenJDK 8 (+ JDK7u) as it fixes many problems: - string concatenations - object creations (Object[] or other objects given as params) - method calls in log statements This is the patch you

Re: Define JNIEXPORT as visibility default with GCC?

2013-04-09 Thread Martin Buchholz
On Tue, Apr 9, 2013 at 8:39 AM, David DeHaven wrote: > > > [ cc'ing awt-dev@ ] > > > > Probably gcc can't process typedefs with visibility attributes > specified, hence the changes to AWT. Generally they look good. > > It's not necessary for those typedefs as those types are not being used to > de

Re: sun.awt.X11 logs still using String + (waste)

2013-04-09 Thread Anthony Petrov
Hi Laurent, Thanks for all your hard work! The fix looks fine to me. I'm also CC'ing jdk8-dev@ to let other teams review the changes in their areas. I've only reviewed the AWT part of the fix. -- best regards, Anthony On 4/8/2013 15:32, Laurent Bourgès wrote: Anthony, here is an updated pa

Re: [OpenJDK 2D-Dev] [8] Request for review: 8000629 [macosx] Blurry rendering with Java 7 on Retina display

2013-04-09 Thread Sergey Bylokhov
Hi, Jim. During additional testing I found some artifacts in some animation, when the rendering to the scaled VolatileImge is different from the non scaled variant. Can you please take a look to the CR:8011764. On 4/9/13 1:19 AM, Jim Graham wrote: Hi Sergey, Did you check for possible perfor

Re: [OpenJDK 2D-Dev] [8] Request for review: 8000629 [macosx] Blurry rendering with Java 7 on Retina display

2013-04-09 Thread Sergey Bylokhov
Hi, Jim. On 4/9/13 1:19 AM, Jim Graham wrote: Hi Sergey, Did you check for possible performance hits for the new transform save/compare code in BufferedContext? I am not sure how it can be improved, because BufferedPaints.setPaint() depends from the current transform of the sg2d.transform. And

Re: sun.awt.X11 logs still using String + (waste)

2013-04-09 Thread Laurent Bourgès
Mandy, first I would like to have the given patch applied to OpenJDK 8 (+ JDK7u) as it fixes many problems: - string concatenations - object creations (Object[] or other objects given as params) - method calls in log statements In a second step, I can help somebody migrating JUL usages to Platfor

Re: Define JNIEXPORT as visibility default with GCC?

2013-04-09 Thread Anthony Petrov
Hi Coleen, Martin, [ cc'ing awt-dev@ ] Probably gcc can't process typedefs with visibility attributes specified, hence the changes to AWT. Generally they look good. However, I'm concerned with the compatibility impact of this change. I suppose that 3rd-party JNI libraries could use such a pa