Re: [8] Review request for CR 8011186 [TEST_BUG] java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java failed on windows 8

Thanks! Anton. On 4/23/2013 7:43 PM, Konstantin Shefov wrote: Oh, of course http://cr.openjdk.java.net/~kshefov/8011186/webrev.01/ On 23-Apr-13 19:39, Anthony Petrov wrote: You should also rename the class itself: 40 public class O

hg: jdk8/awt/langtools: 20 new changesets

Changeset: 2b585be0da7a Author:katleman Date: 2013-04-12 15:22 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/langtools/rev/2b585be0da7a 8012048: JDK8 b85 source with GPL header errors Reviewed-by: iris, mduigou, jjg ! test/com/sun/javadoc/testAnnotationOptional/TestAnnotationOptio

hg: jdk8/awt/corba: Added tag jdk8-b86 for changeset 44a8ce4a759f

Changeset: f1709874d55a Author:katleman Date: 2013-04-18 10:30 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/corba/rev/f1709874d55a Added tag jdk8-b86 for changeset 44a8ce4a759f ! .hgtags

hg: jdk8/awt/nashorn: 18 new changesets

Changeset: e7e82c1e9aed Author:katleman Date: 2013-04-12 15:22 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/nashorn/rev/e7e82c1e9aed 8012048: JDK8 b85 source with GPL header errors Reviewed-by: iris, mduigou, jjg ! docs/JavaScriptingProgrammersGuide.html ! src/jdk/nashorn/api/scr

hg: jdk8/awt: 9 new changesets

Changeset: bee6ff988f9c Author:katleman Date: 2013-04-12 15:21 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/rev/bee6ff988f9c 8012048: JDK8 b85 source with GPL header errors Reviewed-by: iris, mduigou, jjg ! common/autoconf/compare.sh.in ! common/bin/compare.sh Changeset: 8c5b18d

hg: jdk8/awt/jaxp: 4 new changesets

Changeset: 9550aab82b5d Author:katleman Date: 2013-04-18 10:30 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jaxp/rev/9550aab82b5d Added tag jdk8-b86 for changeset ca71ec37b2ef ! .hgtags Changeset: 10db50a26b39 Author:joehw Date: 2013-02-18 11:33 -0800 URL: http://

hg: jdk8/awt/hotspot: 9 new changesets

Changeset: b0301c02f38e Author:katleman Date: 2013-04-12 15:22 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/hotspot/rev/b0301c02f38e 8012048: JDK8 b85 source with GPL header errors Reviewed-by: iris, mduigou, jjg ! make/bsd/makefiles/fastdebug.make ! src/share/vm/services/diagnos

hg: jdk8/awt/jaxws: 4 new changesets

Changeset: 8abe95530f58 Author:katleman Date: 2013-04-18 10:30 -0700 URL: http://hg.openjdk.java.net/jdk8/awt/jaxws/rev/8abe95530f58 Added tag jdk8-b86 for changeset a5e7c2f093c9 ! .hgtags Changeset: 28886cb008bb Author:lana Date: 2013-04-11 19:15 -0700 URL: http://

Re: [8] Request for review: 7166296 closed/java/awt/Frame/DisabledParentOfToplevel/DisabledParentOfToplevel.html failed since 1.8.0b36

On 23.04.2013 17:23, Anthony Petrov wrote: Indeed, it does. But in e.g. AwtButton::Create() it uses the same thing as a container. This code is ugly, and the Toolkit/Component.getNativeContainer() is named incorrectly. I see that this erroneous pattern comes from the Windows implementation,

Re: [8] Review request for CR 8011186 [TEST_BUG] java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java failed on windows 8

Oh, of course http://cr.openjdk.java.net/~kshefov/8011186/webrev.01/ On 23-Apr-13 19:39, Anthony Petrov wrote: You should also rename the class itself: 40 public class OverrideRedirectWindowActivationTest { Otherwise it shouldn't e

Re: [8] Review request for CR 8011186 [TEST_BUG] java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java failed on windows 8

Looks fine to me. Thanks! -- best regards, Anthony On 04/23/2013 07:43 PM, Konstantin Shefov wrote: Oh, of course http://cr.openjdk.java.net/~kshefov/8011186/webrev.01/ On 23-Apr-13 19:39, Anthony Petrov wrote: You should also rename

Re: [8] Review request for CR 8011186 [TEST_BUG] java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java failed on windows 8

You should also rename the class itself: 40 public class OverrideRedirectWindowActivationTest { Otherwise it shouldn't even run... -- best regards, Anthony On 04/23/2013 07:13 PM, Konstantin Shefov wrote: I have renamed the test: http://cr.openjdk.java.net/~kshefov/8011186/webrev.01/

Re: [8] Review request for CR 8011186 [TEST_BUG] java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java failed on windows 8

I have renamed the test: http://cr.openjdk.java.net/~kshefov/8011186/webrev.01/ On 23-Apr-13 9:47, Anton V. Tarasov wrote: On 23.04.2013 0:03, Anthony Petrov wrote: Thanks for the clarification. Perhaps we should rename it then? Or at

Re: [8] Request for review: 7161575 [macosx] On MacOSX port java.awt.Toolkit.is/setDynamicLayout() are not consistent

Looks fine to me. -- best regards, Anthony On 04/23/2013 05:18 PM, Sergey Bylokhov wrote: Hello, Please review the fix for jdk 8. DynamicLayout functionality was added to the LWToolkit. All new methods just a stubs, because on macosx "live-resize" is always enabled. But I have doubts about isDy

Re: [8] Request for review: 7166296 closed/java/awt/Frame/DisabledParentOfToplevel/DisabledParentOfToplevel.html failed since 1.8.0b36

Hi Sergey, On 04/23/2013 04:46 PM, Sergey Bylokhov wrote: On 23.04.2013 16:24, Anthony Petrov wrote: This code path exists in order to ensure that a heavyweight component (e.g. a Button) has a valid native container to be inserted to. Obviously, the container must always reside in the same top-

[8] Request for review: 7161575 [macosx] On MacOSX port java.awt.Toolkit.is/setDynamicLayout() are not consistent

Hello, Please review the fix for jdk 8. DynamicLayout functionality was added to the LWToolkit. All new methods just a stubs, because on macosx "live-resize" is always enabled. But I have doubts about isDynamicLayoutActive. Because according to the javadoc: "Returns whether dynamic layout of Con

Re: [8] Request for review: 7166296 closed/java/awt/Frame/DisabledParentOfToplevel/DisabledParentOfToplevel.html failed since 1.8.0b36

On 23.04.2013 16:24, Anthony Petrov wrote: This code path exists in order to ensure that a heavyweight component (e.g. a Button) has a valid native container to be inserted to. Obviously, the container must always reside in the same top-level window where the component itself resides. This code

Re: [8] Request for review: 7166296 closed/java/awt/Frame/DisabledParentOfToplevel/DisabledParentOfToplevel.html failed since 1.8.0b36

This code path exists in order to ensure that a heavyweight component (e.g. a Button) has a valid native container to be inserted to. Obviously, the container must always reside in the same top-level window where the component itself resides. This code should never traverse containers in other

Re: Modal dialogs for fullscreen window

Hi, Vladimir. On 23.04.2013 14:36, Vladimir Kravets wrote: Hi Sergey, Could you please point me where I can do(add/create) this? It depends on how you write your test. Location of tests for a full screen mode: jdk/test/java/awt/FullScreen/ Location of tests for Dialogs: jdk/test/java/awt/Dialog

Re: Modal dialogs for fullscreen window

Hi Sergey, Could you please point me where I can do(add/create) this? Thanks, Vladimir 2013/4/23 Sergey Bylokhov > Hello, Vladimir. > Testcase will be welcome, since the issue was not found by our regression > tests. > > > On 23.04.2013 12:50, Anthony Petrov wrote: > >> Thanks Vladimir. The f

Re: Modal dialogs for fullscreen window

Hello, Vladimir. Testcase will be welcome, since the issue was not found by our regression tests. On 23.04.2013 12:50, Anthony Petrov wrote: Thanks Vladimir. The fix looks fine to me. We need to get at least one more review, after which I'll be able to push it to the repository. Could anyone

Re: Modal dialogs for fullscreen window

Thanks Vladimir. The fix looks fine to me. We need to get at least one more review, after which I'll be able to push it to the repository. Could anyone review this please? Here's a link to the webrev: http://vkravets.github.io/awt-fixes/8012586/webrev.00/index.html Regarding other WMs and the