Re: com.apple.eawt.Application.setOpenURIHandler does not deliver initial launch URI

2013-05-24 Thread James Tomson
Hi Anthony, Thanks for taking a look. To answer your questions, the application:openFiles and application:printFiles methods should not need similar special treatment - the passed instances should be getting implicitly retained and released by the block from my understanding, and can be queued for

Re: [8] Review request for 8013189: JMenuItems draw behind TextArea

2013-05-24 Thread Sergey Bylokhov
Hi, Anthony. Fix looks good. On 24.05.2013 19:50, Anthony Petrov wrote: On 05/24/2013 07:39 PM, Sergey Bylokhov wrote: On 24.05.2013 19:19, Anthony Petrov wrote: Hi Sergey, I don't believe so. While LWAWT toolkit uses Swing components internally, these internal components never use a real com

Re: com.apple.eawt.Application.setOpenURIHandler does not deliver initial launch URI

2013-05-24 Thread Anthony Petrov
Hi James, I like your patch. Do you know if other handlers are affected by a similar issue? In particular, the application:openFiles and application:printFiles also take references to NSObjects as their arguments. Could you please test if these handlers are affected or not? -- best regards,

Re: [8] Review request for 8013189: JMenuItems draw behind TextArea

2013-05-24 Thread Anthony Petrov
On 05/24/2013 07:39 PM, Sergey Bylokhov wrote: On 24.05.2013 19:19, Anthony Petrov wrote: Hi Sergey, I don't believe so. While LWAWT toolkit uses Swing components internally, these internal components never use a real component from the actual components hierarchy as their parent. Invalidating

hg: jdk8/awt/jdk: 8013416: Java Bean Persistence with XMLEncoder

2013-05-24 Thread sergey . malenkov
Changeset: 6b29c27d0807 Author:malenkov Date: 2013-05-24 19:41 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/6b29c27d0807 8013416: Java Bean Persistence with XMLEncoder Reviewed-by: alexsch ! src/share/classes/com/sun/beans/finder/AbstractFinder.java ! src/share/classes/co

Re: [8] Review request for 8013189: JMenuItems draw behind TextArea

2013-05-24 Thread Sergey Bylokhov
On 24.05.2013 19:19, Anthony Petrov wrote: Hi Sergey, I don't believe so. While LWAWT toolkit uses Swing components internally, these internal components never use a real component from the actual components hierarchy as their parent. Invalidating the internal components can't cause the actua

Re: [8] Review request for 7039616: java/awt/Window/TranslucentJAppletTest/TranslucentJAppletTest.java should be updated

2013-05-24 Thread Anthony Petrov
A reminder... -- best regards, Anthony On 05/21/2013 07:12 PM, Anthony Petrov wrote: Hello, Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=7039616 at: http://cr.openjdk.java.net/~anthony/8-57-translucencyTest-7039616.0/ The test now passes silently if the system does not supp

Re: [8] Review request for 8013189: JMenuItems draw behind TextArea

2013-05-24 Thread Anthony Petrov
Hi Sergey, I don't believe so. While LWAWT toolkit uses Swing components internally, these internal components never use a real component from the actual components hierarchy as their parent. Invalidating the internal components can't cause the actual components to be invalidated. Also, acco

Re: [8] Review request for 8013189: JMenuItems draw behind TextArea

2013-05-24 Thread Sergey Bylokhov
Hi, Anthony. Is our LWTextAreaPeer has the same problem? On 24.05.2013 17:44, Anthony Petrov wrote: Hello, Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=8013189 at: http://cr.openjdk.java.net/~anthony/8-58-textAreaMixing-8013189.0/ Root cause: The TextArea's parent is set a

hg: jdk8/awt/jdk: 8013437: Test sun/awt/datatransfer/SuplementaryCharactersTransferTest.java fails to compile since 8b86

2013-05-24 Thread anton . tarasov
Changeset: e8cacde33d27 Author:ant Date: 2013-05-24 18:01 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e8cacde33d27 8013437: Test sun/awt/datatransfer/SuplementaryCharactersTransferTest.java fails to compile since 8b86 Reviewed-by: alexsch ! test/sun/awt/datatransfer/Sup

[8] Review request for 8013189: JMenuItems draw behind TextArea

2013-05-24 Thread Anthony Petrov
Hello, Please review a fix for http://bugs.sun.com/view_bug.do?bug_id=8013189 at: http://cr.openjdk.java.net/~anthony/8-58-textAreaMixing-8013189.0/ Root cause: The TextArea's parent is set as a parent for internal XTextAreaPeer components, causing the parent to be invalidated when the interna