Re: [8] Review Request for JDK-8015477 Support single threaded AWT/FX mode.

Hello, Anthony. Oh, sorry, I've missed that comment. Updated the fix: http://cr.openjdk.java.net/~pchelko/8015477/webrev.02/ With best regards. Petr. On May 30, 2013, at 6:26 PM, Anthony Petrov wrote: > Hi Petr, > > Thanks for all the changes. Looks much better, indeed. However, there still

Re: com.apple.eawt.Application.setOpenURIHandler does not deliver initial launch URI

Yes, jdk7u-dev@ is the right place to request an approval. I believe we can port it right away given that 1) the fix is very simple and hence low-risk; and 2) the 7u-dev repos will soon close for stabilization before the 7u40 release. Please follow this template for your request: http://openj

Re: com.apple.eawt.Application.setOpenURIHandler does not deliver initial launch URI

Fantastic - thanks Anthony et al. for following up. I'm not quite sure of the procedure to nominate this patch for inclusion in the jdk7u sources as well - would it be helpful for me to bring this up on the jdk7u-dev list? Cheers, James On Thu, May 30, 2013 at 10:14 AM, Anthony Petrov wrote: >

hg: jdk8/awt/jdk: 8013773: requestFocusInWindow to a disabled component prevents window of getting focused

Changeset: 56512cfccef9 Author:ant Date: 2013-05-30 18:31 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/56512cfccef9 8013773: requestFocusInWindow to a disabled component prevents window of getting focused Reviewed-by: leonidr, alexsch ! src/share/classes/java/awt/Default

hg: jdk8/awt/jdk: 8013424: Regression: java.awt.datatransfer.FlavorListeners not notified on Linux/Java 7

Changeset: 8472c148688c Author:ant Date: 2013-05-30 18:23 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/8472c148688c 8013424: Regression: java.awt.datatransfer.FlavorListeners not notified on Linux/Java 7 Reviewed-by: anthony ! src/solaris/classes/sun/awt/X11/XClipboard.j

Re: [8] Review Request for JDK-8015477 Support single threaded AWT/FX mode.

Hi Petr, Thanks for all the changes. Looks much better, indeed. However, there still seems to be an issue with using inAWT in LWCToolkit.m and with the ?: operator. Please see the quote below for details. -- best regards, Anthony On 05/30/13 13:19, Petr Pchelko wrote: Hello, Thank you for t

Re: com.apple.eawt.Application.setOpenURIHandler does not deliver initial launch URI

Hi James, Thank you very much for the contribution! Your fix is now pushed to the repository: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/768fcc36182a -- best regards, Anthony On 05/29/13 01:30, James Tomson wrote: Running the Leaks instrument while triggering multiple openURIs (and openFil

hg: jdk8/awt/jdk: 8015303: [macosx] Application launched via custom URL Scheme does not receive URL

Changeset: 768fcc36182a Author:anthony Date: 2013-05-30 18:10 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/768fcc36182a 8015303: [macosx] Application launched via custom URL Scheme does not receive URL Summary: Make copies of event parameters Reviewed-by: anthony, swingle

Re: [8] Review request for 8013189: JMenuItems draw behind TextArea

Hi, Anthony, my first thought about this bug was the same as Sergey's: override isValidateRoot() in XTextArea. Unfortunately it doesn't work, and you have already explained why. Given that, the proposed change looks reasonable. Thanks, Artem On 5/24/2013 5:44 PM, Anthony Petrov wrote: Hel

Re: [8] Review Request for JDK-8015477 Support single threaded AWT/FX mode.

On 30.05.2013 13:19, Petr Pchelko wrote: Hello, Thank you for the reviews. I have updated the fix, it is now available at: http://cr.openjdk.java.net/~pchelko/8015477/webrev.01/ And the fx part: http://cr.openjdk.java.net/~pchelko/8015477/webrev.rt.01/ I have updated comments and used AWTAccess

[8] Request for review: java/awt/Focus/TypeAhead/TestFocusFreeze.java hangs with jdk8 since b56

Hello, Please, review the fix: jira: https://jbs.oracle.com/bugs/browse/JDK-8015454 webrev: http://cr.openjdk.java.net/~ant/JDK-8015454/webrev.0 It's a regression of 6981400 "Tabbing between textfield do not work properly when ALT+TAB". That fix resolved the following case: in a frame with s

Re: [8] Review request for CR 8012569 TEST_BUG: java/awt/GraphicsDevice/CheckDisplayModes.java fails

Review a test bug fix, please. On 27-May-13 19:06, Konstantin Shefov wrote: Hello, Please review a fix for the issue: 8012569 TEST_BUG: java/awt/GraphicsDevice/CheckDisplayModes.java fails Test bug fix. Move from closed to openjdk repo. http://bugs.sun.com/view_bug.do?bug_id=8012569 The web

Re: [8] Review Request for JDK-8015477 Support single threaded AWT/FX mode.

Hello, Thank you for the reviews. I have updated the fix, it is now available at: http://cr.openjdk.java.net/~pchelko/8015477/webrev.01/ And the fx part: http://cr.openjdk.java.net/~pchelko/8015477/webrev.rt.01/ I have updated comments and used AWTAccessor. Anthony wrote: > Regarding the FX part

[8] Review request for 7026679 There is no MouseClicked event after MousePressed & MouseReleased events

Hello, Could you review the fix: bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7026679 webrev: http://cr.openjdk.java.net/~alexsch/7026679/webrev.00 This is the direct fix proposed in the issue. XWindow keep track of button press-releases within the mouseButtonClickAllowed bitma