Hi Anthony,
Thank you for the review. I initially thought I would remove XAWT_HACK
from makefiles, but noticed XAWT was still there as well. So I just left
the compiler flag as it was. I think it's up to AWT team to remove those
flags, as I am not sure the original intention of XAWT_HACK ifdef
Changeset: a4356b90f57d
Author:vkarnauk
Date: 2013-05-31 18:46 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a4356b90f57d
7068740: If you wrap a JTable in a JLayer you can't use the page up and page
down cmds
Reviewed-by: alexsch, alexp
! src/share/classes/javax/swing/pla
Hello, Jose, Anthony.
Fix looks good.
On 31.05.2013 18:33, Anthony Petrov wrote:
A reminder for awt-dev@ folks...
--
best regards,
Anthony
On 05/29/2013 01:57 PM, Anthony Petrov wrote:
Thank you, Jose. Here's an updated webrev:
http://cr.openjdk.java.net/~anthony/8-59-windowClosedEvents-8015
A reminder for awt-dev@ folks...
--
best regards,
Anthony
On 05/29/2013 01:57 PM, Anthony Petrov wrote:
Thank you, Jose. Here's an updated webrev:
http://cr.openjdk.java.net/~anthony/8-59-windowClosedEvents-8015500.1/
The fix still looks fine to me.
Could anyone else review it please?
--
be
Changeset: 611f8664c96c
Author:malenkov
Date: 2013-05-31 18:25 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/611f8664c96c
8013557: XMLEncoder in 1.7 can't encode objects initialized in no argument
constructor
Reviewed-by: alexsch
! src/share/classes/java/beans/XMLEncoder.
Hi Anton,
My knowledge of the focus machinery is limited, but according to your
description of the problem, the main issue here is that we re-post
window events to the end of the queue as opposed to re-posting them to a
specific position in the queue.
In other words my question is: can we mo
Looks fine.
--
best regards,
Anthony
On 05/31/2013 04:39 PM, Anton V. Tarasov wrote:
Hello,
Please, review a doc typo correction:
jira: https://jbs.oracle.com/bugs/browse/JDK-8015339
webrev: http://cr.openjdk.java.net/~ant/JDK-8015339/webrev.0
"with" is replaced with "will" in the sentence.
+1
Thanks,
Artem
On 5/31/2013 4:39 PM, Anton V. Tarasov wrote:
Hello,
Please, review a doc typo correction:
jira: https://jbs.oracle.com/bugs/browse/JDK-8015339
webrev: http://cr.openjdk.java.net/~ant/JDK-8015339/webrev.0
"with" is replaced with "will" in the sentence.
Thanks,
Anton.
Hello,
Please, review a doc typo correction:
jira: https://jbs.oracle.com/bugs/browse/JDK-8015339
webrev: http://cr.openjdk.java.net/~ant/JDK-8015339/webrev.0
"with" is replaced with "will" in the sentence.
Thanks,
Anton.
Changeset: 481476e941fd
Author:ant
Date: 2013-05-31 15:56 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/481476e941fd
8015589: Test java/awt/Window/Grab/GrabTest.java fails on MacOSX
Reviewed-by: anthony
! test/java/awt/Window/Grab/GrabTest.java
Looks fine.
--
best regards,
Anthony
On 05/31/2013 03:40 PM, Anton V. Tarasov wrote:
Hello,
Please, review the fix:
jira: https://jbs.oracle.com/bugs/browse/JDK-8015589
webrev: http://cr.openjdk.java.net/~ant/JDK-8015589/webrev.0
The test failed because mouse click didn't happen outside the
Hi Alexander,
I'm concerned with this fix. A toolkit usually captures the mouse
pointer upon a PRESS event, and releases the capture upon a RELEASE
event. This ensures that it will in fact receive the corresponding
RELEASE event. It's important that the RELEASE event gets delivered to
the sam
Hello,
Please, review the fix:
jira: https://jbs.oracle.com/bugs/browse/JDK-8015589
webrev: http://cr.openjdk.java.net/~ant/JDK-8015589/webrev.0
The test failed because mouse click didn't happen outside the frame on
Mac as it was expected.
I indented a little further.
Thanks,
Anton.
Hi Naoto,
I'm not an expert in this code, but the changes look good to me.
Should we also remove the definition of the XAWT_HACK symbol from our
makefiles if we don't use it anymore (this needs to be checked though)?
--
best regards,
Anthony
On 05/30/2013 03:31 AM, Naoto Sato wrote:
Hello,
Changeset: b0eab0f8b503
Author:anthony
Date: 2013-05-31 14:12 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b0eab0f8b503
8013189: JMenuItems draw behind TextArea
Summary: Untie XTextAreaPeer internal components from the TextArea parent to
prevent its invalidation. I.e. for
Looks great now. Thanks!
--
best regards,
Anthony
On 05/31/2013 10:08 AM, Petr Pchelko wrote:
Hello, Anthony.
Oh, sorry, I've missed that comment. Updated the fix:
http://cr.openjdk.java.net/~pchelko/8015477/webrev.02/
With best regards. Petr.
On May 30, 2013, at 6:26 PM, Anthony Petrov wrot
Please, review a test bug fix
On 18-Mar-13 16:46, Konstantin Shefov wrote:
Reminder
On 12-Feb-13 18:23, Konstantin Shefov wrote:
Hello,
Please review a fix for the issue:
8004693 - TEST_BUG:
java/awt/KeyboardFocusmanager/DefaultPolicyChange/DefaultPolicyChange_Swing.java
fails
The webrev i
17 matches
Mail list logo
