[8] Request for review: JDK-8016555: Regression: Focus issues with Oracle WebCenter Capture applet

2013-06-13 Thread Anton V. Tarasov
Hello, Please, review the fix. jira: https://jbs.oracle.com/bugs/browse/JDK-8016555 webrev: http://cr.openjdk.java.net/~ant/JDK-8014821/webrev.0 It's reproducible in the applet mode only, on Windows. When an applet is focused and then a new frame pops up, it doesn't get focus. The reason of

hg: jdk8/awt/jdk: 6847588: AWT test fails

2013-06-13 Thread mikhail . cherkasov
Changeset: 6e5824a42c49 Author:alitvinov Date: 2013-06-13 18:46 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/6e5824a42c49 6847588: AWT test fails Reviewed-by: anthony, serb ! src/solaris/classes/sun/awt/X11/XKeyboardFocusManagerPeer.java

Re: [8] Review request for 6847588: AWT test fails

2013-06-13 Thread Anton Litvinov
Hello Anthony and Sergey, Thank you for approval of this version of the fix and this e-mail which unambiguously states that the fix passed the review process. Thank you, Anton On 6/13/2013 6:06 PM, Anthony Petrov wrote: Anton: please note that we're not suggesting you to remove the TTP in yo

Re: [8] Review request for 6847588: AWT test fails

2013-06-13 Thread Anthony Petrov
Anton: please note that we're not suggesting you to remove the TTP in your fix. This will be resolved separately under another bug. Please consider your current fix reviewed and approved. -- best regards, Anthony On 06/13/13 18:03, Sergey Bylokhov wrote: Well you convinced me always to use AW

Re: [8] Review request for 6847588: AWT test fails

2013-06-13 Thread Sergey Bylokhov
Well you convinced me always to use AWTAccessor and to remove TTP. On 13.06.2013 15:43, Anthony Petrov wrote: Hi Anton, Indeed, this looks like another valid reason to stick with the AWTAccessor.getPeer in this case. So I'm still supporting your original fix. -- best regards, Anthony On 06

Re: [8] Review request for 6847588: AWT test fails

2013-06-13 Thread Anthony Petrov
Hi Sergey, Please find replies to all your messages below. On 06/11/13 17:49, Sergey Bylokhov wrote: On 11.06.2013 17:21, Anthony Petrov wrote: On 06/11/2013 03:31 PM, Sergey Bylokhov wrote: On 11.06.2013 15:04, Anthony Petrov wrote: I don't see how "TTP is widely used." Here's what I actual

Re: [8] Review request for 6847588: AWT test fails

2013-06-13 Thread Anthony Petrov
Hi Anton, Indeed, this looks like another valid reason to stick with the AWTAccessor.getPeer in this case. So I'm still supporting your original fix. -- best regards, Anthony On 06/13/13 12:39, Anton Litvinov wrote: Hello Sergey and Anthony, Thank you very much for review of this fix. Antho

Re: CFV: New AWT group member: Petr Pchelko

2013-06-13 Thread Alexander Scherbatiy
Vote: YES On 6/11/2013 6:06 PM, Artem Ananiev wrote: I hereby nominate Petr Pchelko (OpenJDK user name: pchelko) to membership in the AWT Group. Petr is a Committer in JDK8 project. He is an active contributor in AWT and OpenJFX: http://hg.openjdk.java.net/jdk8/awt/jdk/log?rev=pchelko ht

Re: [8] Review request for 6847588: AWT test fails

2013-06-13 Thread Sergey Bylokhov
On 11.06.2013 17:21, Anthony Petrov wrote: On 06/11/2013 03:31 PM, Sergey Bylokhov wrote: On 11.06.2013 15:04, Anthony Petrov wrote: In (X)KFMPeer.java we know we always operate on Window instances. The setCurrentFocusedWindow(Window) method will never be called with any other components. There

Re: [8] Review request for 6847588: AWT test fails

2013-06-13 Thread Anton Litvinov
Hello Sergey and Anthony, Thank you very much for review of this fix. Anthony, thank you for approval of the current version of the fix and defending your position concerning appropriateness of usage of "sun.awt.AWTAccessor.ComponentAccessor.getPeer" method in this case. Since there was not

hg: jdk8/awt/jdk: 8013468: [macosx] Cursor does not update properly when in fullscreen mode on Mac

2013-06-13 Thread petr . pchelko
Changeset: a7d943998bd3 Author:pchelko Date: 2013-06-13 11:10 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a7d943998bd3 8013468: [macosx] Cursor does not update properly when in fullscreen mode on Mac Reviewed-by: anthony, serb ! src/macosx/classes/sun/lwawt/macosx/CPlatf