Re: Preedit string is still exist after focus change operation

2013-07-01 Thread Naoto Sato
Hi Deven, Looks like the webrev link is broken. Anyway, I briefly looked at the original webrev (embedded down below). I believe that the endComposition on switching the focus to different input context should work on any platforms that Java supports (does not matter the pre-edit is discarded

Re: [8] Review request for 8015730: PIT: On Linux, OGL=true and fbobject=false leads to deadlock or infinite loop

2013-07-01 Thread Anthony Petrov
Thanks for the additional information, Anton. Since this fix simply reverts the behavior in GLXSurfaceData.c back to the pre-8005607 era, it could probably be considered a good interim solution for the problem. I'd like to hear Artem's opinion on this, though. Should we file a P4 bug to invest

Re: [8] Review request for 8015730: PIT: On Linux, OGL=true and fbobject=false leads to deadlock or infinite loop

2013-07-01 Thread Anton Litvinov
Hello Anthony, Thank you for the review of this fix. I would like to remark that this deadlock is a regression of the fix for the bug 8005607, and in the code of the file "jdk/src/solaris/native/sun/java2d/opengl/GLXSurfaceData.c" before 8005607 fix, where the previous XError handling mechanis

Re: [8] Review request for CR 7105119 - [TEST_BUG] [macosx] In test UIDefaults.toString() mast be called with the invokeLater()

2013-07-01 Thread Alexander Scherbatiy
The JDK 8 version of the fix: http://cr.openjdk.java.net/~kshefov/7105119/webrev.01 has been already reviewed on the swing-dev alias: http://mail.openjdk.java.net/pipermail/swing-dev/2013-February/002577.html Thanks, Alexandr. On 6/18/2013 2:09 PM, Konstantin Shefov wrote: Hello, Pl

Re: [8] Review request for 8015730: PIT: On Linux, OGL=true and fbobject=false leads to deadlock or infinite loop

2013-07-01 Thread Anthony Petrov
Hi Anton, I'm not sure if this a good fix since it enabled the GL thread to call Xlib APIs w/o acquiring the AWTLock. This may not present a problem currently since we know exactly when this method is called and that another thread is holding the lock and isn't calling other X11 functions at