On Jul 9, 2013, at 6:38 PM, Artem Ananiev wrote:
>
> On 7/8/2013 8:35 PM, Leonid Romanov wrote:
>> I encountered the case of unset handlerContext while testing SwingSet3 Web
>> Start app. It is triggered by selecting SwingSet3->About from the global
>> menu bar. Since SwingSet3 doesn't use e
Thanks Michael and Pete for review and approval.
Alexandr,
Can you please review / approve it.
Thanks,
Ragini.
On 7/10/2013 12:49 PM, Michael Fang wrote:
Thanks so much Ragini. The webrevs look good.
thanks,
-michael
On 07/10/13 12:40, Ragini Prasad wrote:
Hi Michael,
Ive added for translat
Oh. Sorry. I was looking to another fix and looks like I forgot to revert the
changes. I won't push the changes from AWTView.m
With best regards. Petr.
On Jul 10, 2013, at 9:50 PM, Anthony Petrov wrote:
> Hi Petr,
>
> The fix looks fine now. Thank you.
>
> However, you've added a change in A
Thanks. Consider the rest of the fix approved by me then.
--
best regards,
Anthony
On 07/10/2013 09:52 PM, Petr Pchelko wrote:
Oh. Sorry. I was looking to another fix and looks like I forgot to revert the
changes. I won't push the changes from AWTView.m
With best regards. Petr.
On Jul 10, 20
Hi Petr,
The fix looks fine now. Thank you.
However, you've added a change in AWTView.m. Is it intentional? I'm not
sure if this has any relation to the crash we're fixing.
--
best regards,
Anthony
On 07/10/2013 07:29 PM, Petr Pchelko wrote:
Hello, Anthony.
I've updated the fix again. Now
Hello, Anthony.
I've updated the fix again. Now we always use GC.
The new version is available here:
http://cr.openjdk.java.net/~pchelko/8020210/webrev.02/
With best regards. Petr.
On Jul 10, 2013, at 4:22 PM, Anthony Petrov wrote:
> Thanks for the update. One more suggestion:
>
>> 481
Hello Anthony,
Thank you for review of this fix and for these remarks. I think that it
is better to make macros return values, then to rename them to STORE_*,
because it will reduce the number of parameters of the macros and make
them clear. Yes, sure, I can file a separate bug for changing of
Thanks for the update. One more suggestion:
481 Insets i =
((CGraphicsDevice)getGraphicsDevice()).getScreenInsets();
482 Rectangle toBounds =
getPeer().getGraphicsConfiguration().getBounds();
Perhaps we should get the GC first, and then use gc.getDevice() instead
Hello, Anthony.
> Does getGraphicsDevice() always return a non-null value?
Yes. If there's no device it returns the default one.
> A specific GC is always associated with a window. Why do we use the default
> one then?
You are right. That's a bug.
> After removing CWrapper.NSWindow.screen(), do
Hi Petr,
A few questions:
Does getGraphicsDevice() always return a non-null value?
A specific GC is always associated with a window. Why do we use the
default one then?
After removing CWrapper.NSWindow.screen(), do we still use any of the
CWrapper.NSScreen methods?
--
best regards,
Anthon
Hello, AWT Team.
Please review the fix for the following issue:
http://bugs.sun.com/view_bug.do?bug_id=8020210
The fix is available at:
http://cr.openjdk.java.net/~pchelko/8020210/webrev.00/
In case the window is offscreen the [NSWindow screen] method could return null,
so we crashed in CFRetain
11 matches
Mail list logo
