Changeset: f7ea38893138
Author:serb
Date: 2013-07-12 21:33 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f7ea38893138
8020298: [macosx] Incorrect merge in the lwawt code
Reviewed-by: art, anthony
! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java
On 7/12/2013 4:02 PM, Anton Litvinov wrote:
Hello Anthony,
Thank you very much for review of the fix. Yes, sure, the comment
stating that XSync() function is intentionally called without AWT lock
is added to the file "GLXSurfaceData.c". A URL of the new version of the
fix with this change is pr
Looks fine.
Thanks,
Artem
On 7/12/2013 6:36 PM, Sergey Bylokhov wrote:
Hello,
Please review the fix for jdk 7/8.
The problem is in incorrect merge between 8009012 and 8003559.
I remove part(optimization) of the 8009012, because it was merged
incorrectly and because it require additional testi
Both fixes look fine to me.
--
best regards,
Anthony
On 07/12/2013 06:36 PM, Sergey Bylokhov wrote:
Hello,
Please review the fix for jdk 7/8.
The problem is in incorrect merge between 8009012 and 8003559.
I remove part(optimization) of the 8009012, because it was merged
incorrectly and because
Hello,
Please review the fix for jdk 7/8.
The problem is in incorrect merge between 8009012 and 8003559.
I remove part(optimization) of the 8009012, because it was merged
incorrectly and because it require additional testing after cpu merge.
Also a call to flushBuffers was removed, when the peer
Still looks fine to me.
Thanks,
Artem
On 7/12/2013 5:16 PM, Petr Pchelko wrote:
Hello, Anthony.
The fix looks good to me. BTW, could we provide some meaningful message with the
InvalidDnDOperationException ? E.g. state that it's unsupported for this window or something like
this? Also, th
Looks fine to me. Thanks.
--
best regards,
Anthony
On 07/12/2013 05:16 PM, Petr Pchelko wrote:
Hello, Anthony.
The fix looks good to me. BTW, could we provide some meaningful message with the
InvalidDnDOperationException ? E.g. state that it's unsupported for this window or something like
t
Hello, Anthony.
> The fix looks good to me. BTW, could we provide some meaningful message with
> the InvalidDnDOperationException ? E.g. state that it's unsupported for this
> window or something like this? Also, the comments "// Unsupported" after the
> if()return; could be better worded as "U
Looks great. Thanks.
--
best regards,
Anthony
On 07/12/2013 04:02 PM, Anton Litvinov wrote:
Hello Anthony,
Thank you very much for review of the fix. Yes, sure, the comment
stating that XSync() function is intentionally called without AWT lock
is added to the file "GLXSurfaceData.c". A URL of
Hello Anthony,
Thank you very much for review of the fix. Yes, sure, the comment
stating that XSync() function is intentionally called without AWT lock
is added to the file "GLXSurfaceData.c". A URL of the new version of the
fix with this change is provided below.
441 // Call XSync witho
Changeset: c3268a602a50
Author:raginip
Date: 2013-07-12 14:46 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c3268a602a50
8009168: accessibility.properties syntax issue
Reviewed-by: ptbrunet, mfang, alexsch
!
src/share/classes/com/sun/accessibility/internal/resources/acces
Hi Anton,
The updated fix looks fine to me. Thank you.
Just a minor suggestion: could you please add a comment just before the
line 441 at GLXSurfaceData.c to state that this particular XSync() call
is performed w/o an AWTLock? No need to resend a new webrev for this change.
--
best regards,
12 matches
Mail list logo
