[8] Review request for 7191018: Manual test closed/java/awt/JAWT causes JVM to crash starting from JDK 5

Hello, Could you please review the following fix for a bug from AWT Native Interface area. Bug: http://bugs.sun.com/view_bug.do?bug_id=7191018 Webrev: http://cr.openjdk.java.net/~alitvinov/7191018/webrev.00 The solution is based on introduction of initialization of "jobject peer" local varia

Re: [8] Review request for 8021943: FileDialog getFile returns corrupted string after previous setFile

Hi, Alexander. Fix looks fine. On 01.08.2013 21:03, Alexander Zvegintsev wrote: Hello, Could you please review a fix for the following issue: http://bugs.sun.com/view_bug.do?bug_id=8021943 The fix is available at: http://cr.openjdk.java.net/~serb/8021943/webrev.00/ lpstrFile should be treated

hg: jdk8/awt/jdk: 8016833: Underlines and strikethrough not rendering correctly

Changeset: 27d1bdf2f7d9 Author:mcherkas Date: 2013-08-06 17:29 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/27d1bdf2f7d9 8016833: Underlines and strikethrough not rendering correctly Reviewed-by: alexsch, serb Contributed-by: anton.nashaty...@oracle.com ! src/share/classe

Re: [8] Request for review: 7124339 [macosx] setIconImage is not endlessly tolerant to the broken image-arguments

Looks good. On 8/6/2013 17:15, Sergey Bylokhov wrote: Hello, Please review the fix for jdk 8. After the fix of 6436455 we skip window's incorrect icon on all platforms. In this fix we do the same for OSX. See additional info in the bug description Input validation was removed, because it is do

[8] Request for review: 7124339 [macosx] setIconImage is not endlessly tolerant to the broken image-arguments

Hello, Please review the fix for jdk 8. After the fix of 6436455 we skip window's incorrect icon on all platforms. In this fix we do the same for OSX. See additional info in the bug description Input validation was removed, because it is done in the createFromImages() Bug: http://bugs.sun.com/b

hg: jdk8/awt/jdk: 8022247: java/awt/EventDispatchThread/LoopRobustness/LoopRobustness throws NPE

Changeset: 07abddc1d7f2 Author:leonidr Date: 2013-08-06 17:07 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/07abddc1d7f2 8022247: java/awt/EventDispatchThread/LoopRobustness/LoopRobustness throws NPE Reviewed-by: art ! test/java/awt/EventDispatchThread/LoopRobustness/LoopR

Re: [7u] Review request for 8021381: JavaFX scene included in Swing JDialog not starting from Web Start

Looks fine to me. Thanks Dmitry On 8/6/13 12:22 PM, Leonid Romanov wrote: Hello, Please review a fix for 8021381. bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8021381 webrev: http://cr.openjdk.java.net/~leonidr/8021381/webrev.00/

Re: [7u] Review request for 8021381: JavaFX scene included in Swing JDialog not starting from Web Start

Hi, Leonid, the fix looks fine. Thanks, Artem On 8/6/2013 12:22 PM, Leonid Romanov wrote: Hello, Please review a fix for 8021381. bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8021381 webrev: http://cr.openjdk.java.net/~leonidr/8021381/webrev.00/

Re: [8] Review request for 8022247: java/awt/EventDispatchThread/LoopRobustness/LoopRobustness throws NPE

Looks fine. Thanks, Artem On 8/6/2013 1:03 AM, Leonid Romanov wrote: Hello, Please review a fix for 8022247: java/awt/EventDispatchThread/LoopRobustness/LoopRobustness throws NPE . The problem is in the test: the rules regarding AppContext usage have changed since 7u25, so, because the tes

[7u] Review request for 8021381: JavaFX scene included in Swing JDialog not starting from Web Start

Hello, Please review a fix for 8021381. bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8021381 webrev: http://cr.openjdk.java.net/~leonidr/8021381/webrev.00/ Thanks, Leonid.