Re: Request for review: 7027045

So, what is the best place for webrev, if I don't have access to ftp server? I don't have possibility to set up Apache server for that. Also, maybe I'm wrong, but to view index.html on ftp, you need to download it as well. Okay, I will remove "and and" at line 2887. About tag, let me look at Jav

Re: Request for review: 7027045

Hi, Konstantin. A few comments about the fix. FooListener in a few places was changed to the {@code FooListener} but it is not equivalent. Also I suggest to remove one of "and" from the "and and" in the line 2887, because you change this line anyway. On 08.08.2013 16:54, Konstantin Perikov wro

Re: Request for review: 7027045

On 08.08.2013 16:54, Konstantin Perikov wrote: Artem, could you answer on my last question? P.S. Since, I'm newcomer, I don't have rights to push, so I need a sponsor. Who could help me? I will help to push these changes after review Thanks, Konstantin. 2013/8/8 Artem Ananiev

Re: Request for review: 7027045

Okay. I keep comment about synchronization for the "type" field and return comment style for transient field. Is Google Drive better place for it? (that's why I ask yesterday about "good" place for webrev) https://drive.google.com/folderview?id=0B4QwwAaNe6wZUWJvTE9HRG40dnM&usp=sharing Artem, coul

Re: Request for review: 7027045

Hi, Konstantin, I looked through the changes, which mostly replacements with {@code}. This part of the fix looks fine. Changing /* to /** for the "isInShow" field doesn't make sense, as this field is transient and is not serialized anyway. However, it doesn't hurt as well. Please, keep co

Request for review: 7027045

Hi, AWT team, Could you please review the fix for the following bug: *7027045: : (doc) java/awt/Window.java has several typos in javadoc* Fix for version OpenJDK8. Also, I fix some stuff and change it for {@code } The webrev is available here: http://yadi.sk/d/KHB0hBlA7gkke P.S. Since, I'm n

hg: jdk8/awt/jdk: 8013611: Modal dialog fails to obtain keyboard focus

Changeset: 903a279f1fce Author:ant Date: 2013-08-09 05:20 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/903a279f1fce 8013611: Modal dialog fails to obtain keyboard focus Reviewed-by: leonidr ! src/share/classes/java/awt/KeyboardFocusManager.java + test/java/awt/Focus/80136