Hi Petr,
Great! At least, you no longer need to kick the awt cursor machinery =)
Thanks!
Anton.
On 9/12/2013 4:58 PM, Petr Pchelko wrote:
Hello, AWT Team.
Please disregard the previous version of the fix. We've decided to change the
approach completely.
The new version of the JDK part is ava
Hello Anthony,
> Does this test have to be an applet test?
It is strange but I wasn't able to start "main/manual=yesno" test using
current jtreg; the message was:
"Test.java Error. Parse Exception: Arguments to `manual' option not
supported: yesno"
It is oddly because the repository contain
Hi, Alexander.
Looks like I found another issue in the fix.
PlatformWindow.initialize now uses target.getBounds(). But these bounds are not
verifyed against correct values(see LWWP.setBound())
We should rearrange our initialisation code.
Hi, Alexander.
The fix looks goo
Hello,
Please review the fix for jdk 8.
- Documentation updated
- Component.getPeer() replaced with AWTAccessor.
- Generics code updated.
- For some methods access was changed to weaker
- SuppressWarnings were added when needed.
Plus some small general cleanup.
Bug: http://bugs.sun.com/bu
Changeset: 3213c388740a
Author:dmarkov
Date: 2013-09-12 18:44 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/3213c388740a
8024395: Improve fix for line break calculations
Reviewed-by: alexp, alexsch
! src/share/classes/javax/swing/text/FlowView.java
! src/share/classes/java
Changeset: 6321e4429a38
Author:serb
Date: 2013-09-12 18:21 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/6321e4429a38
7124537: [macosx] Menu shortcuts for all menu items should be disabled if a
menu itself is disabled
Reviewed-by: anthony, leonidr
! src/macosx/classes/sun
Looks fine.
--
best regards,
Anthony
On 09/11/13 19:39, Sergey Bylokhov wrote:
Hello,
Please review direct forward port from jdk7u to jdk 8.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124537
Webrev can be found at: http://cr.openjdk.java.net/~serb/7124537/webrev.00/
Hi, Alexander.
The fix looks good.
On 12.09.2013 17:14, Alexander Scherbatiy wrote:
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8007219/webrev.01/
The problem was that NSWindow is created with zero bounds and then
actual bounds are set.
In this case NSWindo
Hi Alexander,
Does this test have to be an applet test? Can it be a main test instead
to eliminate the unnecessary .html file?
Also, you might want to list @bug 8024122 in the test jtreg tags as well.
--
best regards,
Anthony
On 09/09/13 15:50, alexander stepanov wrote:
Hello,
Could you pl
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8007219/webrev.01/
The problem was that NSWindow is created with zero bounds and then
actual bounds are set.
In this case NSWindow treats big bounds as zoomed state and next zoom
move the window to initial zero bou
Hi Petr,
The fix looks fine to me. Thank you.
A tiny nit at src/share/classes/sun/swing/SwingAccessor.java:
79 * Updates the JLightweight frame that it needs to update a cursor
s/Updates/Notifies/ . Also, please add a closing dot in the sentence to
avoid any potential javadoc warn
Hello, AWT Team.
Please disregard the previous version of the fix. We've decided to change the
approach completely.
The new version of the JDK part is available at:
http://cr.openjdk.java.net/~pchelko/8024170/webrev.03/
The SwingAccessor is used because Component.updateCursorImmediately is a fin
Hi Leonid,
Why not put the OS X specific logic into the LWCToolkit and set the
Toolkit.platformResources field via the AWTAccessor? This would help
avoid checking for a specific platform in our shared code.
--
best regards,
Anthony
On 09/12/13 15:30, Leonid Romanov wrote:
Yes, I'll use OSIn
Changeset: def1fa9854f7
Author:bagiras
Date: 2013-09-12 15:50 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/def1fa9854f7
7064312: Cleanup: avoid using unsafe string function
Reviewed-by: serb, pchelko
! src/windows/native/sun/windows/awt_FileDialog.cpp
! src/windows/native
Hi, Alexander.
The fix looks good.
Can you add additional comments about the new code in the AWTWindow.m.
It should describe that the native system can bring up the NSWindow to
the top even if the window is not main, and we should do some things
manually.
On 05.09.2013 18:59, Alexander Scherb
Yes, I'll use OSInfo instead. As for property file name, could you suggest a
better one?
On 12.09.2013, at 15:26, Sergey Bylokhov wrote:
> Hi, Leonid.
> i think that you can try to reuse OSInfo class.
> Also I doubt about property file name.
>
> On 12.09.2013 9:09, Leonid Romanov wrote:
>> Hi
Hi, Leonid.
i think that you can try to reuse OSInfo class.
Also I doubt about property file name.
On 12.09.2013 9:09, Leonid Romanov wrote:
Hi guys,
Could you review it, please?
Original Message
Subject: [8] Review request for 7129133: [macosx] Accelerators are
displayed as
Changeset: 04fbd34fda7b
Author:bagiras
Date: 2013-09-12 14:56 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/04fbd34fda7b
8003965: Toolkit.beep() documentation is ambiguous
Reviewed-by: anthony
! src/share/classes/java/awt/Toolkit.java
18 matches
Mail list logo
