Re: [8] Review Request: JDK-8024779 [macosx] SwingNode crashes on exit

Looks fine to me! Thanks, Anton. On 9/13/2013 4:06 PM, Petr Pchelko wrote: Hello, AWT Team. Please review the fix for the following issue: http://bugs.sun.com/view_bug.do?bug_id=8024779 (Might not be on bugs.sun.com yet) The fix is available at: http://cr.openjdk.java.net/~pchelko/8024779/webr

hg: jdk8/awt/jdk: 8015601: [macosx] Test javax/swing/JInternalFrame/InternalFrameIsNotCollectedTest.java fails on MacOS X

Changeset: 915d13946f18 Author:mcherkas Date: 2013-09-13 17:48 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/915d13946f18 8015601: [macosx] Test javax/swing/JInternalFrame/InternalFrameIsNotCollectedTest.java fails on MacOS X Reviewed-by: alexp, alexsch ! test/javax/swing

hg: jdk8/awt/jdk: 8012026: [macosx] Component.getMousePosition() does not work in an applet on MacOS

Changeset: 17cc8f13e4e7 Author:pchelko Date: 2013-09-13 18:02 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/17cc8f13e4e7 8012026: [macosx] Component.getMousePosition() does not work in an applet on MacOS Reviewed-by: anthony, serb ! make/sun/lwawt/FILES_export_macosx.gmk

hg: jdk8/awt/jdk: 8015597: [TEST_BUG] [macosx] Test closed/javax/swing/JMenuBar/4750590/bug4750590.java fails since JDK 8 b75 on MacOSX

Changeset: c8a85165b725 Author:kshefov Date: 2013-09-13 17:58 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c8a85165b725 8015597: [TEST_BUG] [macosx] Test closed/javax/swing/JMenuBar/4750590/bug4750590.java fails since JDK 8 b75 on MacOSX Reviewed-by: alexsch, serb + tes

hg: jdk8/awt/jdk: 8006087: [TEST_BUG] The BACKSPACE key doesn't work and after pressing 'cancel' and 'DONE' button, the case pass automatically.

Changeset: ad52e924c55a Author:kshefov Date: 2013-09-13 17:54 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ad52e924c55a 8006087: [TEST_BUG] The BACKSPACE key doesn't work and after pressing 'cancel' and 'DONE' button, the case pass automatically. Reviewed-by: alexsch, ser

hg: jdk8/awt/jdk: 8015453: java/awt/DataFlavor/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.java failed on windows with jdk8 since b86

Changeset: 12788c245d67 Author:pchelko Date: 2013-09-13 17:25 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/12788c245d67 8015453: java/awt/DataFlavor/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.java failed on windows with jdk8 since b86 Reviewed-by: art, serb ! src/share/clas

hg: jdk8/awt/jdk: 8015455: java/awt/dnd/DisposeFrameOnDragCrash/DisposeFrameOnDragTest.java hangs on windows

Changeset: 40fdf56c09a9 Author:pchelko Date: 2013-09-13 17:41 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/40fdf56c09a9 8015455: java/awt/dnd/DisposeFrameOnDragCrash/DisposeFrameOnDragTest.java hangs on windows Reviewed-by: serb, anthony ! src/share/classes/java/awt/dnd/

hg: jdk8/awt/jdk: 8015371: The HTML text without tags does not appear inside the WordPad application, and we try to click the button, but the case exits.

Changeset: df107b1f2f2e Author:pchelko Date: 2013-09-13 17:38 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/df107b1f2f2e 8015371: The HTML text without tags does not appear inside the WordPad application, and we try to click the button, but the case exits. Reviewed-by: ant

Re: [8] RFR: JDK-8012026 [macosx] Component.getMousePosition() does not work in an applet on MacOS

Hi, Petr. The fix looks good. On 26.08.2013 19:08, Petr Pchelko wrote: Hello, AWT Team. Please review the fix for the following issue: http://bugs.sun.com/view_bug.do?bug_id=8012026 The fix is available at: http://cr.openjdk.java.net/~pchelko/8012026/webrev.00/ MoiseInfoPeer.isWindowUnderMouse

Re: [8] Review Request: CR 8015455 java/awt/dnd/DisposeFrameOnDragCrash/DisposeFrameOnDragTest.java hangs on windows

Hi, Petr. The fix looks good. On 26.08.2013 14:55, Petr Pchelko wrote: Hello, AWT Team. This is a reminder. Could I please get a second review on this fix. With best regards. Petr. On Aug 21, 2013, at 6:37 PM, Petr Pchelko wrote: Hello, Anthony. I've updated the fix according to your comme

Re: [8] Review request for 7129133: [macosx] Accelerators are displayed as Meta instead of the Command symbol

Thanks for the updated fix. Looks fine to me. -- best regards, Anthony On 09/13/2013 05:10 PM, Leonid Romanov wrote: The main bug simply states that "accelerators are displayed as Meta instead of the Command symbol", but if you look at duplicates they are mostly concerned about displaying cor

Re: [8] RFR: JDK-8015453 java/awt/DataFlavor/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.java failed on windows with jdk8 since b86

Hi, Petr. The fix looks good. On 15.08.2013 14:22, Petr Pchelko wrote: Hello, AWT Team. Please review the following fix: http://cr.openjdk.java.net/~pchelko/8015453/webrev.00/ The bug: The test fails because of an IOException. The problem: It is a regression of the following fix: http://hg.op

Re: [8] Request for review: 7172833 For default java.awt.Toolkit impl methods java.awt.Toolkit.is/setDynamicLayout() are not consistent

The fix looks good for me. Thanks, Alexandr. On 9/13/2013 4:27 PM, Sergey Bylokhov wrote: Hello, Please review the fix for jdk 8. After the fix Toolkit.setDynamicLayout forwards call to the default toolkit like isDynamicLayoutSet. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_i

Re: [8] Review request for 7129133: [macosx] Accelerators are displayed as Meta instead of the Command symbol

The main bug simply states that "accelerators are displayed as Meta instead of the Command symbol", but if you look at duplicates they are mostly concerned about displaying correct key stroke names in tooltips. So, I think on practice we can expect that LWCToolkit have been initialized. Here is

Re: [8] RFR: JDK-8015371 The HTML text without tags does not appear inside the WordPad application, and we try to click the button, but the case exits.

Hi, Petr. The fix looks good. On 15.08.2013 12:20, Petr Pchelko wrote: Hello, AWT Team. Please review the following fix: http://cr.openjdk.java.net/~pchelko/8015371/webrev.00/ The bug: one of the regression tests fail, because of a NPE in translateTrasferable. This is a regression of the foll

Re: [8] Review request for CR 8015588 [TEST_BUG] [macosx] Test java/awt/MenuBar/MenuBarSetFont/MenuBarSetFont.java fails on MacOSX

Hi, Konstantin. The fix looks good. On 13.09.2013 15:31, Konstantin Shefov wrote: Hello, Please review a fix for the issue: 8015588 [TEST_BUG] [macosx] Test java/awt/MenuBar/MenuBarSetFont/MenuBarSetFont.java fails on MacOSX Test bug fix. http://bugs.sun.com/view_bug.do?bug_id=8015588 The

[8] Request for review: 7172833 For default java.awt.Toolkit impl methods java.awt.Toolkit.is/setDynamicLayout() are not consistent

Hello, Please review the fix for jdk 8. After the fix Toolkit.setDynamicLayout forwards call to the default toolkit like isDynamicLayoutSet. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7172833 Webrev can be found at: http://cr.openjdk.java.net/~serb/7172833/webrev.00/ -- Best regar

Re: [8] Review request for 7129133: [macosx] Accelerators are displayed as Meta instead of the Command symbol

We have multiple tests that call Toolkit.getDefaultToolkit() for exactly this purpose (to initialize the native toolkit), so I don't really see a problem here. Does an app from the bug report start to work correctly with this fix? When apps and/or AWT/Swing libs call the Toolkit.getProperties(

Re: [8] Review request for 7129133: [macosx] Accelerators are displayed as Meta instead of the Command symbol

I've implemented the approach you suggested, but it didn't pass the regression test I've written for this bug. Even though the test isn't run in headless mode, it doesn't trigger LWCToolkit initialization (you have to insert "Toolkit.getDefaultToolkit()" line to force it). So, I'm unsure whether

[8] Review Request: JDK-8024779 [macosx] SwingNode crashes on exit

Hello, AWT Team. Please review the fix for the following issue: http://bugs.sun.com/view_bug.do?bug_id=8024779 (Might not be on bugs.sun.com yet) The fix is available at: http://cr.openjdk.java.net/~pchelko/8024779/webrev.01/ The problem: SwingNode crashes on exit in case Popups or ComboBoxes are

[8] Review request for CR 8015588 [TEST_BUG] [macosx] Test java/awt/MenuBar/MenuBarSetFont/MenuBarSetFont.java fails on MacOSX

Hello, Please review a fix for the issue: 8015588 [TEST_BUG] [macosx] Test java/awt/MenuBar/MenuBarSetFont/MenuBarSetFont.java fails on MacOSX Test bug fix. http://bugs.sun.com/view_bug.do?bug_id=8015588 The webrev is: http://cr.openjdk.java.net/~kshefov/8015588/webrev.00 Thanks, Konstanti

Re: [8] Review request for CR 7020060 [TEST_BUG] java/awt/FullScreen/TranslucentWindow/TranslucentWindow.java failed

Hi, Konstantin. Fix looks good. On 13.09.2013 12:55, Konstantin Shefov wrote: Hello, Please review a fix for the issue: 7020060 [TEST_BUG] java/awt/FullScreen/TranslucentWindow/TranslucentWindow.java failed Test bug fix. http://bugs.sun.com/view_bug.do?bug_id=7020060 The webrev is: http:/

Re: [8] Request for review: 8005255 [macosx] Cleanup warnings in sun.lwawt

The fix looks good for me. Thanks, Alexandr. On 9/12/2013 6:53 PM, Sergey Bylokhov wrote: Hello, Please review the fix for jdk 8. - Documentation updated - Component.getPeer() replaced with AWTAccessor. - Generics code updated. - For some methods access was changed to weaker

[8] Review request for CR 7020060 [TEST_BUG] java/awt/FullScreen/TranslucentWindow/TranslucentWindow.java failed

Hello, Please review a fix for the issue: 7020060 [TEST_BUG] java/awt/FullScreen/TranslucentWindow/TranslucentWindow.java failed Test bug fix. http://bugs.sun.com/view_bug.do?bug_id=7020060 The webrev is: http://cr.openjdk.java.net/~kshefov/7020060/webrev.00 Thanks, Konstantin

hg: jdk8/awt/jdk: 8024170: [SwingNode] Implement cursor change

Changeset: ef2f0c15b332 Author:pchelko Date: 2013-09-13 11:58 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ef2f0c15b332 8024170: [SwingNode] Implement cursor change Reviewed-by: anthony, ant ! src/macosx/classes/sun/lwawt/LWLightweightFramePeer.java ! src/share/classes/su