Hi team , could someone review the fix
Bug : https://jbs.oracle.com/bugs/browse/JDK-8022185
Webrev :
https://github.com/srikalyc/JDKfixes/blob/master/java.awt.datatransfer.raw_unchecked_webrevwebrev.zip
Fix : raw and unchecked type warnings fix for
java.awt.datatransfe
Hi Anthony,
On 09/16/2013 03:32 PM, Anthony Petrov wrote:
> Alexander doesn't have an OpenJDK id yet. But still, having an
> additional review never hurts.
Agreed, the more reviewers the better :)
> Please feel free to push the fix listing only me as a reviewer, and let
> me know if you need any
Changeset: 8530456e0091
Author:omajid
Date: 2013-09-16 15:43 -0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/8530456e0091
8024863: X11: Support GNOME Shell as mutter
Reviewed-by: anthony
! src/solaris/classes/sun/awt/X11/XWM.java
Hi Omair,
Alexander doesn't have an OpenJDK id yet. But still, having an
additional review never hurts.
Please feel free to push the fix listing only me as a reviewer, and let
me know if you need any assistance with this.
--
best regards,
Anthony
On 09/16/2013 08:59 PM, Omair Majid wrote:
On 09/16/2013 10:02 AM, Anthony Petrov wrote:
> Hi Omair,
>
> Thanks for the patch. Looks fine to me. I've just filed a bug for this fix:
>
> 8024863: X11: Support GNOME Shell as mutter
Thanks for the review!
> Do you have commit rights for the awt-gate, or do you want me to push
> the fix for
Hi Alexander,
On 09/16/2013 10:27 AM, Alexander Zvegintsev wrote:
> The patch looks fine to me.
Thanks for the review! I wanted to credit you in the Reviewed-by line of
the commit message, but I cant find you in the census:
http://openjdk.java.net/census
Thanks,
Omair
--
PGP Key: 66484681 (htt
Changeset: 04612a52e7bd
Author:pchelko
Date: 2013-09-16 19:38 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/04612a52e7bd
8024779: [macosx] SwingNode crashes on exit
Reviewed-by: anthony, ant
! src/macosx/native/sun/awt/AWTView.m
! src/macosx/native/sun/awt/AWTWindow.m
Changeset: 4e88bf592830
Author:pchelko
Date: 2013-09-16 19:44 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/4e88bf592830
8024485: For 5-1 step: if input something into the 'File:' and 'Dir:', the dir
output isn't empty in the output window after showing and canceling the f
Changeset: 98080e9367be
Author:kshefov
Date: 2013-09-16 19:21 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/98080e9367be
8015588: [TEST_BUG] [macosx] Test
java/awt/MenuBar/MenuBarSetFont/MenuBarSetFont.java fails on MacOSX
Reviewed-by: anthony, serb
! test/java/awt/MenuBa
Changeset: 49c7d299a504
Author:kshefov
Date: 2013-09-16 19:15 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/49c7d299a504
7020060: [TEST_BUG]
java/awt/FullScreen/TranslucentWindow/TranslucentWindow.java failed
Reviewed-by: anthony, serb
! test/java/awt/FullScreen/Transluce
Hi Omair,
The patch looks fine to me.
Thanks,
Alexander.
On 09/16/2013 01:45 AM, Omair Majid wrote:
On 09/08/2013 04:11 PM, Omair Majid wrote:
Hi,
With recent versions of GNOME shell, GNOME shell sets the _NET_WM_NAME
to "GNOME Shell" instead of mutter. It's still mutter that's running,
but
Changeset: 8f5b4e7623cf
Author:ant
Date: 2013-09-16 18:00 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/8f5b4e7623cf
8022512: JLightweightFrame: the content pane should be transparent
Reviewed-by: anthony
! src/share/classes/sun/swing/JLightweightFrame.java
Hi Omair,
Thanks for the patch. Looks fine to me. I've just filed a bug for this fix:
8024863: X11: Support GNOME Shell as mutter
Do you have commit rights for the awt-gate, or do you want me to push
the fix for you?
--
best regards,
Anthony
On 09/16/13 01:45, Omair Majid wrote:
On 09/08/2
Looks fine.
--
best regards,
Anthony
On 09/15/13 19:42, Anton V. Tarasov wrote:
Hello,
Please, review the fix:
jira: https://jbs.oracle.com/bugs/browse/JDK-8024839
webrev: http://cr.openjdk.java.net/~ant/JDK-8024839/webrev.0
In unified Swing/Fx thread mode, an event should be dispatched stra
Looks fine to me. Thanks!
--
best regards,
Anthony
On 09/14/13 16:41, Anton V. Tarasov wrote:
Here's the fix with a property:
http://cr.openjdk.java.net/~ant/JDK-8022512/webrev.1
Thanks,
Anton.
On 9/11/13 1:24 PM, Anthony Petrov wrote:
Thanks for the clarification. Sounds reasonable.
--
be
Looks fine.
--
best regards,
Anthony
On 09/13/13 16:06, Petr Pchelko wrote:
Hello, AWT Team.
Please review the fix for the following issue:
http://bugs.sun.com/view_bug.do?bug_id=8024779
(Might not be on bugs.sun.com yet)
The fix is available at:
http://cr.openjdk.java.net/~pchelko/8024779/web
Thanks for the clarifications. Provided the formatting is fixed, I'm
fine with the fix.
--
best regards,
Anthony
On 09/16/13 17:36, Sergey Bylokhov wrote:
On 16.09.2013 17:08, Anthony Petrov wrote:
Hi Sergey,
1. There's some change in RepaintArea logic in LWRepaintArea.java. I'd
suggest to p
On 16.09.2013 17:08, Anthony Petrov wrote:
Hi Sergey,
1. There's some change in RepaintArea logic in LWRepaintArea.java. I'd
suggest to push these changes as a separate fix.
There are 2 changed in the file:
- javadoc
- flushOnscreenGraphics() is a static method and now it is called via
clas
Hi Sergey,
The fix looks good to me.
However, I don't quite understand why these methods should delegate to
the default toolkit. I suggest to file a separate issue and investigate
this later.
--
best regards,
Anthony
On 09/13/13 16:27, Sergey Bylokhov wrote:
Hello,
Please review the fix fo
Changeset: a46d22ee4d4b
Author:alexsch
Date: 2013-09-16 17:45 +0400
URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a46d22ee4d4b
8008728: [macosx] Swing. JDialog. Modal dialog goes to background
Reviewed-by: serb
! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java
! src/mac
Looks fine.
--
best regards,
Anthony
On 09/13/13 15:31, Konstantin Shefov wrote:
Hello,
Please review a fix for the issue:
8015588 [TEST_BUG] [macosx] Test
java/awt/MenuBar/MenuBarSetFont/MenuBarSetFont.java fails on MacOSX
Test bug fix.
http://bugs.sun.com/view_bug.do?bug_id=8015588
The w
Looks fine.
--
best regards,
Anthony
On 09/13/13 12:55, Konstantin Shefov wrote:
Hello,
Please review a fix for the issue:
7020060 [TEST_BUG]
java/awt/FullScreen/TranslucentWindow/TranslucentWindow.java failed
Test bug fix.
http://bugs.sun.com/view_bug.do?bug_id=7020060
The webrev is: http
Hi Sergey,
1. There's some change in RepaintArea logic in LWRepaintArea.java. I'd
suggest to push these changes as a separate fix.
2. LWWindowPeer.java
46 public enum PeerType {
Why should it not be static?
3.
132 LWWindowPeer ownerPeer = (owner != null) ? (LWWindowPeer)
AW
Hi Alexander,
Indeed, the jtreg FAQ [1] only mentions applet/manual tests. I'm OK with
your fix then. Thanks for adding a test for this bug.
[1] http://openjdk.java.net/jtreg/faq.html
--
best regards,
Anthony
On 09/13/13 10:28, alexander stepanov wrote:
Hello Anthony,
> Does this test ha
Looks fine.
--
best regards,
Anthony
On 09/10/13 11:12, Petr Pchelko wrote:
Hello, AWT Team.
Please review a one-liner for the following issue:
http://bugs.sun.com/view_bug.do?bug_id=8024485
The fix is available at:
http://cr.openjdk.java.net/~pchelko/8024485/webrev/
It's a fix for a regressi
Hi Alexander,
Does the test test/java/awt/Frame/HideMaximized/HideMaximized.java pass
with this fix?
If in your test (MaximizedToMaximized) you exchange the setBounds() and
setVisible(true) lines, does it still pass?
If both answers are "yes", then I'm OK with your fix.
--
best regards,
An
Hi Alexander,
The fix looks good overall. A couple of minor issues:
src/macosx/native/sun/awt/AWTWindow.m
369 if(!self.isEnabled){
Please add missing spaces.
377 "checkBlockingAndOrder", "()Z");
378 JNFCallVoidMethod(env, platformWindow
The fix looks good!
Thank you.
On Sep 13, 2013, at 12:22 AM, Sergey Bylokhov
wrote:
> Hi, Alexander.
> Looks like I found another issue in the fix.
> PlatformWindow.initialize now uses target.getBounds(). But these bounds are
> not verifyed against correct values(see LWWP.setBound())
> We sh
28 matches
Mail list logo
