Re: [8] review request JDK-8019282 keyRelesed is reached even though key was NOT released

2013-09-20 Thread Alexander Zvegintsev
Hi Anthony, Sergey, Did you run KeyEvent regression tests with your fix (both open and closed)? Also, perhaps TextArea/TextEdit tests (from both AWT and Swing) might be worth running as well. I did, and I didn't found any new failures (on Ubuntu 12.04 at least). I suggest to build it on jprt

Re: [8] review request JDK-8019282 keyRelesed is reached even though key was NOT released

2013-09-20 Thread Sergey Bylokhov
Hi, Alexander. The fix looks good. On 20.09.2013 20:27, Alexander Zvegintsev wrote: Hi Anthony, Sergey, Did you run KeyEvent regression tests with your fix (both open and closed)? Also, perhaps TextArea/TextEdit tests (from both AWT and Swing) might be worth running as well. I did, and I did

hg: jdk8/awt/jdk: 7024235: Nimbus L&F: wrong "packing" of a frame containing tabbed pane

2013-09-20 Thread sergey . malenkov
Changeset: abebe03818f6 Author:malenkov Date: 2013-09-20 18:56 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/abebe03818f6 7024235: Nimbus L&F: wrong "packing" of a frame containing tabbed pane Reviewed-by: alexsch ! src/share/classes/javax/swing/plaf/basic/BasicTabbedPaneU

[8] Review request for 8025145: MacOSX: java 7 does not recognize tiff image on clipboard

2013-09-20 Thread anton nashatyrev
Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~vkarnauk/8025145/jdk8/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8025145 Problem: it looks like the TIFF format is popular i

Re: [8] Review request for CR 7125471: [macosx] NofocusListDblClickTest should wait between doublr clicks

2013-09-20 Thread Anthony Petrov
Thank you. The fix looks good to me. -- best regards, Anthony On 09/20/2013 06:14 PM, vera akulova wrote: Hi Antony, The diff is http://cr.openjdk.java.net/~kshefov/7125471/webrev.diff/ Thanks, Vera 20.09.2013 17:11, Anthony Petrov

Re: [8] Review request for CR 7125471: [macosx] NofocusListDblClickTest should wait between doublr clicks

2013-09-20 Thread vera akulova
Hi Antony, The diff is http://cr.openjdk.java.net/~kshefov/7125471/webrev.diff/ Thanks, Vera 20.09.2013 17:11, Anthony Petrov пишет: Hi Vera, Could you publish some diffs with the original test case please? -- best regards, Antho

Re: [8] Review request for 8004050: [macosx] The 'ESC' key does not work with jdk8

2013-09-20 Thread Sergey Bylokhov
cc swing-dev. On 20.09.2013 13:44, Leonid Romanov wrote: Hello, Please, review a fix for 8004050: [macosx] The 'ESC' key does not work with jdk8 Bug: https://bugs.openjdk.java.net/browse/JDK-8004050 Webrev: http://cr.openjdk.java.net/~leonidr/8004050/webrev.00/ Thanks, Leonid. -- Best rega

hg: jdk8/awt/jdk: 7124232: [TEST_BUG] [macosx] JSplitPane has wrong divider location

2013-09-20 Thread konstantin . shefov
Changeset: f139aef966fd Author:kshefov Date: 2013-09-20 17:35 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/f139aef966fd 7124232: [TEST_BUG] [macosx] JSplitPane has wrong divider location Reviewed-by: alexsch, serb Contributed-by: vera.akul...@oracle.com + test/javax/swing

hg: jdk8/awt/jdk: 8017180: [macosx] [TEST_BUG] alt-key doesn't work on macos for menu

2013-09-20 Thread konstantin . shefov
Changeset: 6c1f9468f3de Author:kshefov Date: 2013-09-20 17:16 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/6c1f9468f3de 8017180: [macosx] [TEST_BUG] alt-key doesn't work on macos for menu Reviewed-by: alexsch, serb Contributed-by: vera.akul...@oracle.com + test/java/awt/

Re: RFR(L): 8024854: Basic changes and files to build the class library on AIX

2013-09-20 Thread Chris Hegarty
Volker, I skimmed over the networking part of the changes, and nothing jumps out at me. I'd like to spend a little more time doing a more detailed review, but I will not have time to do this until after JavaOne. -Chris. On 09/16/2013 08:30 PM, Volker Simonis wrote: Resending this to more li

Re: [8] Review request for CR 7125471: [macosx] NofocusListDblClickTest should wait between doublr clicks

2013-09-20 Thread Anthony Petrov
Hi Vera, Could you publish some diffs with the original test case please? -- best regards, Anthony On 09/20/2013 04:59 PM, vera akulova wrote: Hello, Please review a fix for the issue: JDK-7125471 : [macosx] NofocusListDblClickTest should wait

hg: jdk8/awt/jdk: 7124314: [TEST_BUG] [macosx] Aqua LAF: JTree doesn't select element by keyboards left and right keys

2013-09-20 Thread konstantin . shefov
Changeset: c04e55e17066 Author:kshefov Date: 2013-09-20 17:07 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c04e55e17066 7124314: [TEST_BUG] [macosx] Aqua LAF: JTree doesn't select element by keyboards left and right keys Reviewed-by: alexsch, serb Contributed-by: vera.aku

[8] Review request for CR 7125471: [macosx] NofocusListDblClickTest should wait between doublr clicks

2013-09-20 Thread vera akulova
Hello, Please review a fix for the issue:     JDK-7125471: [macosx] NofocusListDblClickTest should wait between doublr clicks The webrev is http://cr.openjdk.java.net/~kshefov/7125471/webrev.00/ The fix adds delay between double click

[8] Review request for 8004050: [macosx] The 'ESC' key does not work with jdk8

2013-09-20 Thread Leonid Romanov
Hello, Please, review a fix for 8004050: [macosx] The 'ESC' key does not work with jdk8 Bug: https://bugs.openjdk.java.net/browse/JDK-8004050 Webrev: http://cr.openjdk.java.net/~leonidr/8004050/webrev.00/ Thanks, Leonid.

Re: [8] Review request for 8007155 [macosx] Disabled panel takes mouse input in JLayeredPane

2013-09-20 Thread Anthony Petrov
Hi Alexander, The fix looks fine to me, too. -- best regards, Anthony On 09/19/2013 10:29 PM, Sergey Bylokhov wrote: Hi, Alexander. The fix looks good. On 19.09.2013 16:08, Alexander Scherbatiy wrote: Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8007155/webrev