hg: jdk8/awt/jdk: 7117595: ArrayIndexOutOfBoundsException in Win32GraphicsEnvironment if display is removed

Changeset: 0042f54f65d0 Author:malenkov Date: 2013-09-27 22:25 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/0042f54f65d0 7117595: ArrayIndexOutOfBoundsException in Win32GraphicsEnvironment if display is removed Reviewed-by: anthony, serb ! src/macosx/classes/sun/awt/CGra

hg: jdk8/awt/jdk: 8012716: java.beans.EventHandler.create method should check if the given listenerInterface is a public interface

Changeset: bfff9e9120ec Author:malenkov Date: 2013-09-27 22:17 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/bfff9e9120ec 8012716: java.beans.EventHandler.create method should check if the given listenerInterface is a public interface Reviewed-by: art, mchung ! src/share/

Re: [8] Review request for 7117595: ArrayIndexOutOfBoundsException in Win32GraphicsEnvironment if display is removed

Hello. The fix looks good. On 26.09.2013 17:54, sergey malenkov wrote: Could you please review the following fix: http://cr.openjdk.java.net/~malenkov/7117595.8.3/ Every getDefaultScreenDevice method throws a commented error. It is better

Re: [8] Review request for 8023994: Right click on the icon added to the system tray for the first time, java.lang.IllegalArgumentException thrown.

Yes, this code looked suspicious for me as well, I suspect it is a result of copy pasting XWindow's dispose() code. For a wrong peer/target pair, XToolkit.targetDisposedPeer() is a no-op, so no harm is done, but perhaps it makes sense to remove that call altogether. I'll check it. On Sep 27,

Re: [8] Review request for 8023994: Right click on the icon added to the system tray for the first time, java.lang.IllegalArgumentException thrown.

Hi, Leonid. In this case the code in the XBaseMenuWindow.doDispose() call XToolkit.targetDisposedPeer(target, this); for the wrong target? Or probably this target is alwase null? On 27.09.2013 20:32, Leonid Romanov wrote: Hello, Please review a fix for 8023994: Right click on the icon added t

Re: [8] Review request 7059886: 6 JCK manual awt/Desktop tests fail with GTKLookAndFeel - GTK intialization issue

Anthony, please see inline: On 09/27/2013 06:25 PM, Anthony Petrov wrote: Hi Alexander, How about getAndSetInitializationNeededFlag ? 74 * If it returns {@code false} user must call g_thread_init() on his own. "on their own"? :) Yet, it might be better phrased as: "A return value o

[8] Review request for 7081584: Specification for Window.isAlwaysOnTopSupported needs to be clarified

Hello, Could you please review the following fix: fix:http://cr.openjdk.java.net/~malenkov/7081584.8.0/ bug:https://bugs.openjdk.java.net/browse/JDK-7081584 The specification of the Window class waits for CCC approval. This fix removes the getTookit method from the ComponentPeer class and its

[8] Review request for 8023994: Right click on the icon added to the system tray for the first time, java.lang.IllegalArgumentException thrown.

Hello, Please review a fix for 8023994: Right click on the icon added to the system tray for the first time, java.lang.IllegalArgumentException thrown. The problem here is that for popup menus the "target" field of XBaseMenuWindow class is not a MenuComponent corresponding to the popup, but a co

Re: [8] Review request for 8025225: Window.setAlwaysOnTop documentation should be updated

On 9/27/2013 6:04 PM, Alexander Zvegintsev wrote: Hi Anthony, Artem, Here is updated webrev: http://cr.openjdk.java.net/~serb/alexz/8025225/webrev.01/ Looks good (I'm not a native speaker, though). Thanks, Artem Thanks, Alexander. On 09/26/2013 05:22 PM, Artem Ananiev wrote: On 9/24/

Re: [8] Review request for 8020688: broken links in documentation at http://docs.oracle.com/javase/6/docs/api/index.

Anthony thank you for this link, it's good replacement for removed link. Also I didn't find replacement for : - * Also see the article href="http://java.sun.com/products/jfc/tsc/tech_topics/jlist_1/jlist.html";>Advanced JList Programming - * in http://java.sun.com/products/jfc/tsc";>The Swing C

[8] Review Request: JDK-8025585 Win: Popups in JFXPanel do not receive MouseWheel events

Hello, AWT Team. Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8025585 The fix is available at: http://cr.openjdk.java.net/~pchelko/8025585/webrev.00/ The fix is needed for JFXPanel support. We need to redispatch MOUSEWHEEL messages to the window under mouse. In c

hg: jdk8/awt/jdk: 8016563: Test closed/java/awt/dnd/ImageTransferTest/ImageTransferTest.html fails

Changeset: 260bc59ca253 Author:pchelko Date: 2013-09-27 18:35 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/260bc59ca253 8016563: Test closed/java/awt/dnd/ImageTransferTest/ImageTransferTest.html fails Reviewed-by: anthony, serb ! src/share/classes/sun/awt/datatransfer/Dat

Re: [8] Review Request: JDK-8025440 [TEST_BUG] com/sun/awt/SecurityWarning/GetSizeShouldNotReturnZero.java failed since jdk8b108

Hello, Anthony. I've updated the fix: http://cr.openjdk.java.net/~pchelko/8025440/webrev.01/ Now the CopyClassFile utility is also copying the inner classes. It also supports class name in different packages. With best regards. Petr. On Sep 27, 2013, at 4:05 PM, Petr Pchelko wrote: > Hello,

Re: [8] Review request for 8020688: broken links in documentation at http://docs.oracle.com/javase/6/docs/api/index.

On 09/27/2013 06:19 PM, mikhail cherkasov wrote: Anthony, some links, like this one, we lost for ever. How about http://docs.oracle.com/javase/tutorial/uiswing/events/actionlistener.html ? On 27.09.2013 18:12, Anthony Petrov wrote: Thanks. I skimmed through the changes and they look good

Re: [8] Review request 7059886: 6 JCK manual awt/Desktop tests fail with GTKLookAndFeel - GTK intialization issue

Hi Alexander, How about getAndSetInitializationNeededFlag ? 74 * If it returns {@code false} user must call g_thread_init() on his own. "on their own"? :) Yet, it might be better phrased as: "A return value of {@code false} indicates that the calling code should call the g_thread_ini

Re: [8] Review request for 8020688: broken links in documentation at http://docs.oracle.com/javase/6/docs/api/index.

Anthony, some links, like this one, we lost for ever. On 27.09.2013 18:12, Anthony Petrov wrote: Thanks. I skimmed through the changes and they look good generally. A couple of nits: src/share/classes/java/awt/event/ActionListener.java - * @see href="http://java.sun.com/docs/books/tutorial/post

Re: [8] Review request for 8025225: Window.setAlwaysOnTop documentation should be updated

The fix looks good to me. Please remember to file a CCC request and get it approved before pushing specification changes. -- best regards, Anthony On 09/27/2013 06:04 PM, Alexander Zvegintsev wrote: Hi Anthony, Artem, Here is updated webrev: http://cr.openjdk.java.net/~serb/alexz/8025225/web

Re: [8] Review request for 8020688: broken links in documentation at http://docs.oracle.com/javase/6/docs/api/index.

Thanks. I skimmed through the changes and they look good generally. A couple of nits: src/share/classes/java/awt/event/ActionListener.java - * @see http://java.sun.com/docs/books/tutorial/post1.0/ui/eventmodel.html";>Tutorial: Java 1.1 Event Model You're only removing the link here. You shou

Re: [8] Review request for 8025225: Window.setAlwaysOnTop documentation should be updated

Hi Anthony, Artem, Here is updated webrev: http://cr.openjdk.java.net/~serb/alexz/8025225/webrev.01/ Thanks, Alexander. On 09/26/2013 05:22 PM, Artem Ananiev wrote: On 9/24/2013 2:06 PM, Anthony Petrov wrote: Hi Alexander, I suggest to mention that a call to setAlwaysOnTop(false) may also

Re: [8] Review request 7059886: 6 JCK manual awt/Desktop tests fail with GTKLookAndFeel - GTK intialization issue

Hi Anthony, Artem, here is a new version of webrev with suggested improvements: http://cr.openjdk.java.net/~serb/alexz/7059886/webrev.01/ Name of a function in GThreadHelper is not ideal, but I can't think out any better. We don't expect C code to use try - finally, but when we use GThreadHe

Re: [8] Review request for 7092283 Property Window.locationByPlatform is not cleared by calling setVisible(false)

On 09/27/2013 05:03 PM, Alexander Scherbatiy wrote: On 9/27/2013 4:24 PM, Anthony Petrov wrote: I'm not sure if this is the right approach because the setter is overridable. So whenever you update the field, you may actually call user's code which in most cases is undesirable. Also, you really s

Re: [8] Review Request: JDK-8025236 [javadoc] fix some errors in AWT

The fix looks good to me. Again, if possible, I'd suggest to replace with {@code ..} if you're changing a line anyway. -- best regards, Anthony On 09/26/2013 06:21 PM, Dmitry Ginzburg wrote: Hello, AWT Team. Please review the fix for the following issue: https://bugs.openjdk.java.net/browse/

Re: [8] Review Request: JDK-8016563 Test closed/java/awt/dnd/ImageTransferTest/ImageTransferTest.html fails

Looks good. -- best regards, Anthony On 09/27/2013 03:04 PM, Petr Pchelko wrote: Hello, AWT Team. Please review the updated fix here: http://cr.openjdk.java.net/~pchelko/8015563/webrev.01/ We actually need to throw an exception in case the Data conversion failed. With best regards. Petr. On

hg: jdk8/awt/jdk: 8025503: [macosx] FileDialog allows file selection with apple.awt.fileDialogForDirectories = true

Changeset: ad7db846c951 Author:pchelko Date: 2013-09-27 17:04 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ad7db846c951 8025503: [macosx] FileDialog allows file selection with apple.awt.fileDialogForDirectories = true Reviewed-by: serb, anthony ! src/macosx/native/sun/aw

Re: [8] Review request for 7092283 Property Window.locationByPlatform is not cleared by calling setVisible(false)

On 9/27/2013 4:24 PM, Anthony Petrov wrote: Hi Alexander, I'm not sure if this is the right approach because the setter is overridable. So whenever you update the field, you may actually call user's code which in most cases is undesirable. Also, you really shouldn't do this in the context of

Re: [8] Review request for CR 7125471: [macosx] NofocusListDblClickTest should wait between doublr clicks

Hi, Vera. The fix looks good. On 25.09.2013 17:28, vera akulova wrote: Hi Sergey, Could you please review the fix? Thanks, Vera 20.09.2013 16:59, vera akulova пишет: Hello, Please review a fix for the issue: JDK-7125471 : [macosx] NofocusL

Re: [8] Review request for CR JDK-8025218 [javadoc] some errors in java/awt classes

OK, so be it: but please refrain for now from taste driven demands regarding HTML. We are fixing something called by doclint program "errors"; we do not improve generated HTML. I highly appreciate your reviews, thanks, -yan On 09/27/2013 04:32 PM, Anthony Petrov wrote: Hi Yuri, I understand

Re: [8] Review request for 8020688: broken links in documentation at http://docs.oracle.com/javase/6/docs/api/index.

Hi Anthony, Please review a new version: http://cr.openjdk.java.net/~mcherkas/8020688/webrev.02/ I rely on http redirect, but it doesn't always work correctly. Now I re-checked all links. Thanks, Mikhail. On 27.09.2013 12:42, Anthon

Re: [8] Request for review: 7150100 [macosx] "0123456789" is selected in the TextField.

On 27.09.2013 16:36, Anthony Petrov wrote: On 09/27/2013 04:32 PM, Sergey Bylokhov wrote: On 27.09.2013 16:15, Anthony Petrov wrote: Hi Sergey, Where is the comment that you say you've added? I'd expect to see it above the setCaretPosition() calls. It was added to bug evaluation in the bug co

Re: [8] Review request for 7092283 Property Window.locationByPlatform is not cleared by calling setVisible(false)

On 09/27/2013 04:33 PM, Sergey Bylokhov wrote: On 27.09.2013 16:24, Anthony Petrov wrote: Hi Alexander, I'm not sure if this is the right approach because the setter is overridable. So whenever you update the field, you may actually call user's code which in most cases is undesirable. Also, you

Re: [8] Request for review: 7150100 [macosx] "0123456789" is selected in the TextField.

On 09/27/2013 04:32 PM, Sergey Bylokhov wrote: On 27.09.2013 16:15, Anthony Petrov wrote: Hi Sergey, Where is the comment that you say you've added? I'd expect to see it above the setCaretPosition() calls. It was added to bug evaluation in the bug comment. This might better be documented in

Re: [8] Review request for 7092283 Property Window.locationByPlatform is not cleared by calling setVisible(false)

On 27.09.2013 16:24, Anthony Petrov wrote: Hi Alexander, I'm not sure if this is the right approach because the setter is overridable. So whenever you update the field, you may actually call user's code which in most cases is undesirable. Also, you really shouldn't do this in the context of r

Re: [8] Review request for CR JDK-8025218 [javadoc] some errors in java/awt classes

Hi Yuri, I understand the reasoning and mostly agree with it. And I'd be fine to see you as the only reviewer for a test bug fix, for example, because this is mostly the SQE area. However, when it comes to changing library classes, I'd strongly suggest to get at least one review from a dev t

Re: [8] Request for review: 7150100 [macosx] "0123456789" is selected in the TextField.

On 27.09.2013 16:15, Anthony Petrov wrote: Hi Sergey, Where is the comment that you say you've added? I'd expect to see it above the setCaretPosition() calls. It was added to bug evaluation in the bug comment. src/solaris/classes/sun/awt/X11/XTextAreaPeer.java 410 public void setEditab

Re: [8] Review request for 7092283 Property Window.locationByPlatform is not cleared by calling setVisible(false)

Hi Alexander, I'm not sure if this is the right approach because the setter is overridable. So whenever you update the field, you may actually call user's code which in most cases is undesirable. Also, you really shouldn't do this in the context of readObject() because the object isn't fully

Re: [8] Request for review: 7150100 [macosx] "0123456789" is selected in the TextField.

Hi Sergey, Where is the comment that you say you've added? I'd expect to see it above the setCaretPosition() calls. src/solaris/classes/sun/awt/X11/XTextAreaPeer.java 410 public void setEditable(boolean editable) { 411 this.editable = editable; Why do you delete this assignmen

Re: [8] Review Request: JDK-8025440 [TEST_BUG] com/sun/awt/SecurityWarning/GetSizeShouldNotReturnZero.java failed since jdk8b108

Ah, I see. Thanks for the clarification. -- best regards, Anthony On 09/27/2013 04:05 PM, Petr Pchelko wrote: Hello, Anthony. Note that the new utility class has limitations. For instance, it won't copy inner classes belonging to the main copied class. I suggest to document this, or impleme

Re: [8] Review Request: JDK-8025503, [macosx] FileDialog allows file selection with apple.awt.fileDialogForDirectories = true

Looks fine to me. -- best regards, Anthony On 09/26/2013 06:36 PM, Petr Pchelko wrote: Hello, AWT Team. Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8025503 The fix is available at: http://cr.openjdk.java.net/~pchelko/8025503/webrev.00/ This is a simple one-li

Re: [8] Review Request: JDK-8025440 [TEST_BUG] com/sun/awt/SecurityWarning/GetSizeShouldNotReturnZero.java failed since jdk8b108

Hello, Anthony. > Note that the new utility class has limitations. For instance, it won't copy > inner classes belonging to the main copied class. I suggest to document this, > or implement this. Also, I suggest to add a message to the > IllegalArgumentException thrown from the utility class.

Re: [8] Review Request: JDK-8025236 [javadoc] fix some errors in AWT

NB: code → would be better for right arrow but again, our task at hand is to fix errors, not to polish javadoc which is literally endless task without harsh rules to follow. Errors are fixed, go ahead: OK with me. Thanks, -yan On 09/26/2013 06:21 PM, Dmitry Ginzburg wrote: Hello, AWT Team. Pl

Re: [8] Review Request: JDK-8025440 [TEST_BUG] com/sun/awt/SecurityWarning/GetSizeShouldNotReturnZero.java failed since jdk8b108

Hi Petr, Note that the new utility class has limitations. For instance, it won't copy inner classes belonging to the main copied class. I suggest to document this, or implement this. Also, I suggest to add a message to the IllegalArgumentException thrown from the utility class. I have a ques

Re: [8] Review Request: JDK-8016563 Test closed/java/awt/dnd/ImageTransferTest/ImageTransferTest.html fails

Hi, Petr. The fix looks good. But i am sure the code simplification is required. On 27.09.2013 15:04, Petr Pchelko wrote: Hello, AWT Team. Please review the updated fix here: http://cr.openjdk.java.net/~pchelko/8015563/webrev.01/ We actually need to throw an exception in case the Data conversi

Re: [8] Review Request: JDK-8016563 Test closed/java/awt/dnd/ImageTransferTest/ImageTransferTest.html fails

Hello, AWT Team. Please review the updated fix here: http://cr.openjdk.java.net/~pchelko/8015563/webrev.01/ We actually need to throw an exception in case the Data conversion failed. With best regards. Petr. On Sep 27, 2013, at 2:47 PM, Petr Pchelko wrote: > Hello, AWT Team. > > Please revie

Re: [8] Review request for CR JDK-8025218 [javadoc] some errors in java/awt classes

Hi Sergey, I specifically asked Artem about that, and he said that formally, process does require one reviewer; good practice and his personal usual demand is two; for fixes like that one is OK. According to the census, I'm still jdk8 reviewer. Thanks, -yan On 09/27/2013 02:45 PM, Sergey Bylokh

[8] Review Request: JDK-8016563 Test closed/java/awt/dnd/ImageTransferTest/ImageTransferTest.html fails

Hello, AWT Team. Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8016563 The fix is available at: http://cr.openjdk.java.net/~pchelko/8015563/webrev.00/ This is a regression of the fix for JDK-7075105. On of the if clauses was lost during refactoring. With best reg

Re: [8] Review request for CR JDK-8025218 [javadoc] some errors in java/awt classes

Hi, Yuri. According to our process all fixes require 2 reviewers and one of them should be reviewer in the jdk 8 project. On 27.09.2013 14:33, Yuri Nesterenko wrote: Hi Anthony, alas, fix is already in the gate. We will soon have, however, a proper Manual of Style, fortified with doclint and

hg: jdk8/awt/jdk: 8024122: [TEST] need test to cover JDK-7146572

Changeset: ca45169cb4eb Author:pchelko Date: 2013-09-27 14:29 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/ca45169cb4eb 8024122: [TEST] need test to cover JDK-7146572 Reviewed-by: anthony, yan Contributed-by: Alexander Stepanov + test/java/awt/InputMethods/InputMethodsTe

Re: [8] Review request for CR JDK-8025218 [javadoc] some errors in java/awt classes

Hi Anthony, alas, fix is already in the gate. We will soon have, however, a proper Manual of Style, fortified with doclint and requiring HTML 5 compliance etc., and there will be another fixing campaign. Thanks, -yan On 09/27/2013 02:22 PM, Anthony Petrov wrote: Hi Dmitry, While you're at i

Re: [8] Review request for 7092283 Property Window.locationByPlatform is not cleared by calling setVisible(false)

Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/7092283/webrev.01 - the locationByPlatform property is updated by setter method - the open and closed tests are passed with the fix except one which fails without the fix too: java/awt/Dialog/MakeWindowAlwaysOnTop/

Re: [8] Review request for 7117595: ArrayIndexOutOfBoundsException in Win32GraphicsEnvironment if display is removed

The fix looks OK. -- best regards, Anthony On 09/26/2013 05:54 PM, sergey malenkov wrote: Could you please review the following fix: http://cr.openjdk.java.net/~malenkov/7117595.8.3/ Every getDefaultScreenDevice method throws a commented er

Re: [8] Review request for CR JDK-8025218 [javadoc] some errors in java/awt classes

Hi Dmitry, While you're at it, could you also replace ... with {@code ...} at lines that you're changing anyway. E.g.: src/share/classes/java/awt/DefaultKeyboardFocusManager.java - *enqueueKeyEvents, or any value < 0 + *enqueueKeyEvents, or any value < 0 Here, {@code

Re: [8] Request for review: 7150100 [macosx] "0123456789" is selected in the TextField.

Hello. Please review the updated version of the fix for jdk 8. The same problem was found and fixed in xawt as well. http://cr.openjdk.java.net/~serb/7150100/webrev.01 On 09.04.2012 15:03, Artem Ananiev wrote: On 4/6/2012 8:25 PM, Sergey Bylokhov wrote: 05.04.2012 14:53, Artem Ananiev написал:

Re: [8] Review Request: JDK-8025503, [macosx] FileDialog allows file selection with apple.awt.fileDialogForDirectories = true

Hi, Petr. The fix looks good. On 26.09.2013 18:36, Petr Pchelko wrote: Hello, AWT Team. Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8025503 The fix is available at: http://cr.openjdk.java.net/~pchelko/8025503/webrev.00/ This is a simple one-liner. The fChooseD

Re: [8] Review Request for 8024122: need test to cover JDK-7146572

OK with me -yan On 09/09/2013 03:50 PM, alexander stepanov wrote: Hello, Could you please review the fix for the following [TEST] bug: http://bugs.sun.com/view_bug.do?bug_id=8024122 Webrev corresponding: http://cr.openjdk.java.net/~pchelko/stepanov/7146572/webrev.00/ Just a new test added; n

hg: jdk8/awt/jdk: 8025249: [javadoc] fix some javadoc errors in javax/swing/

Changeset: e4e151f6ae50 Author:yan Date: 2013-09-27 12:35 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e4e151f6ae50 8025249: [javadoc] fix some javadoc errors in javax/swing/ Reviewed-by: alexsch, yan Contributed-by: Taras Ledkov ! src/share/classes/javax/swing/border/Co

Re: [8] Review request for 8020688: broken links in documentation at http://docs.oracle.com/javase/6/docs/api/index.

Hi Mikhail, Please comment on the following: src/share/classes/java/awt/Component.java: - * http://java.sun.com/products/jfc/tsc/articles/painting/index.html";>Painting in AWT and Swing. + * http://www.oracle.com/technetwork/java/index.html";>Painting in AWT and Swing. The new link doesn't