hg: jdk8/awt/jdk: 7092283: Property Window.locationByPlatform is not cleared by calling setVisible(false)

Changeset: 39b674405270 Author:alexsch Date: 2013-10-03 19:02 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/39b674405270 7092283: Property Window.locationByPlatform is not cleared by calling setVisible(false) Reviewed-by: anthony, serb ! src/share/classes/java/awt/Window.

hg: jdk8/awt/jdk: 7174704: [macosx] New issue in 7u6 b12: HeadlessPrintingTest failure

Changeset: 1533a379deb0 Author:anthony Date: 2013-10-03 18:01 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/1533a379deb0 7174704: [macosx] New issue in 7u6 b12: HeadlessPrintingTest failure Summary: Load the lwawt native library on Mac regardless of the headless/headful mo

Re: [8] Review request for 7081584: Specification for Window.isAlwaysOnTopSupported needs to be clarified

Looks fine. Thanks, Artem On 10/2/2013 5:34 PM, sergey malenkov wrote: http://cr.openjdk.java.net/~malenkov/7081584.8.1/ The specification is updated. SAM On 02.10.2013 16:29, Artem Ananiev wrote: On 10/2/2013 3:31 PM, sergey malenkov

Re: [8] Review request for 7174704: [macosx] New issue in 7u6 b12: HeadlessPrintingTest failure

Hi, Anthony. The fix looks good. On 02.10.2013 14:34, Anthony Petrov wrote: Hello, Please review a long-awaited back-port of a fix for https://bugs.openjdk.java.net/browse/JDK-7174704 at: http://cr.openjdk.java.net/~anthony/8-61-headlessPrinting-7174704.0/ It is not a direct back-port becau

Re: [8] Review request for 7068423: Spec for java.awt.GraphicsDevice.getFullScreenWindow() needs clarification

On 10/3/2013 11:30 AM, Oleg Pekhovskiy wrote: Hi All, please review the second version of fix: http://cr.openjdk.java.net/~bagiras/7068423.2/ It looks fine to me. Thanks, Artem Reason: Discussed with Artem and Andrew, came to conclusion that there were situations when returned object coul

[8] Review request for 7081594 Windows owned by an always-on-top window DO NOT automatically become always-on-top

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-7081594 webrev: http://cr.openjdk.java.net/~alexsch/7081594/webrev.00 The fix: - sets alwaysOnTop field for a new created window from the parent value - propagates the alwaysOnTop value in setAlwaysOnTop

hg: jdk8/awt/jdk: 8013553: [macosx] java.awt.FileDialog removes file extensions

Changeset: 998578a87c0e Author:bagiras Date: 2013-10-03 16:51 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/998578a87c0e 8013553: [macosx] java.awt.FileDialog removes file extensions Reviewed-by: leonidr, serb ! src/macosx/native/sun/awt/CFileDialog.m

Re: [8] Review request for 8013553: [macosx] java.awt.FileDialog removes file extensions

Hi, Oleg. The fix looks good. On 03.10.2013 16:35, Oleg Pekhovskiy wrote: Hi Sergey, thank you for the review, please review the second version of fix: http://cr.openjdk.java.net/~bagiras/8013553.2/ I split the line and added more comments. Oleg. On 03.10.2013 15:19, Sergey Bylokhov wrote:

Re: [8] Review request for 8013553: [macosx] java.awt.FileDialog removes file extensions

Hi Sergey, thank you for the review, please review the second version of fix: http://cr.openjdk.java.net/~bagiras/8013553.2/ I split the line and added more comments. Oleg. On 03.10.2013 15:19, Sergey Bylokhov wrote: Hi, Oleg. Can you split the line and add the comment that setExtensionHidden

Re: [8] Review request for 8013553: [macosx] java.awt.FileDialog removes file extensions

Thank you, Leonid! Oleg. On 03.10.2013 15:08, Leonid Romanov wrote: Looks good to me. On 03.10.2013, at 13:07, Oleg Pekhovskiy wrote: Hi all, please review the fix http://cr.openjdk.java.net/~bagiras/8013553.1/ for https://bugs.openjdk.java.net/browse/JDK-8013553 setExtensionHidden(NO) me

Re: [7] Review request for backport of 8023310: Thread contention in the method Beans.IsDesignTime()

Hello Mikhail Also looks good for me Thanks alexp On 10/2/2013 3:58 PM, mikhail cherkasov wrote: Hi Sergey, here is results of benchmark: with fix: Result : 103130,558 ¦(95%) 381,949 ¦(99%) 522,101 ops/ms without fix: Result : 15276,871 ¦(95%) 12,841 ¦(99%) 17,553 ops/ms What did you change

Re: [8] Review request for 8013553: [macosx] java.awt.FileDialog removes file extensions

Hi, Oleg. Can you split the line and add the comment that setExtensionHidden is not applicable here. On 03.10.2013 15:08, Leonid Romanov wrote: Looks good to me. On 03.10.2013, at 13:07, Oleg Pekhovskiy wrote: Hi all, please review the fix http://cr.openjdk.java.net/~bagiras/8013553.1/ fo

Re: [8] Review request for 8013553: [macosx] java.awt.FileDialog removes file extensions

Looks good to me. On 03.10.2013, at 13:07, Oleg Pekhovskiy wrote: > Hi all, > > please review the fix > http://cr.openjdk.java.net/~bagiras/8013553.1/ > for > https://bugs.openjdk.java.net/browse/JDK-8013553 > > setExtensionHidden(NO) method of NSSavePanel doesn't work as expected and > that'

Re: [8] Review request for 8020688: broken links in documentation at http://docs.oracle.com/javase/6/docs/api/index.

Hi Anthony, Alexandr, Do you approve the latest version? Thanks, Mikhail. On 01.10.2013 22:21, Anthony Petrov wrote: Hi Mikhail, This "Advanced JList Programming" article seems to vanish, indeed. Although there's a copy at: http://www.comp.nus.edu.sg/~cs3283/ftp/Java/swingConnect/tech_topi

[8] Review request for 8013553: [macosx] java.awt.FileDialog removes file extensions

Hi all, please review the fix http://cr.openjdk.java.net/~bagiras/8013553.1/ for https://bugs.openjdk.java.net/browse/JDK-8013553 setExtensionHidden(NO) method of NSSavePanel doesn't work as expected and that's a known issue mentioned on several forums. But there is another solution based on Ap

Re: [8] Review request for 7068423: Spec for java.awt.GraphicsDevice.getFullScreenWindow() needs clarification

Hi All, please review the second version of fix: http://cr.openjdk.java.net/~bagiras/7068423.2/ Reason: Discussed with Artem and Andrew, came to conclusion that there were situations when returned object could be also set by the system, and not by the client application through setFullScreenWi